You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Yanqin Jin
9586dcf1ce
Expose the initial logger creation error ( #10223 )
...
Summary:
https://github.com/facebook/rocksdb/issues/9984 changes the behavior of RocksDB: if logger creation failed during `SanitizeOptions()`,
`DB::Open()` will fail. However, since `SanitizeOptions()` is called in `DBImpl::DBImpl()`, we cannot
directly expose the error to caller without some additional work.
This is a first version proposal which:
- Adds a new member `init_logger_creation_s` to `DBImpl` to store the result of init logger creation
- Checks the error during `DB::Open()` and return it to caller if non-ok
This is not very ideal. We can alternatively move the logger creation logic out of the `SanitizeOptions()`.
Since `SanitizeOptions()` is used in other places, we need to check whether this change breaks anything
in case other callers of `SanitizeOptions()` assumes that a logger should be created.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/10223
Test Plan: make check
Reviewed By: pdillinger
Differential Revision: D37321717
Pulled By: riversand963
fbshipit-source-id: 58042358a86369d606549dd9938933dd47591c4b
3 years ago
..
agg_merge
Add Aggregation Merge Operator ( #9780 )
3 years ago
backup
Expose the initial logger creation error ( #10223 )
3 years ago
blob_db
Remove own ToString() ( #9955 )
3 years ago
cassandra
Restore Regex support for ObjectLibrary::Register, rename new APIs to allow old one to be deprecated in the future ( #9362 )
3 years ago
checkpoint
Fix race condition with WAL tracking and `FlushWAL(true /* sync */)` ( #10185 )
3 years ago
compaction_filters
Make MergeOperator+CompactionFilter/Factory into Customizable Classes ( #8481 )
3 years ago
convenience
Add a SystemClock class to capture the time functions of an Env ( #7858 )
4 years ago
leveldb_options
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE ( #6433 )
5 years ago
memory
Remove own ToString() ( #9955 )
3 years ago
merge_operators
Remove using namespace ( #9369 )
3 years ago
option_change_migration
Fix some typos in comments and HISTORY.md ( #9798 )
3 years ago
options
Remove own ToString() ( #9955 )
3 years ago
persistent_cache
Remove code that only compiles for Visual Studio versions older than 2015 ( #10065 )
3 years ago
simulator_cache
Remove own ToString() ( #9955 )
3 years ago
table_properties_collectors
Remove own ToString() ( #9955 )
3 years ago
trace
Add rate limiter priority to ReadOptions ( #9424 )
3 years ago
transactions
Add WriteOptions::protection_bytes_per_key ( #10037 )
3 years ago
ttl
Work around some new clang-analyze failures ( #9515 )
3 years ago
write_batch_with_index
Add WriteOptions::protection_bytes_per_key ( #10037 )
3 years ago
cache_dump_load.cc
Introduce a mechanism to dump out blocks from block cache and re-insert to secondary cache ( #8912 )
3 years ago
cache_dump_load_impl.cc
Remove deprecated block-based filter ( #10184 )
3 years ago
cache_dump_load_impl.h
Remove deprecated block-based filter ( #10184 )
3 years ago
compaction_filters.cc
Restore Regex support for ObjectLibrary::Register, rename new APIs to allow old one to be deprecated in the future ( #9362 )
3 years ago
counted_fs.cc
Explicitly closing all directory file descriptors ( #10049 )
3 years ago
counted_fs.h
Explicitly closing all directory file descriptors ( #10049 )
3 years ago
debug.cc
In ParseInternalKey(), include corrupt key info in Status ( #7515 )
4 years ago
env_mirror.cc
Fix clang13 build error ( #9374 )
3 years ago
env_mirror_test.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE ( #6433 )
5 years ago
env_timed.cc
Make FileSystem a Customizable Class ( #8649 )
3 years ago
env_timed.h
Make FileSystem a Customizable Class ( #8649 )
3 years ago
env_timed_test.cc
Make env*_test work with ASSERT_STATUS_CHECKED ( #7176 )
4 years ago
fault_injection_env.cc
Explicitly closing all directory file descriptors ( #10049 )
3 years ago
fault_injection_env.h
Explicitly closing all directory file descriptors ( #10049 )
3 years ago
fault_injection_fs.cc
Explicitly closing all directory file descriptors ( #10049 )
3 years ago
fault_injection_fs.h
Explicitly closing all directory file descriptors ( #10049 )
3 years ago
fault_injection_secondary_cache.cc
Prevent double caching in the compressed secondary cache ( #9747 )
3 years ago
fault_injection_secondary_cache.h
Prevent double caching in the compressed secondary cache ( #9747 )
3 years ago
memory_allocators.h
Make MemoryAllocator into a Customizable class ( #8980 )
3 years ago
merge_operators.cc
Restore Regex support for ObjectLibrary::Register, rename new APIs to allow old one to be deprecated in the future ( #9362 )
3 years ago
merge_operators.h
Make MergeOperator+CompactionFilter/Factory into Customizable Classes ( #8481 )
3 years ago
object_registry.cc
Added GetFactoryCount/Names/Types to ObjectRegistry ( #9358 )
3 years ago
object_registry_test.cc
Added GetFactoryCount/Names/Types to ObjectRegistry ( #9358 )
3 years ago
util_merge_operators_test.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE ( #6433 )
5 years ago
wal_filter.cc
Make WalFilter, SstPartitionerFactory, FileChecksumGenFactory, and TableProperties Customizable ( #8638 )
3 years ago