fork of https://github.com/oxigraph/rocksdb and https://github.com/facebook/rocksdb for nextgraph and oxigraph

You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Vijay Nadimpalli 4c49e38f15 MultiGet batching in memtable (#5818) ... Summary: RocksDB has a MultiGet() API that implements batched key lookup for higher performance (https://github.com/facebook/rocksdb/blob/master/include/rocksdb/db.h#L468). Currently, batching is implemented in BlockBasedTableReader::MultiGet() for SST file lookups. One of the ways it improves performance is by pipelining bloom filter lookups (by prefetching required cachelines for all the keys in the batch, and then doing the probe) and thus hiding the cache miss latency. The same concept can be extended to the memtable as well. This PR involves implementing a pipelined bloom filter lookup in DynamicBloom, and implementing MemTable::MultiGet() that can leverage it. Pull Request resolved: https://github.com/facebook/rocksdb/pull/5818 Test Plan: Existing tests Performance Test: Ran the below command which fills up the memtable and makes sure there are no flushes and then call multiget. Ran it on master and on the new change and see atleast 1% performance improvement across all the test runs I did. Sometimes the improvement was upto 5%. TEST_TMPDIR=/data/users/$USER/benchmarks/feature/ numactl -C 10 ./db_bench -benchmarks="fillseq,multireadrandom" -num=600000 -compression_type="none" -level_compaction_dynamic_level_bytes -write_buffer_size=200000000 -target_file_size_base=200000000 -max_bytes_for_level_base=16777216 -reads=90000 -threads=1 -compression_type=none -cache_size=4194304000 -batch_size=32 -disable_auto_compactions=true -bloom_bits=10 -cache_index_and_filter_blocks=true -pin_l0_filter_and_index_blocks_in_cache=true -multiread_batched=true -multiread_stride=4 -statistics -memtable_whole_key_filtering=true -memtable_bloom_size_ratio=10 Differential Revision: D17578869 Pulled By: vjnadimpalli fbshipit-source-id: 23dc651d9bf49db11d22375bf435708875a1f192		5 years ago
..
db_impl.cc	MultiGet batching in memtable (#5818)	5 years ago
db_impl.h	Fix crash when background task fails (#5879)	5 years ago
db_impl_compaction_flush.cc	Fix crash when background task fails (#5879)	5 years ago
db_impl_debug.cc	Add command "list_file_range_deletes" in ldb (#5615)	5 years ago
db_impl_experimental.cc	simplify include directive involving inttypes (#5402)	5 years ago
db_impl_files.cc	Move WAL-closing loop out of original loop (#5804)	5 years ago
db_impl_open.cc	Fix crash when background task fails (#5879)	5 years ago
db_impl_readonly.cc	Apply formatter on recent 45 commits. (#5827)	5 years ago
db_impl_readonly.h	Use delete to disable automatic generated methods. (#5009)	5 years ago
db_impl_secondary.cc	Apply formatter to recent 200+ commits. (#5830)	5 years ago
db_impl_secondary.h	Override check consistency for DBImplSecondary (#5469)	5 years ago
db_impl_write.cc	Add insert hints for each writebatch (#5728)	5 years ago
db_secondary_test.cc	Apply formatter to recent 200+ commits. (#5830)	5 years ago