fork of https://github.com/oxigraph/rocksdb and https://github.com/facebook/rocksdb for nextgraph and oxigraph

You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Changyu Bi b0e190604b Update VersionSet last seqno after LogAndApply (#10051) ... Summary: This PR fixes the issue of unstable snapshot during external SST file ingestion. Credit ajkr for the following walk through: consider these relevant steps for of IngestExternalFile(): (1) increase seqno while holding mutex -- 677d2b4a8f/db/db_impl/db_impl.cc (L4768) (2) LogAndApply() -- 677d2b4a8f/db/db_impl/db_impl.cc (L4797-L4798) (a) write to MANIFEST with mutex released a96a4a2f7b/db/version_set.cc (L4407) (b) apply to in-memory state with mutex held A snapshot taken during (2a) will be unstable. In particular, queries against that snapshot will not include data from the ingested file before (2b), and will include data from the ingested file after (2b). Pull Request resolved: https://github.com/facebook/rocksdb/pull/10051 Test Plan: Added a new unit test: `ExternalSSTFileBasicTest.WriteAfterReopenStableSnapshotWhileLoggingToManifest`. ``` make external_sst_file_basic_test ./external_sst_file_basic_test ``` Reviewed By: ajkr Differential Revision: D36654033 Pulled By: cbi42 fbshipit-source-id: bf720cca313e0cf211585960f3aff04853a31b96		2 years ago
..
compacted_db_impl.cc	Add timestamp support to CompactedDBImpl (#10030)	2 years ago
compacted_db_impl.h	Add timestamp support to CompactedDBImpl (#10030)	2 years ago
db_impl.cc	Update VersionSet last seqno after LogAndApply (#10051)	2 years ago
db_impl.h	Add timestamp support to DBImplReadOnly (#10004)	2 years ago
db_impl_compaction_flush.cc	Move three info logging within DB Mutex to use log buffer (#10029)	2 years ago
db_impl_debug.cc	Use std::numeric_limits<> (#9954)	2 years ago
db_impl_experimental.cc	Track SST unique id in MANIFEST and verify (#9990)	2 years ago
db_impl_files.cc	Use std::numeric_limits<> (#9954)	2 years ago
db_impl_open.cc	Track SST unique id in MANIFEST and verify (#9990)	2 years ago
db_impl_readonly.cc	Add timestamp support to DBImplReadOnly (#10004)	2 years ago
db_impl_readonly.h	Add timestamp support to DBImplReadOnly (#10004)	2 years ago
db_impl_secondary.cc	Track SST unique id in MANIFEST and verify (#9990)	2 years ago
db_impl_secondary.h	Revert open logic changes in #9634 (#9906)	2 years ago
db_impl_write.cc	Do not release and re-acquire dbmutex on memtable-switch if no listener (#9758)	2 years ago