fork of https://github.com/oxigraph/rocksdb and https://github.com/facebook/rocksdb for nextgraph and oxigraph

You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Changyu Bi bc04ec85db Make option `level_compaction_dynamic_level_bytes` true by default (#11525) ... Summary: after https://github.com/facebook/rocksdb/issues/11321 and https://github.com/facebook/rocksdb/issues/11340 (both included in RocksDB v8.2), migration from `level_compaction_dynamic_level_bytes=false` to `level_compaction_dynamic_level_bytes=true` is automatic by RocksDB and requires no manual compaction from user. Making the option true by default as it has several advantages: 1. better space amplification guarantee (a more stable LSM shape). 2. compaction is more adaptive to write traffic. 3. automatic draining of unneeded levels. Wiki is updated with more detail: https://github.com/facebook/rocksdb/wiki/Leveled-Compaction#option-level_compaction_dynamic_level_bytes-and-levels-target-size. The PR mostly contains fixes for unit tests as they assumed `level_compaction_dynamic_level_bytes=false`. Most notable change is commit f742be330c and b1928e42b3 which override the default option in DBTestBase to still set `level_compaction_dynamic_level_bytes=false` by default. This helps to reduce the change needed for unit tests. I think this default option override in unit tests is okay since the behavior of `level_compaction_dynamic_level_bytes=true` is tested by explicitly setting this option. Also, `level_compaction_dynamic_level_bytes=false` may be more desired in unit tests as it makes it easier to create a desired LSM shape. Comment for option `level_compaction_dynamic_level_bytes` is updated to reflect this change and change made in https://github.com/facebook/rocksdb/issues/10057. Pull Request resolved: https://github.com/facebook/rocksdb/pull/11525 Test Plan: `make -j32 J=32 check` several times to try to catch flaky tests due to this option change. Reviewed By: ajkr Differential Revision: D46654256 Pulled By: cbi42 fbshipit-source-id: 6b5827dae124f6f1fdc8cca2ac6f6fcd878830e1		2 years ago
..
clipping_iterator.h	Refactor AddRangeDels() + consider range tombstone during compaction file cutting (#11113)	2 years ago
clipping_iterator_test.cc	Print stack traces on frozen tests in CI (#10828)	2 years ago
compaction.cc	Drop range tombstone during non-bottommost compaction (#11459)	2 years ago
compaction.h	Drop range tombstone during non-bottommost compaction (#11459)	2 years ago
compaction_iteration_stats.h	Support readahead during compaction for blob files (#9187)	3 years ago
compaction_iterator.cc	Group rocksdb.sst.read.micros stat by IOActivity flush and compaction (#11288)	2 years ago
compaction_iterator.h	Refactor AddRangeDels() + consider range tombstone during compaction file cutting (#11113)	2 years ago
compaction_iterator_test.cc	Basic Support for Merge with user-defined timestamp (#10819)	2 years ago
compaction_job.cc	Fix subcompaction bug to allow running two subcompactions (#11501)	2 years ago
compaction_job.h	Refactor AddRangeDels() + consider range tombstone during compaction file cutting (#11113)	2 years ago
compaction_job_stats_test.cc	Make option `level_compaction_dynamic_level_bytes` true by default (#11525)	2 years ago
compaction_job_test.cc	Record and use the tail size to prefetch table tail (#11406)	2 years ago
compaction_outputs.cc	Drop range tombstone during non-bottommost compaction (#11459)	2 years ago
compaction_outputs.h	Drop range tombstone during non-bottommost compaction (#11459)	2 years ago
compaction_picker.cc	Do not include last level in compaction when `allow_ingest_behind=true` (#11489)	2 years ago
compaction_picker.h	Remove RocksDB LITE (#11147)	2 years ago
compaction_picker_fifo.cc	Support compacting files to different temperatures in FIFO compaction (#11428)	2 years ago
compaction_picker_fifo.h	Support compacting files to different temperatures in FIFO compaction (#11428)	2 years ago
compaction_picker_level.cc	Try to pick more files in `LevelCompactionBuilder::TryExtendNonL0TrivialMove()` (#11347)	2 years ago
compaction_picker_level.h	Sort L0 files by newly introduced epoch_num (#10922)	2 years ago
compaction_picker_test.cc	Make option `level_compaction_dynamic_level_bytes` true by default (#11525)	2 years ago
compaction_picker_universal.cc	Do not include last level in compaction when `allow_ingest_behind=true` (#11489)	2 years ago
compaction_picker_universal.h	Remove RocksDB LITE (#11147)	2 years ago
compaction_service_job.cc	Remove RocksDB LITE (#11147)	2 years ago
compaction_service_test.cc	Remove wait_unscheduled from waitForCompact internal API (#11443)	2 years ago
compaction_state.cc	Tiered Compaction: per key placement support (#9964)	2 years ago
compaction_state.h	Tiered Compaction: per key placement support (#9964)	2 years ago
file_pri.h	Try to start TTL earlier with kMinOverlappingRatio is used (#8749)	3 years ago
sst_partitioner.cc	Remove FactoryFunc from LoadXXXObject (#11203)	2 years ago
subcompaction_state.cc	Refactor Compaction file cut `ShouldStopBefore()` (#10629)	2 years ago
subcompaction_state.h	Refactor AddRangeDels() + consider range tombstone during compaction file cutting (#11113)	2 years ago
tiered_compaction_test.cc	Add WaitForCompact with WaitForCompactOptions to public API (#11436)	2 years ago