fork of https://github.com/oxigraph/rocksdb and https://github.com/facebook/rocksdb for nextgraph and oxigraph

You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Changyu Bi 4d0f9a995c Consider TTL compaction file cutting earlier to prevent small output file (#11075) ... Summary: in `CompactionOutputs::ShouldStopBefore()`, TTL-related states, `cur_files_to_cut_for_ttl_` and `next_files_to_cut_for_ttl_`, are not updated if the function returns early. This can cause unnecessary compaction output file cuttings and hence produce smaller output files, which may hurt write amp. See the example in the unit test for how this "unnecessary file cutting" can happen. This PR fixes this issue by moving the code for updating TTL states earlier in `CompactionOutputs::ShouldStopBefore()` so that the states are updated for each key. Pull Request resolved: https://github.com/facebook/rocksdb/pull/11075 Test Plan: - Added new unit test. Reviewed By: hx235 Differential Revision: D42398739 Pulled By: cbi42 fbshipit-source-id: 09fab66679c1a734abcfc31bcea33dd9aeb9dbc7		2 years ago
..
clipping_iterator.h	Revert #10802 Consider range tombstone in compaction output file cutting (#11089)	2 years ago
clipping_iterator_test.cc	Print stack traces on frozen tests in CI (#10828)	2 years ago
compaction.cc	Revert #10802 Consider range tombstone in compaction output file cutting (#11089)	2 years ago
compaction.h	Revert #10802 Consider range tombstone in compaction output file cutting (#11089)	2 years ago
compaction_iteration_stats.h	Support readahead during compaction for blob files (#9187)	3 years ago
compaction_iterator.cc	Revert #10802 Consider range tombstone in compaction output file cutting (#11089)	2 years ago
compaction_iterator.h	Revert #10802 Consider range tombstone in compaction output file cutting (#11089)	2 years ago
compaction_iterator_test.cc	Basic Support for Merge with user-defined timestamp (#10819)	2 years ago
compaction_job.cc	Revert #10802 Consider range tombstone in compaction output file cutting (#11089)	2 years ago
compaction_job.h	Sort L0 files by newly introduced epoch_num (#10922)	2 years ago
compaction_job_stats_test.cc	clang-format for db/compaction (#10882)	2 years ago
compaction_job_test.cc	Include estimated bytes deleted by range tombstones in compensated file size (#10734)	2 years ago
compaction_outputs.cc	Consider TTL compaction file cutting earlier to prevent small output file (#11075)	2 years ago
compaction_outputs.h	Consider TTL compaction file cutting earlier to prevent small output file (#11075)	2 years ago
compaction_picker.cc	Add missing range conflict check between file ingestion and RefitLevel() (#10988)	2 years ago
compaction_picker.h	Sort L0 files by newly introduced epoch_num (#10922)	2 years ago
compaction_picker_fifo.cc	Sort L0 files by newly introduced epoch_num (#10922)	2 years ago
compaction_picker_fifo.h	Sort L0 files by newly introduced epoch_num (#10922)	2 years ago
compaction_picker_level.cc	Add missing range conflict check between file ingestion and RefitLevel() (#10988)	2 years ago
compaction_picker_level.h	Sort L0 files by newly introduced epoch_num (#10922)	2 years ago
compaction_picker_test.cc	Include estimated bytes deleted by range tombstones in compensated file size (#10734)	2 years ago
compaction_picker_universal.cc	Sort L0 files by newly introduced epoch_num (#10922)	2 years ago
compaction_picker_universal.h	Sort L0 files by newly introduced epoch_num (#10922)	2 years ago
compaction_service_job.cc	Sort L0 files by newly introduced epoch_num (#10922)	2 years ago
compaction_service_test.cc	Deflake CompactionServiceTest.BasicCompactions (#10697)	2 years ago
compaction_state.cc	Tiered Compaction: per key placement support (#9964)	2 years ago
compaction_state.h	Tiered Compaction: per key placement support (#9964)	2 years ago
file_pri.h	Try to start TTL earlier with kMinOverlappingRatio is used (#8749)	3 years ago
sst_partitioner.cc	Restore Regex support for ObjectLibrary::Register, rename new APIs to allow old one to be deprecated in the future (#9362)	3 years ago
subcompaction_state.cc	Refactor Compaction file cut `ShouldStopBefore()` (#10629)	2 years ago
subcompaction_state.h	Revert #10802 Consider range tombstone in compaction output file cutting (#11089)	2 years ago
tiered_compaction_test.cc	Add an unittest for Periodic compaction conflict with ongoing compaction (#10908)	2 years ago