fork of https://github.com/oxigraph/rocksdb and https://github.com/facebook/rocksdb for nextgraph and oxigraph

You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Yanqin Jin cb1bf09bfc Fix tsan error (#5414) ... Summary: Previous code has a warning when compile with tsan, leading to an error since we have -Werror. Compilation result ``` In file included from ./env/env_chroot.h:12, from env/env_test.cc:40: ./include/rocksdb/env.h: In instantiation of ‘rocksdb::Status rocksdb::DynamicLibrary::LoadFunction(const string&, std::function<T>*) [with T = void*(void*, const char*); std::__cxx11::string = std::__cxx11::basic_string<char>]’: env/env_test.cc:260:5: required from here ./include/rocksdb/env.h:1010:17: error: cast between incompatible function types from ‘rocksdb::DynamicLibrary::FunctionPtr’ {aka ‘void* (*)()’} to ‘void* (*)(void*, const char*)’ [-Werror=cast-function-type] *function = reinterpret_cast<T*>(ptr); ^~~~~~~~~~~~~~~~~~~~~~~~~ cc1plus: all warnings being treated as errors make: *** [env/env_test.o] Error 1 ``` It also has another error reported by clang ``` env/env_posix.cc:141:11: warning: Value stored to 'err' during its initialization is never read char* err = dlerror(); // Clear any old error ^~~ ~~~~~~~~~ 1 warning generated. ``` Test plan (on my devserver). ``` $make clean $OPT=-g ROCKSDB_FBCODE_BUILD_WITH_PLATFORM007=1 COMPILE_WITH_TSAN=1 make -j32 $ $make clean $USE_CLANG=1 TEST_TMPDIR=/dev/shm/rocksdb OPT=-g make -j1 analyze ``` Both should pass. Pull Request resolved: https://github.com/facebook/rocksdb/pull/5414 Differential Revision: D15637315 Pulled By: riversand963 fbshipit-source-id: 8e307483761019a4d5998cab92d49516d7edffbf		5 years ago
..
env.cc	Move some memory related files from util/ to memory/ (#5382)	5 years ago
env_basic_test.cc	Move test related files under util/ to test_util/ (#5377)	5 years ago
env_chroot.cc	Apply modernize-use-override (3)	5 years ago
env_chroot.h	Change RocksDB License	7 years ago
env_encryption.cc	Change OptimizeForPointLookup() and OptimizeForSmallDb() (#5165)	5 years ago
env_hdfs.cc	Move some logging related files to logging/ (#5387)	5 years ago
env_posix.cc	Fix tsan error (#5414)	5 years ago
env_test.cc	Add a MultiRead() method to Env (#5311)	5 years ago
io_posix.cc	Move some logging related files to logging/ (#5387)	5 years ago
io_posix.h	Optionally wait on bytes_per_sync to smooth I/O (#5183)	5 years ago
mock_env.cc	Apply modernize-use-override (3)	5 years ago
mock_env.h	Update all unique/shared_ptr instances to be qualified with namespace std (#4638)	6 years ago
mock_env_test.cc	Move test related files under util/ to test_util/ (#5377)	5 years ago