fork of https://github.com/oxigraph/rocksdb and https://github.com/facebook/rocksdb for nextgraph and oxigraph

You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Yu Zhang 8dfcfd4e90 Fix backward iteration issue when user defined timestamp is enabled in BlobDB (#11258) ... Summary: During backward iteration, blob verification would fail because the user key (ts included) in `saved_key_` doesn't match the blob. This happens because during`FindValueForCurrentKey`, `saved_key_` is not updated when the user key(ts not included) is the same for all cases except when `timestamp_lb_` is specified. This breaks the blob verification logic when user defined timestamp is enabled and `timestamp_lb_` is not specified. Fix this by always updating `saved_key_` when a smaller user key (ts included) is seen. Pull Request resolved: https://github.com/facebook/rocksdb/pull/11258 Test Plan: `make check` `./db_blob_basic_test --gtest_filter=DBBlobWithTimestampTest.IterateBlobs` Run db_bench (built with DEBUG_LEVEL=0) to demonstrate that no overhead is introduced with: `./db_bench -user_timestamp_size=8 -db=/dev/shm/rocksdb -disable_wal=1 -benchmarks=fillseq,seekrandom[-W1-X6] -reverse_iterator=1 -seek_nexts=5` Baseline: - seekrandom [AVG 6 runs] : 72188 (± 1481) ops/sec; 37.2 (± 0.8) MB/sec With this PR: - seekrandom [AVG 6 runs] : 74171 (± 1427) ops/sec; 38.2 (± 0.7) MB/sec Reviewed By: ltamasi Differential Revision: D43675642 Pulled By: jowlyzhang fbshipit-source-id: 8022ae8522d1f66548821855e6eed63640c14e04		2 years ago
..
blob_constants.h	Move BlobDB related files under db/ to db/blob/ (#6519)	5 years ago
blob_contents.cc	Major Cache refactoring, CPU efficiency improvement (#10975)	2 years ago
blob_contents.h	Put Cache and CacheWrapper in new public header (#11192)	2 years ago
blob_counting_iterator.h	Refactor AddRangeDels() + consider range tombstone during compaction file cutting (#11113)	2 years ago
blob_counting_iterator_test.cc	Print stack traces on frozen tests in CI (#10828)	2 years ago
blob_fetcher.cc	Support readahead during compaction for blob files (#9187)	3 years ago
blob_fetcher.h	Support readahead during compaction for blob files (#9187)	3 years ago
blob_file_addition.cc	Print blob file checksums as hex (#8437)	4 years ago
blob_file_addition.h	Move BlobDB related files under db/ to db/blob/ (#6519)	5 years ago
blob_file_addition_test.cc	Print stack traces on frozen tests in CI (#10828)	2 years ago
blob_file_builder.cc	Major Cache refactoring, CPU efficiency improvement (#10975)	2 years ago
blob_file_builder.h	Support prepopulating/warming the blob cache (#10298)	2 years ago
blob_file_builder_test.cc	Print stack traces on frozen tests in CI (#10828)	2 years ago
blob_file_cache.cc	Major Cache refactoring, CPU efficiency improvement (#10975)	2 years ago
blob_file_cache.h	Major Cache refactoring, CPU efficiency improvement (#10975)	2 years ago
blob_file_cache_test.cc	Print stack traces on frozen tests in CI (#10828)	2 years ago
blob_file_completion_callback.h	Remove RocksDB LITE (#11147)	2 years ago
blob_file_garbage.cc	Move BlobDB related files under db/ to db/blob/ (#6519)	5 years ago
blob_file_garbage.h	Move BlobDB related files under db/ to db/blob/ (#6519)	5 years ago
blob_file_garbage_test.cc	Print stack traces on frozen tests in CI (#10828)	2 years ago
blob_file_meta.cc	Add BlobMetaData retrieval methods (#8273)	4 years ago
blob_file_meta.h	Add BlobMetaData retrieval methods (#8273)	4 years ago
blob_file_reader.cc	Major Cache refactoring, CPU efficiency improvement (#10975)	2 years ago
blob_file_reader.h	Eliminate some allocations/copies around the blob cache (#10647)	2 years ago
blob_file_reader_test.cc	Print stack traces on frozen tests in CI (#10828)	2 years ago
blob_garbage_meter.cc	Add a class for measuring the amount of garbage generated during compaction (#8426)	4 years ago
blob_garbage_meter.h	Add a class for measuring the amount of garbage generated during compaction (#8426)	4 years ago
blob_garbage_meter_test.cc	Print stack traces on frozen tests in CI (#10828)	2 years ago
blob_index.h	Remove local static string (#8103)	2 years ago
blob_log_format.cc	Remove local static string (#8103)	2 years ago
blob_log_format.h	Run clang-format on db/blob/ (#10856)	2 years ago
blob_log_sequential_reader.cc	Add rate limiter priority to ReadOptions (#9424)	3 years ago
blob_log_sequential_reader.h	Fix a issue with initializing blob header buffer (#8537)	3 years ago
blob_log_writer.cc	WritableFileWriter tries to skip operations after failure (#10489)	2 years ago
blob_log_writer.h	Use SystemClock* instead of std::shared_ptr<SystemClock> in lower level routines (#8033)	4 years ago
blob_read_request.h	Enable blob caching for MultiGetBlob in RocksDB (#10272)	3 years ago
blob_source.cc	Remove RocksDB LITE (#11147)	2 years ago
blob_source.h	Major Cache refactoring, CPU efficiency improvement (#10975)	2 years ago
blob_source_test.cc	Remove RocksDB LITE (#11147)	2 years ago
db_blob_basic_test.cc	Fix backward iteration issue when user defined timestamp is enabled in BlobDB (#11258)	2 years ago
db_blob_compaction_test.cc	Remove RocksDB LITE (#11147)	2 years ago
db_blob_corruption_test.cc	Remove RocksDB LITE (#11147)	2 years ago
db_blob_index_test.cc	Remove RocksDB LITE (#11147)	2 years ago
prefetch_buffer_collection.cc	Support readahead during compaction for blob files (#9187)	3 years ago
prefetch_buffer_collection.h	Support readahead during compaction for blob files (#9187)	3 years ago