You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Kai Liu
958b9c80e1
Avoid global static initialization in Env::Default()
...
Summary:
Mark's task description from #2316777
Env::Default() comes from util/env_posix.cc
This is a static global.
static PosixEnv default_env;
Env* Env::Default() {
return &default_env;
}
-----
These globals assume default_env was initialized first. I don't think that is safe or correct to do (http://stackoverflow.com/questions/1005685/c-static-initialization-order )
const string AutoRollLoggerTest::kTestDir(
test::TmpDir() + "/db_log_test");
const string AutoRollLoggerTest::kLogFile(
test::TmpDir() + "/db_log_test/LOG");
Env* AutoRollLoggerTest::env = Env::Default();
Test Plan:
run make clean && make && make check
But how can I know if it works in Ubuntu?
Reviewers: MarkCallaghan, chip
Reviewed By: chip
CC: leveldb, dhruba, haobo
Differential Revision: https://reviews.facebook.net/D10491
12 years ago
..
arena.cc
Codemod NULL to nullptr
12 years ago
arena.h
A number of fixes:
13 years ago
arena_test.cc
Fix all warnings generated by -Wall option to the compiler.
12 years ago
auto_roll_logger.cc
Allow the logs to be purged by TTL.
12 years ago
auto_roll_logger.h
Allow the logs to be purged by TTL.
12 years ago
auto_roll_logger_test.cc
Fix valgrind errors in rocksdb tests: auto_roll_logger_test, reduce_levels_test
12 years ago
bloom.cc
Fix all the lint errors.
12 years ago
bloom_test.cc
Fix all warnings generated by -Wall option to the compiler.
12 years ago
build_version.h
Stop continually re-creating build_version.c
12 years ago
cache.cc
[RocksDB] Fix LRUCache Eviction problem
12 years ago
cache_test.cc
[RocksDB] Fix LRUCache Eviction problem
12 years ago
coding.cc
Codemod NULL to nullptr
12 years ago
coding.h
Codemod NULL to nullptr
12 years ago
coding_test.cc
Codemod NULL to nullptr
12 years ago
comparator.cc
merge 1.5
12 years ago
crc32c.cc
Codemod NULL to nullptr
12 years ago
crc32c.h
A number of fixes:
13 years ago
crc32c_test.cc
Fix all warnings generated by -Wall option to the compiler.
12 years ago
env.cc
Ability to configure bufferedio-reads, filesystem-readaheads and mmap-read-write per database.
12 years ago
env_hdfs.cc
Ability to configure bufferedio-reads, filesystem-readaheads and mmap-read-write per database.
12 years ago
env_posix.cc
Avoid global static initialization in Env::Default()
12 years ago
env_test.cc
Ability to configure bufferedio-reads, filesystem-readaheads and mmap-read-write per database.
12 years ago
filelock_test.cc
Prevent concurrent multiple opens of leveldb database.
13 years ago
filter_policy.cc
Added bloom filter support.
13 years ago
hash.cc
A number of fixes:
13 years ago
hash.h
reverting disastrous MOE commit, returning to r21
14 years ago
histogram.cc
Add --writes_per_second rate limit, print p99.99 in histogram
12 years ago
histogram.h
Introduce histogram in statistics.h
12 years ago
histogram_test.cc
Introduce histogram in statistics.h
12 years ago
ldb_cmd.cc
[RocksDB] Expose LDB functioanality as a library call - clients can build their own LDB binary with additional options
12 years ago
ldb_cmd.h
[RocksDB] Expose LDB functioanality as a library call - clients can build their own LDB binary with additional options
12 years ago
ldb_cmd_execute_result.h
Enhanced ldb to support data access commands
12 years ago
ldb_tool.cc
[RocksDB] Expose LDB functioanality as a library call - clients can build their own LDB binary with additional options
12 years ago
logging.cc
Fix all warnings generated by -Wall option to the compiler.
12 years ago
logging.h
A number of fixes:
13 years ago
murmurhash.cc
Implement RowLocks for assoc schema
12 years ago
murmurhash.h
Implement RowLocks for assoc schema
12 years ago
mutexlock.h
Implement ReadWrite locks for leveldb
12 years ago
options.cc
Set FD_CLOEXEC after each file open
12 years ago
posix_logger.h
[RocksDB] posix_logger does not compile on non-linux platform
12 years ago
random.h
A number of fixes:
13 years ago
signal_test.cc
[RocksDB] fix build
12 years ago
stack_trace.h
[RocksDB] Add stacktrace signal handler
12 years ago
stats_logger.h
Clean up compiler warnings generated by -Wall option.
12 years ago
status.cc
Codemod NULL to nullptr
12 years ago
stop_watch.h
memory manage statistics
12 years ago
storage_options.h
Set FD_CLOEXEC after each file open
12 years ago
testharness.cc
Codemod NULL to nullptr
12 years ago
testharness.h
A number of fixes:
13 years ago
testutil.cc
Fix all warnings generated by -Wall option to the compiler.
12 years ago
testutil.h
Ability to configure bufferedio-reads, filesystem-readaheads and mmap-read-write per database.
12 years ago