fork of https://github.com/oxigraph/rocksdb and https://github.com/facebook/rocksdb for nextgraph and oxigraph

You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Andrew Kryczka 48e8baebc0 Decouple data iterator and range deletion iterator in TableCache ... Summary: Previously we used TableCache::NewIterator() for multiple purposes (data block iterator and range deletion iterator), and returned non-ok status in the data block iterator. In one case where the caller only used the range deletion block iterator (9e7cf3469b/db/version_set.cc (L965-L973)), we didn't check/free the data block iterator containing non-ok status, which caused a valgrind error. So, this diff decouples creation of data block and range deletion block iterators, and updates the callers accordingly. Both functions can return non-ok status in an InternalIterator. Since the non-ok status is returned in an iterator that the callers will definitely use, it should be more usable/less error-prone. Closes https://github.com/facebook/rocksdb/pull/1513 Differential Revision: D4181423 Pulled By: ajkr fbshipit-source-id: 835b8f5		8 years ago
..
adaptive_table_factory.cc	solve the problem of table_factory_to_write_=nullptr (#1342)	8 years ago
adaptive_table_factory.h	Only cache level 0 indexes and filter when opening table reader	8 years ago
block.cc	Support SST files with Global sequence numbers [reland]	8 years ago
block.h	Fix wrong comment (Maximum supported block size)	8 years ago
block_based_filter_block.cc	BlockBasedTable::FullFilterKeyMayMatch() Should skip prefix bloom if full key bloom exists	9 years ago
block_based_filter_block.h	BlockBasedTable::FullFilterKeyMayMatch() Should skip prefix bloom if full key bloom exists	9 years ago
block_based_filter_block_test.cc	Add statistics field to show total size of index and filter blocks in block cache	9 years ago
block_based_table_builder.cc	Change ioptions to store user_comparator, fix bug	8 years ago
block_based_table_builder.h	Compaction Support for Range Deletion	8 years ago
block_based_table_factory.cc	Only cache level 0 indexes and filter when opening table reader	8 years ago
block_based_table_factory.h	Only cache level 0 indexes and filter when opening table reader	8 years ago
block_based_table_reader.cc	sst_dump support for range deletion	8 years ago
block_based_table_reader.h	sst_dump support for range deletion	8 years ago
block_builder.cc	Miscellaneous performance improvements	8 years ago
block_builder.h	TableBuilder / TableReader support for range deletion	8 years ago
block_prefix_index.cc	Fix clang analyzer errors	8 years ago
block_prefix_index.h	Updated all copyright headers to the new format.	9 years ago
block_test.cc	Support SST files with Global sequence numbers [reland]	8 years ago
bloom_block.cc	Updated all copyright headers to the new format.	9 years ago
bloom_block.h	Updated all copyright headers to the new format.	9 years ago
cuckoo_table_builder.cc	Embed column family name in SST file	9 years ago
cuckoo_table_builder.h	Embed column family name in SST file	9 years ago
cuckoo_table_builder_test.cc	New Statistics to track Compression/Decompression (#1197)	8 years ago
cuckoo_table_factory.cc	Only cache level 0 indexes and filter when opening table reader	8 years ago
cuckoo_table_factory.h	Only cache level 0 indexes and filter when opening table reader	8 years ago
cuckoo_table_reader.cc	Add SeekForPrev() to Iterator	8 years ago
cuckoo_table_reader.h	Remove ImmutableCFOptions from public API	8 years ago
cuckoo_table_reader_test.cc	DeleteRange Get support	8 years ago
filter_block.h	BlockBasedTable::FullFilterKeyMayMatch() Should skip prefix bloom if full key bloom exists	9 years ago
flush_block_policy.cc	Miscellaneous performance improvements	8 years ago
format.cc	Insert range deletion meta-block into block cache	8 years ago
format.h	Insert range deletion meta-block into block cache	8 years ago
full_filter_block.cc	BlockBasedTable::FullFilterKeyMayMatch() Should skip prefix bloom if full key bloom exists	9 years ago
full_filter_block.h	BlockBasedTable::FullFilterKeyMayMatch() Should skip prefix bloom if full key bloom exists	9 years ago
full_filter_block_test.cc	Add statistics field to show total size of index and filter blocks in block cache	9 years ago
get_context.cc	Decouple data iterator and range deletion iterator in TableCache	8 years ago
get_context.h	Decouple data iterator and range deletion iterator in TableCache	8 years ago
internal_iterator.h	fix assertion failure in Prev()	8 years ago
iter_heap.h	Updated all copyright headers to the new format.	9 years ago
iterator.cc	Add SeekForPrev() to Iterator	8 years ago
iterator_wrapper.h	Add SeekForPrev() to Iterator	8 years ago
merger.cc	revert Prev() in MergingIterator to use previous code in non-prefix-seek mode	8 years ago
merger.h	revert Prev() in MergingIterator to use previous code in non-prefix-seek mode	8 years ago
merger_test.cc	Updated all copyright headers to the new format.	9 years ago
meta_blocks.cc	Support SST files with Global sequence numbers [reland]	8 years ago
meta_blocks.h	New Statistics to track Compression/Decompression (#1197)	8 years ago
mock_table.cc	DeleteRange flush support	8 years ago
mock_table.h	Add SeekForPrev() to Iterator	8 years ago
persistent_cache_helper.cc	Added PersistentCache abstraction	9 years ago
persistent_cache_helper.h	Added PersistentCache abstraction	9 years ago
plain_table_builder.cc	Compaction Support for Range Deletion	8 years ago
plain_table_builder.h	Embed column family name in SST file	9 years ago
plain_table_factory.cc	store prefix_extractor_name in table	8 years ago
plain_table_factory.h	Only cache level 0 indexes and filter when opening table reader	8 years ago
plain_table_index.cc	Updated all copyright headers to the new format.	9 years ago
plain_table_index.h	Remove ImmutableCFOptions from public API	8 years ago
plain_table_key_coding.cc	Updated all copyright headers to the new format.	9 years ago
plain_table_key_coding.h	Updated all copyright headers to the new format.	9 years ago
plain_table_reader.cc	Add SeekForPrev() to Iterator	8 years ago
plain_table_reader.h	Skip bottom-level filter block caching when hit-optimized	9 years ago
scoped_arena_iterator.h	Compaction Support for Range Deletion	8 years ago
sst_file_writer.cc	Fix SstFileWriter destructor	8 years ago
sst_file_writer_collectors.h	Support SST files with Global sequence numbers [reland]	8 years ago
table_builder.h	Add TableBuilderOptions::level and relevant changes (#1335)	8 years ago
table_properties.cc	Insert range deletion meta-block into block cache	8 years ago
table_properties_internal.h	TableBuilder / TableReader support for range deletion	8 years ago
table_reader.h	TableBuilder / TableReader support for range deletion	8 years ago
table_reader_bench.cc	DeleteRange Get support	8 years ago
table_test.cc	Insert range deletion meta-block into block cache	8 years ago
two_level_iterator.cc	Add SeekForPrev() to Iterator	8 years ago
two_level_iterator.h	Updated all copyright headers to the new format.	9 years ago