fork of https://github.com/oxigraph/rocksdb and https://github.com/facebook/rocksdb for nextgraph and oxigraph

You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Xinyu Zeng 8b74cea7fe Reduce comparator objects init cost in BlockIter (#9611) ... Summary: This PR solves the problem discussed in https://github.com/facebook/rocksdb/issues/7149. By storing the pointer of InternalKeyComparator as icmp_ in BlockIter, the object size remains the same. And for each call to CompareCurrentKey, there is no need to create Comparator objects. One can use icmp_ directly or use the "user_comparator" from the icmp_. Pull Request resolved: https://github.com/facebook/rocksdb/pull/9611 Test Plan: with https://github.com/facebook/rocksdb/issues/9903, ``` $ TEST_TMPDIR=/dev/shm python3.6 ../benchmark/tools/compare.py benchmarks ./db_basic_bench ../rocksdb-pr9611/db_basic_bench --benchmark_filter=DBGet/comp_style:0/max_data:134217728/per_key_size:256/enable_statistics:0/negative_query:0/enable_filter:0/mmap:1/iterations:262144/threads:1 --benchmark_repetitions=50 ... Comparing ./db_basic_bench to ../rocksdb-pr9611/db_basic_bench Benchmark Time CPU Time Old Time New CPU Old CPU New ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- ... DBGet/comp_style:0/max_data:134217728/per_key_size:256/enable_statistics:0/negative_query:0/enable_filter:0/mmap:1/iterations:262144/threads:1_pvalue 0.0001 0.0001 U Test, Repetitions: 50 vs 50 DBGet/comp_style:0/max_data:134217728/per_key_size:256/enable_statistics:0/negative_query:0/enable_filter:0/mmap:1/iterations:262144/threads:1_mean -0.0483 -0.0483 3924 3734 3924 3734 DBGet/comp_style:0/max_data:134217728/per_key_size:256/enable_statistics:0/negative_query:0/enable_filter:0/mmap:1/iterations:262144/threads:1_median -0.0713 -0.0713 3971 3687 3970 3687 DBGet/comp_style:0/max_data:134217728/per_key_size:256/enable_statistics:0/negative_query:0/enable_filter:0/mmap:1/iterations:262144/threads:1_stddev -0.0342 -0.0344 225 217 225 217 DBGet/comp_style:0/max_data:134217728/per_key_size:256/enable_statistics:0/negative_query:0/enable_filter:0/mmap:1/iterations:262144/threads:1_cv +0.0148 +0.0146 0 0 0 0 OVERALL_GEOMEAN -0.0483 -0.0483 0 0 0 0 ``` Reviewed By: akankshamahajan15 Differential Revision: D35882037 Pulled By: ajkr fbshipit-source-id: 9e5337bbad8f1239dff7aa9f6549020d599bfcdf		3 years ago
..
adaptive	More refactoring ahead of footer & meta changes (#9240)	3 years ago
block_based	Reduce comparator objects init cost in BlockIter (#9611)	3 years ago
cuckoo	Add rate limiter priority to ReadOptions (#9424)	3 years ago
plain	Meta-internal folly integration with F14FastMap (#9546)	3 years ago
block_fetcher.cc	Fix segfault in FilePrefetchBuffer with async_io enabled (#9777)	3 years ago
block_fetcher.h	More refactoring ahead of footer & meta changes (#9240)	3 years ago
block_fetcher_test.cc	Make MemoryAllocator into a Customizable class (#8980)	3 years ago
cleanable_test.cc	Eliminate unnecessary (slow) block cache Ref()ing in MultiGet (#9899)	3 years ago
format.cc	Add rate limiter priority to ReadOptions (#9424)	3 years ago
format.h	Optimize & clean up footer code (#9280)	3 years ago
get_context.cc	Support readahead during compaction for blob files (#9187)	3 years ago
get_context.h	Cleanup includes in dbformat.h (#8930)	3 years ago
internal_iterator.h	Reuse internal auto readhead_size at each Level (expect L0) for Iterations (#9056)	3 years ago
iter_heap.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	5 years ago
iterator.cc	Eliminate unnecessary (slow) block cache Ref()ing in MultiGet (#9899)	3 years ago
iterator_wrapper.h	Reuse internal auto readhead_size at each Level (expect L0) for Iterations (#9056)	3 years ago
merger_test.cc	Cleanup multiple implementations of VectorIterator (#8901)	3 years ago
merging_iterator.cc	MergingIterator: rearrange fields to reduce paddings (#9024)	3 years ago
merging_iterator.h	Cleanup includes in dbformat.h (#8930)	3 years ago
meta_blocks.cc	Tests for filter compatibility (#9773)	3 years ago
meta_blocks.h	Tests for filter compatibility (#9773)	3 years ago
mock_table.cc	Add rate limiter priority to ReadOptions (#9424)	3 years ago
mock_table.h	Fix some minor issues in the Customizable infrastructure (#8566)	3 years ago
multiget_context.h	Eliminate unnecessary (slow) block cache Ref()ing in MultiGet (#9899)	3 years ago
persistent_cache_helper.cc	New stable, fixed-length cache keys (#9126)	3 years ago
persistent_cache_helper.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	5 years ago
persistent_cache_options.h	New stable, fixed-length cache keys (#9126)	3 years ago
scoped_arena_iterator.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	5 years ago
sst_file_dumper.cc	New backup meta schema, with file temperatures (#9660)	3 years ago
sst_file_dumper.h	New backup meta schema, with file temperatures (#9660)	3 years ago
sst_file_reader.cc	Fast path for detecting unchanged prefix_extractor (#9407)	3 years ago
sst_file_reader_test.cc	Use the comparator from the sst file table properties in sst_dump_tool (#9491)	3 years ago
sst_file_writer.cc	`compression_per_level` should be used for flush and changeable (#9658)	3 years ago
sst_file_writer_collectors.h	Cleanup includes in dbformat.h (#8930)	3 years ago
table_builder.h	Fast path for detecting unchanged prefix_extractor (#9407)	3 years ago
table_factory.cc	Restore Regex support for ObjectLibrary::Register, rename new APIs to allow old one to be deprecated in the future (#9362)	3 years ago
table_properties.cc	Fix a bug of TEST_SetRandomTableProperties due to non-zero padding between fields in TableProperties struct (#9812)	3 years ago
table_properties_internal.h	Improve / clean up meta block code & integrity (#9163)	3 years ago
table_reader.h	dedup ReadOptions in iterator hierarchy (#7210)	4 years ago
table_reader_bench.cc	Fast path for detecting unchanged prefix_extractor (#9407)	3 years ago
table_reader_caller.h	Fix and detect headers with missing dependencies (#8893)	3 years ago
table_test.cc	Remove BlockBasedTableOptions.hash_index_allow_collision (#9454)	3 years ago
two_level_iterator.cc	Clarify caching behavior for index and filter partitions (#9068)	3 years ago
two_level_iterator.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	5 years ago
unique_id.cc	Experimental support for SST unique IDs (#8990)	3 years ago
unique_id_impl.h	Experimental support for SST unique IDs (#8990)	3 years ago