fork of https://github.com/oxigraph/rocksdb and https://github.com/facebook/rocksdb for nextgraph and oxigraph

You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Yanqin Jin c93ba7db5d Revise LockWAL/UnlockWAL implementation (#11020) ... Summary: RocksDB has two public APIs: `DB::LockWAL()`/`DB::UnlockWAL()`. The current implementation acquires and releases the internal `DBImpl::log_write_mutex_`. According to the comment on `DBImpl::log_write_mutex_`: https://github.com/facebook/rocksdb/blob/7.8.fb/db/db_impl/db_impl.h#L2287:L2288 > Note: to avoid dealock, if needed to acquire both log_write_mutex_ and mutex_, the order should be first mutex_ and then log_write_mutex_. This puts limitations on how applications can use the `LockWAL()` API. After `LockWAL()` returns ok, then application should not perform any operation that acquires `mutex_`. Currently, the use case of `LockWAL()` is MyRocks implementing the MySQL storage engine handlerton `lock_hton_log` interface. The operation that MyRocks performs after `LockWAL()` is `GetSortedWalFiless()` which not only acquires mutex_, but also `log_write_mutex_`. There are two issues: 1. Applications using these two APIs may hang if one thread calls `GetSortedWalFiles()` after calling `LockWAL()` because log_write_mutex is not recursive. 2. Two threads may dead lock due to lock order inversion. To fix these issues, we can modify the implementation of LockWAL so that it does not keep `log_write_mutex_` held until UnlockWAL. To achieve the goal of locking the WAL, we can instead manually inject a write stall so that all future writes will be stopped. Pull Request resolved: https://github.com/facebook/rocksdb/pull/11020 Test Plan: make check Reviewed By: ajkr Differential Revision: D41785203 Pulled By: riversand963 fbshipit-source-id: 5ccb7a9c6eb9a2c3fa80fd2c399cc2568b8f89ce		2 years ago
..
lock	Pass `const LockInfo&` to AcquireLocked() and AcquireWithTimeout (#10874)	2 years ago
optimistic_transaction.cc	Add further tests to ASSERT_STATUS_CHECKED (2) (#7698)	4 years ago
optimistic_transaction.h	Run clang-format on utilities/transactions (#10871)	2 years ago
optimistic_transaction_db_impl.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	5 years ago
optimistic_transaction_db_impl.h	Run clang-format on utilities/transactions (#10871)	2 years ago
optimistic_transaction_test.cc	Run clang-format on utilities/transactions (#10871)	2 years ago
pessimistic_transaction.cc	Reset pessimistic transaction's read/commit timestamps during Initialize() (#10677)	2 years ago
pessimistic_transaction.h	Snapshots with user-specified timestamps (#9879)	2 years ago
pessimistic_transaction_db.cc	Correctly implement Create-/DropColumnFamilies for PessimisticTransactionDB (#10332)	2 years ago
pessimistic_transaction_db.h	Correctly implement Create-/DropColumnFamilies for PessimisticTransactionDB (#10332)	2 years ago
snapshot_checker.cc	Use STATIC_AVOID_DESTRUCTION for static objects with non-trivial destructors (#9958)	3 years ago
timestamped_snapshot_test.cc	Print stack traces on frozen tests in CI (#10828)	2 years ago
transaction_base.cc	Run clang-format on utilities/transactions (#10871)	2 years ago
transaction_base.h	Run clang-format on utilities/transactions (#10871)	2 years ago
transaction_db_mutex_impl.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	5 years ago
transaction_db_mutex_impl.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	5 years ago
transaction_test.cc	Revise LockWAL/UnlockWAL implementation (#11020)	2 years ago
transaction_test.h	Replace member variable lambda with methods (#10924)	2 years ago
transaction_util.cc	Remove own ToString() (#9955)	3 years ago
transaction_util.h	Update TransactionUtil::CheckKeyForConflict to also use timestamps (#9162)	3 years ago
write_committed_transaction_ts_test.cc	Basic Support for Merge with user-defined timestamp (#10819)	2 years ago
write_prepared_transaction_test.cc	Replace member variable lambda with methods (#10924)	2 years ago
write_prepared_txn.cc	Run clang-format on utilities/transactions (#10871)	2 years ago
write_prepared_txn.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	5 years ago
write_prepared_txn_db.cc	Run clang-format on utilities/transactions (#10871)	2 years ago
write_prepared_txn_db.h	Remove own ToString() (#9955)	3 years ago
write_unprepared_transaction_test.cc	Run clang-format on utilities/transactions (#10871)	2 years ago
write_unprepared_txn.cc	Add WriteOptions::protection_bytes_per_key (#10037)	2 years ago
write_unprepared_txn.h	Replace tracked_keys with a new LockTracker interface in TransactionDB (#7013)	4 years ago
write_unprepared_txn_db.cc	Run clang-format on utilities/transactions (#10871)	2 years ago
write_unprepared_txn_db.h	WriteUnPrepared: Pass in correct subbatch count during rollback (#6463)	5 years ago