fork of https://github.com/oxigraph/rocksdb and https://github.com/facebook/rocksdb for nextgraph and oxigraph

You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Hui Xiao f79b3d19a7 Inject spurious wakeup and sleep before acquiring db mutex to expose race condition (#10291) ... Summary: **Context/Summary:** Previous experience with bugs and flaky tests taught us there exist features in RocksDB vulnerable to race condition caused by acquiring db mutex at a particular timing. This PR aggressively exposes those vulnerable features by injecting spurious wakeup and sleep to cause acquiring db mutex at various timing in order to expose such race condition **Testing:** - `COERCE_CONTEXT_SWITCH=1 make -j56 check / make -j56 db_stress` should reveal - flaky tests caused by db mutex related race condition - Reverted https://github.com/facebook/rocksdb/pull/9528 - A/B testing on `COMPILE_WITH_TSAN=1 make -j56 listener_test` w/ and w/o `COERCE_CONTEXT_SWITCH=1` followed by `./listener_test --gtest_filter=EventListenerTest.MultiCF --gtest_repeat=10` - `COERCE_CONTEXT_SWITCH=1` can cause expected test failure (i.e, expose target TSAN data race error) within 10 run while the other couldn't. - This proves our injection can expose flaky tests caused by db mutex related race condition faster. - known or new race-condition-type of internal bug by continuously running this PR - Performance - High ops-threads time: COERCE_CONTEXT_SWITCH=1 regressed by 4 times slower (2:01.16 vs 0:22.10 elapsed ). This PR will be run as a separate CI job so this regression won't affect any existing job. ``` TEST_TMPDIR=$db /usr/bin/time ./db_stress \ --ops_per_thread=100000 --expected_values_dir=$exp --clear_column_family_one_in=0 \ --write_buffer_size=524288 —target_file_size_base=524288 —ingest_external_file_one_in=100 —compact_files_one_in=1000 —compact_range_one_in=1000 ``` - Start-up time: COERCE_CONTEXT_SWITCH=1 didn't regress by 25% (0:01.51 vs 0:01.29 elapsed) ``` TEST_TMPDIR=$db ./db_stress -ops_per_thread=100000000 -expected_values_dir=$exp --clear_column_family_one_in=0 & sleep 120; pkill -9 db_stress TEST_TMPDIR=$db /usr/bin/time ./db_stress \ --ops_per_thread=1 -reopen=0 --expected_values_dir=$exp --clear_column_family_one_in=0 --destroy_db_initially=0 ``` Pull Request resolved: https://github.com/facebook/rocksdb/pull/10291 Reviewed By: ajkr Differential Revision: D39231182 Pulled By: hx235 fbshipit-source-id: 7ab6695430460e0826727fd8c66679b32b3e44b6		2 years ago
..
file_read_sample.h	…
histogram.cc	Fix possible NaN StandardDeviation in Histogram (#10586)	2 years ago
histogram.h	Fix possible NaN StandardDeviation in Histogram (#10586)	2 years ago
histogram_test.cc	Fix possible NaN StandardDeviation in Histogram (#10586)	2 years ago
histogram_windowing.cc	…
histogram_windowing.h	…
in_memory_stats_history.cc	…
in_memory_stats_history.h	…
instrumented_mutex.cc	Inject spurious wakeup and sleep before acquiring db mutex to expose race condition (#10291)	2 years ago
instrumented_mutex.h	Inject spurious wakeup and sleep before acquiring db mutex to expose race condition (#10291)	2 years ago
iostats_context.cc	Remove ROCKSDB_SUPPORT_THREAD_LOCAL define because it's a part of C++11 (#10015)	3 years ago
iostats_context_imp.h	Fix build error with NIOSTATS_CONTEXT (#10506)	2 years ago
iostats_context_test.cc	…
perf_context.cc	Add PerfContext counters for CompressedSecondaryCache (#10650)	2 years ago
perf_context_imp.h	Remove ROCKSDB_SUPPORT_THREAD_LOCAL define because it's a part of C++11 (#10015)	3 years ago
perf_level.cc	Remove ROCKSDB_SUPPORT_THREAD_LOCAL define because it's a part of C++11 (#10015)	3 years ago
perf_level_imp.h	Remove ROCKSDB_SUPPORT_THREAD_LOCAL define because it's a part of C++11 (#10015)	3 years ago
perf_step_timer.h	make PerfStepTimer struct smaller by reordering members (#7931)	4 years ago
persistent_stats_history.cc	Use std::numeric_limits<> (#9954)	3 years ago
persistent_stats_history.h	…
statistics.cc	Update statistics for async scan readaheads (#10585)	2 years ago
statistics.h	Add support for building on s390x platform (#8962)	3 years ago
statistics_test.cc	Added a default Name method to Statistics (#8918)	3 years ago
stats_history_test.cc	Fix periodic_task unable to re-register the same task type (#10379)	2 years ago
thread_status_impl.cc	…
thread_status_updater.cc	Remove ROCKSDB_SUPPORT_THREAD_LOCAL define because it's a part of C++11 (#10015)	3 years ago
thread_status_updater.h	Remove ROCKSDB_SUPPORT_THREAD_LOCAL define because it's a part of C++11 (#10015)	3 years ago
thread_status_updater_debug.cc	…
thread_status_util.cc	Remove ROCKSDB_SUPPORT_THREAD_LOCAL define because it's a part of C++11 (#10015)	3 years ago
thread_status_util.h	Remove ROCKSDB_SUPPORT_THREAD_LOCAL define because it's a part of C++11 (#10015)	3 years ago
thread_status_util_debug.cc	…