fork of https://github.com/oxigraph/rocksdb and https://github.com/facebook/rocksdb for nextgraph and oxigraph

You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Peter Dillinger f8c685c4fc Check for and disallow shared key space in block caches (#9172) ... Summary: We have three layers of block cache that often use the same key but map to different physical data: * BlockBasedTableOptions::block_cache * BlockBasedTableOptions::block_cache_compressed * BlockBasedTableOptions::persistent_cache If any two of these happen to share an underlying implementation and key space (insertion into one shows up in another), then memory safety is broken. The simplest case is block_cache == block_cache_compressed. (Credit mrambacher for asking about this case in a review.) With this change, we explicitly check for overlap and preemptively and safely fail with a Status code. Pull Request resolved: https://github.com/facebook/rocksdb/pull/9172 Test Plan: test added. Crashes without new check Reviewed By: anand1976 Differential Revision: D32465659 Pulled By: pdillinger fbshipit-source-id: 3876b45b6dce6167e5a7a642725ddc86b96f8e40		3 years ago
..
binary_search_index_reader.cc	Separate internal and user key comparators in `BlockIter` (#6944)	4 years ago
binary_search_index_reader.h	Extend Get/MultiGet deadline support to table open (#6982)	4 years ago
block.cc	Support timestamps in SstFileWriter (#8899)	3 years ago
block.h	Cleanup includes in dbformat.h (#8930)	3 years ago
block_based_filter_block.cc	Deallocate payload of BlockBasedTableBuilder::Rep::FilterBlockBuilder earlier for Full/PartitionedFilter (#9070)	3 years ago
block_based_filter_block.h	Deallocate payload of BlockBasedTableBuilder::Rep::FilterBlockBuilder earlier for Full/PartitionedFilter (#9070)	3 years ago
block_based_filter_block_test.cc	Add table properties for number of entries added to filters (#8323)	4 years ago
block_based_table_builder.cc	Minor improvement to CacheReservationManager/WriteBufferManager/CompressionDictBuilding (#9139)	3 years ago
block_based_table_builder.h	Some checksum code refactoring (#9113)	3 years ago
block_based_table_factory.cc	Check for and disallow shared key space in block caches (#9172)	3 years ago
block_based_table_factory.h	Cleanup includes in dbformat.h (#8930)	3 years ago
block_based_table_iterator.cc	Reuse internal auto readhead_size at each Level (expect L0) for Iterations (#9056)	3 years ago
block_based_table_iterator.h	Reuse internal auto readhead_size at each Level (expect L0) for Iterations (#9056)	3 years ago
block_based_table_reader.cc	Reuse internal auto readhead_size at each Level (expect L0) for Iterations (#9056)	3 years ago
block_based_table_reader.h	Add lowest_used_cache_tier to ImmutableDBOptions to enable or disable Secondary Cache (#9050)	3 years ago
block_based_table_reader_impl.h	Parallelize secondary cache lookup in MultiGet (#8405)	3 years ago
block_based_table_reader_test.cc	Cleanup includes in dbformat.h (#8930)	3 years ago
block_builder.cc	Improve data block construction performance (#9040)	3 years ago
block_builder.h	Improve data block construction performance (#9040)	3 years ago
block_like_traits.h	fix lru caching test and fix reference binding to null pointer (#8326)	4 years ago
block_prefetcher.cc	Reuse internal auto readhead_size at each Level (expect L0) for Iterations (#9056)	3 years ago
block_prefetcher.h	Reuse internal auto readhead_size at each Level (expect L0) for Iterations (#9056)	3 years ago
block_prefix_index.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	5 years ago
block_prefix_index.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	5 years ago
block_test.cc	More Makefile Cleanup (#7097)	4 years ago
block_type.h	Fix and detect headers with missing dependencies (#8893)	3 years ago
cachable_entry.h	Parallelize secondary cache lookup in MultiGet (#8405)	3 years ago
data_block_footer.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	5 years ago
data_block_footer.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	5 years ago
data_block_hash_index.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	5 years ago
data_block_hash_index.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	5 years ago
data_block_hash_index_test.cc	Make it possible to apply only a subrange of table property collectors (#8298)	4 years ago
filter_block.h	Deallocate payload of BlockBasedTableBuilder::Rep::FilterBlockBuilder earlier for Full/PartitionedFilter (#9070)	3 years ago
filter_block_reader_common.cc	Parallelize secondary cache lookup in MultiGet (#8405)	3 years ago
filter_block_reader_common.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	5 years ago
filter_policy.cc	Cleanup includes in dbformat.h (#8930)	3 years ago
filter_policy_internal.h	Add Bloom/Ribbon hybrid API support (#8679)	3 years ago
flush_block_policy.cc	Make FlushBlockPolicyFactory into a Customizable class (#8432)	3 years ago
flush_block_policy.h	Make FlushBlockPolicyFactory into a Customizable class (#8432)	3 years ago
full_filter_block.cc	Deallocate payload of BlockBasedTableBuilder::Rep::FilterBlockBuilder earlier for Full/PartitionedFilter (#9070)	3 years ago
full_filter_block.h	Deallocate payload of BlockBasedTableBuilder::Rep::FilterBlockBuilder earlier for Full/PartitionedFilter (#9070)	3 years ago
full_filter_block_test.cc	Add table properties for number of entries added to filters (#8323)	4 years ago
hash_index_reader.cc	Make ImmutableOptions struct that inherits from ImmutableCFOptions and ImmutableDBOptions (#8262)	4 years ago
hash_index_reader.h	Extend Get/MultiGet deadline support to table open (#6982)	4 years ago
index_builder.cc	Add (& fix) some simple source code checks (#8821)	3 years ago
index_builder.h	Make db_basic_test pass assert status checked (#7452)	4 years ago
index_reader_common.cc	Parallelize secondary cache lookup in MultiGet (#8405)	3 years ago
index_reader_common.h	Divide block_based_table_reader.cc (#6527)	5 years ago
mock_block_based_table.h	Make ImmutableOptions struct that inherits from ImmutableCFOptions and ImmutableDBOptions (#8262)	4 years ago
parsed_full_filter_block.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	5 years ago
parsed_full_filter_block.h	Use new Insert and Lookup APIs in table reader to support secondary cache (#8315)	4 years ago
partitioned_filter_block.cc	Deallocate payload of BlockBasedTableBuilder::Rep::FilterBlockBuilder earlier for Full/PartitionedFilter (#9070)	3 years ago
partitioned_filter_block.h	Deallocate payload of BlockBasedTableBuilder::Rep::FilterBlockBuilder earlier for Full/PartitionedFilter (#9070)	3 years ago
partitioned_filter_block_test.cc	Deallocate payload of BlockBasedTableBuilder::Rep::FilterBlockBuilder earlier for Full/PartitionedFilter (#9070)	3 years ago
partitioned_index_iterator.cc	Reuse internal auto readhead_size at each Level (expect L0) for Iterations (#9056)	3 years ago
partitioned_index_iterator.h	Reuse internal auto readhead_size at each Level (expect L0) for Iterations (#9056)	3 years ago
partitioned_index_reader.cc	Reuse internal auto readhead_size at each Level (expect L0) for Iterations (#9056)	3 years ago
partitioned_index_reader.h	Clarify caching behavior for index and filter partitions (#9068)	3 years ago
reader_common.cc	Some checksum code refactoring (#9113)	3 years ago
reader_common.h	Bring the Configurable options together (#5753)	4 years ago
uncompression_dict_reader.cc	Cleanup includes in dbformat.h (#8930)	3 years ago
uncompression_dict_reader.h	Extend Get/MultiGet deadline support to table open (#6982)	4 years ago