From a4587f62c17f3ed9762ee2dc4dae29cb48316c5c Mon Sep 17 00:00:00 2001 From: Griffin Smith Date: Wed, 23 Aug 2017 15:55:18 -0400 Subject: [PATCH] Remove `set_disable_data_sync` This is removed from rocksdb core as of facebook/rocksdb@eb912a9, and having the reference in the ffi causes loading the shared library to break. --- librocksdb-sys/src/lib.rs | 2 -- src/db_options.rs | 4 ---- src/lib.rs | 1 - 3 files changed, 7 deletions(-) diff --git a/librocksdb-sys/src/lib.rs b/librocksdb-sys/src/lib.rs index 8e9b631..5c3999a 100644 --- a/librocksdb-sys/src/lib.rs +++ b/librocksdb-sys/src/lib.rs @@ -671,8 +671,6 @@ extern "C" { pub fn rocksdb_options_set_max_sequential_skip_in_iterations(opt: *mut rocksdb_options_t, v: uint64_t); - pub fn rocksdb_options_set_disable_data_sync(opt: *mut rocksdb_options_t, v: c_int); - pub fn rocksdb_options_set_disable_auto_compactions(opt: *mut rocksdb_options_t, v: c_int); pub fn rocksdb_options_set_delete_obsolete_files_period_micros(opt: *mut rocksdb_options_t, diff --git a/src/db_options.rs b/src/db_options.rs index eea8e97..21063f3 100644 --- a/src/db_options.rs +++ b/src/db_options.rs @@ -369,10 +369,6 @@ impl Options { allow as c_uchar) } } - pub fn set_disable_data_sync(&mut self, disable: bool) { - unsafe { ffi::rocksdb_options_set_disable_data_sync(self.inner, disable as c_int) } - } - /// Enable direct I/O mode for reading /// they may or may not improve performance depending on the use case /// diff --git a/src/lib.rs b/src/lib.rs index ba26334..56778d7 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -126,7 +126,6 @@ pub struct BlockBasedOptions { /// opts.set_max_open_files(10000); /// opts.set_use_fsync(false); /// opts.set_bytes_per_sync(8388608); -/// opts.set_disable_data_sync(false); /// opts.optimize_for_point_lookup(1024); /// opts.set_table_cache_num_shard_bits(6); /// opts.set_max_write_buffer_number(32);