Consider remote sending a frame after sending a close frame a protocol error.

The websocket RFC explicitly states this is not allowed.
pull/74/head
Naja Melan 5 years ago
parent 2918eec1b3
commit 1ee3f342aa
  1. 11
      src/protocol/mod.rs

@ -337,6 +337,9 @@ impl WebSocketContext {
Stream: Read + Write,
{
if let Some(mut frame) = self.frame.read_frame(stream, self.config.max_frame_size)? {
if !self.state.can_read() {
return Err(Error::Protocol("Remote sent frame after having sent a Close Frame".into()));
}
// MUST be 0 unless an extension is negotiated that defines meanings
// for non-zero values. If a nonzero value is received and none of
// the negotiated extensions defines the meaning of such a nonzero
@ -388,9 +391,6 @@ impl WebSocketContext {
OpCtl::Reserved(i) => Err(Error::Protocol(
format!("Unknown control frame type {}", i).into(),
)),
OpCtl::Ping | OpCtl::Pong if !self.state.can_read() => {
Ok(None)
}
OpCtl::Ping => {
let data = frame.into_data();
// No ping processing after we sent a close frame.
@ -403,11 +403,6 @@ impl WebSocketContext {
}
}
OpCode::Data(_) if !self.state.can_read() => {
// No data processing while closing.
Ok(None)
}
OpCode::Data(data) => {
let fin = frame.header().is_final;
match data {

Loading…
Cancel
Save