diff --git a/src/error.rs b/src/error.rs index 3e15c7c..c830024 100644 --- a/src/error.rs +++ b/src/error.rs @@ -65,7 +65,7 @@ pub enum Error { /// HTTP error. #[error("HTTP error: {}", .0.status())] #[cfg(feature = "handshake")] - Http(Response>), + Http(Response>>), /// HTTP format error. #[error("HTTP format error: {0}")] #[cfg(feature = "handshake")] diff --git a/src/handshake/client.rs b/src/handshake/client.rs index 0700fa2..aaeabb7 100644 --- a/src/handshake/client.rs +++ b/src/handshake/client.rs @@ -26,7 +26,7 @@ use crate::{ pub type Request = HttpRequest<()>; /// Client response type. -pub type Response = HttpResponse<()>; +pub type Response = HttpResponse>>; /// Client handshake role. #[derive(Debug)] @@ -83,7 +83,15 @@ impl HandshakeRole for ClientHandshake { ProcessingResult::Continue(HandshakeMachine::start_read(stream)) } StageResult::DoneReading { stream, result, tail } => { - let result = self.verify_data.verify_response(result)?; + let result = match self.verify_data.verify_response(result) { + Ok(r) => r, + Err(Error::Http(mut e)) => { + *e.body_mut() = Some(tail); + return Err(Error::Http(e)) + }, + Err(e) => return Err(e), + }; + debug!("Client handshake done."); let websocket = WebSocket::from_partially_read(stream, tail, Role::Client, self.config); @@ -182,7 +190,7 @@ impl VerifyData { // 1. If the status code received from the server is not 101, the // client handles the response per HTTP [RFC2616] procedures. (RFC 6455) if response.status() != StatusCode::SWITCHING_PROTOCOLS { - return Err(Error::Http(response.map(|_| None))); + return Err(Error::Http(response)); } let headers = response.headers(); @@ -255,7 +263,7 @@ impl<'h, 'b: 'h> FromHttparse> for Response { let headers = HeaderMap::from_httparse(raw.headers)?; - let mut response = Response::new(()); + let mut response = Response::new(None); *response.status_mut() = StatusCode::from_u16(raw.code.expect("Bug: no HTTP status code"))?; *response.headers_mut() = headers; // TODO: httparse only supports HTTP 0.9/1.0/1.1 but not HTTP 2.0 diff --git a/src/handshake/server.rs b/src/handshake/server.rs index 2f095ce..4cf1c5c 100644 --- a/src/handshake/server.rs +++ b/src/handshake/server.rs @@ -277,7 +277,10 @@ impl HandshakeRole for ServerHandshake { StageResult::DoneWriting(stream) => { if let Some(err) = self.error_response.take() { debug!("Server handshake failed."); - return Err(Error::Http(err)); + + let (parts, body) = err.into_parts(); + let body = body.map(|b| b.as_bytes().to_vec()); + return Err(Error::Http(http::Response::from_parts(parts, body))); } else { debug!("Server handshake done."); let websocket = WebSocket::from_raw_socket(stream, Role::Server, self.config);