From 556db990b5abb78360ead5854ba541bcc6c83274 Mon Sep 17 00:00:00 2001
From: Ran Benita <ran234@gmail.com>
Date: Tue, 10 Jul 2018 23:35:22 +0300
Subject: [PATCH] mask: take [u8; 4] by value

warning: this argument is passed by reference, but would be more efficient if passed by value
  --> src/protocol/frame/mask.rs:21:46
   |
21 | fn apply_mask_fallback(buf: &mut [u8], mask: &[u8; 4]) {
   |                                              ^^^^^^^^ help: consider passing by value instead: `[u8; 4]`
   |
   = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.212/index.html#trivially_copy_pass_by_ref
---
 src/protocol/frame/frame.rs |  2 +-
 src/protocol/frame/mask.rs  | 16 ++++++++--------
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/src/protocol/frame/frame.rs b/src/protocol/frame/frame.rs
index 4c9cc83..3016704 100644
--- a/src/protocol/frame/frame.rs
+++ b/src/protocol/frame/frame.rs
@@ -269,7 +269,7 @@ impl Frame {
     #[inline]
     pub(crate) fn apply_mask(&mut self) {
         if let Some(mask) = self.header.mask.take() {
-            apply_mask(&mut self.payload, &mask)
+            apply_mask(&mut self.payload, mask)
         }
     }
 
diff --git a/src/protocol/frame/mask.rs b/src/protocol/frame/mask.rs
index 055be08..88b1894 100644
--- a/src/protocol/frame/mask.rs
+++ b/src/protocol/frame/mask.rs
@@ -11,14 +11,14 @@ pub fn generate_mask() -> [u8; 4] {
 
 /// Mask/unmask a frame.
 #[inline]
-pub fn apply_mask(buf: &mut [u8], mask: &[u8; 4]) {
+pub fn apply_mask(buf: &mut [u8], mask: [u8; 4]) {
     apply_mask_fast32(buf, mask)
 }
 
 /// A safe unoptimized mask application.
 #[inline]
 #[allow(dead_code)]
-fn apply_mask_fallback(buf: &mut [u8], mask: &[u8; 4]) {
+fn apply_mask_fallback(buf: &mut [u8], mask: [u8; 4]) {
     for (i, byte) in buf.iter_mut().enumerate() {
         *byte ^= mask[i & 3];
     }
@@ -27,9 +27,9 @@ fn apply_mask_fallback(buf: &mut [u8], mask: &[u8; 4]) {
 /// Faster version of `apply_mask()` which operates on 4-byte blocks.
 #[inline]
 #[allow(dead_code)]
-fn apply_mask_fast32(buf: &mut [u8], mask: &[u8; 4]) {
+fn apply_mask_fast32(buf: &mut [u8], mask: [u8; 4]) {
     let mask_u32: u32 = unsafe {
-        read_unaligned(mask.as_ptr() as *const u32)
+        read_unaligned((&mask).as_ptr() as *const u32)
     };
 
     let mut ptr = buf.as_mut_ptr();
@@ -101,10 +101,10 @@ mod tests {
         // Check masking with proper alignment.
         {
             let mut masked = unmasked.clone();
-            apply_mask_fallback(&mut masked, &mask);
+            apply_mask_fallback(&mut masked, mask);
 
             let mut masked_fast = unmasked.clone();
-            apply_mask_fast32(&mut masked_fast, &mask);
+            apply_mask_fast32(&mut masked_fast, mask);
 
             assert_eq!(masked, masked_fast);
         }
@@ -112,10 +112,10 @@ mod tests {
         // Check masking without alignment.
         {
             let mut masked = unmasked.clone();
-            apply_mask_fallback(&mut masked[1..], &mask);
+            apply_mask_fallback(&mut masked[1..], mask);
 
             let mut masked_fast = unmasked.clone();
-            apply_mask_fast32(&mut masked_fast[1..], &mask);
+            apply_mask_fast32(&mut masked_fast[1..], mask);
 
             assert_eq!(masked, masked_fast);
         }