From 1dac6ddea545eff3714c6bbe5f3b67716742c091 Mon Sep 17 00:00:00 2001 From: Michael Gattozzi Date: Mon, 16 Apr 2018 09:17:32 -0400 Subject: [PATCH 1/2] Add PR template to the repo We want to make sure people format their code as well as reference the issue that's going to be closed as well so we don't have to close the issue manually! This PR adds a template for PRs that includes these points as a checklist to ensure future contributors know what they need to do! --- .github/PULL_REQUEST_TEMPLATE.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .github/PULL_REQUEST_TEMPLATE.md diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 0000000..2eb51fe --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,5 @@ +Make sure these boxes are checked! + +- [ ] You have the latest version of `rustfmt` installed +- [ ] You ran `rustfmt` on the code base before submitting +- [ ] You reference which issue is being closed in the PR text From b7d8e582d4cedb0a86580faed2a50cc1db822b04 Mon Sep 17 00:00:00 2001 From: Michael Gattozzi Date: Tue, 17 Apr 2018 10:37:10 -0400 Subject: [PATCH 2/2] feat(emojify template) Make PR template 100% emoji MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ✨✨ This makes this PR 💯/💯 ✨✨ --- .github/PULL_REQUEST_TEMPLATE.md | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 2eb51fe..e07bd50 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,5 +1,12 @@ -Make sure these boxes are checked! +Make sure these boxes are checked! 📦✅ -- [ ] You have the latest version of `rustfmt` installed +- [ ] You have the latest version of `rustfmt` installed and have your + cloned directory set to nightly +```bash +$ rustup override set nightly +$ rustup component add rustfmt-preview --toolchain nightly +``` - [ ] You ran `rustfmt` on the code base before submitting - [ ] You reference which issue is being closed in the PR text + +✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨