35cabb658f
Merge pull request #487 from danwilhelm/login-issues
...
Login issues
6 years ago
5fafee7657
Merge pull request #485 from fitzgen/minor-docs-stuff
...
Minor docs stuff
6 years ago
2343e97e1e
login: Send arguments separately to npm
...
All arguments were passed to `arg` inside one string when building a
`Command`. However, using the `arg` function, "only one argument can be
passed per use." This caused all arguments accidentally to be appended
to the registry URL. For example: After a successful login with a
provided `--auth_type`, the success message incorrectly displayed:
"Logged in as asf on https://registry.npmjs.org/%20--auth_type=Basic ."
The space (%20 in hex) was caused by adding a fixed space before each
additional argument.
This commit pushes all arguments onto a `Vec<String>`. Then, the `args`
function adds the arguments separately to the command. This removes the
need to prepend spaces to each argument. Alternatively, `arg` could have
been used throughout to build the command argument-by-argument. However,
using `args` partitions the code more neatly into two distinct sections.
6 years ago
0147dae9fe
login: Fix empty input prompt
...
Issue #484 .
PR392 inadvertantly replaced the `login` interactive process spawner
with
`child::run`, which is hard-coded to buffer stdout/stderr. This caused
`login` to become essentially unusable; the user could no longer see
interactive input prompts or error messages displayed by `npm adduser`.
The code was not directly reverted because the previous version:
1. Returned Error instead of failure::Error. (Updated to use
`bail!`, which is consistent with `publish`.)
2. Displayed all stderr only upon exit, rather than interactively
displaying it. This led to repeated interactive prompts without
informing the user why. (Updated to use `status()` which inherits
stdin/stdout/stderr by default.)
3. Did not provide logging. (Now duplicates the logging in
`child::run`.)
6 years ago
20c488d559
docs: document that the `pkg` directory is gitignored by default
...
Fixes #473
6 years ago
ecbdf90adc
docs: delete trailing whitespace
6 years ago
212d7727dc
docs: use `wasm-pack build` instead of `wasm-pack init`
...
The latter has been deprecated for some time.
6 years ago
065a28f293
check whether correct target arg passed in
6 years ago
8af40029a9
Merge pull request #476 from mstallmo/refactor-license-copy
...
Refactor license copy to remove unwrap()
6 years ago
c99b93498c
Refactor: returns error instead of unwrapping path join
6 years ago
bcdbaab731
Refactor: returns proper error instead of unwrapping during license copy
6 years ago
9675464067
Merge pull request #415 from drager/refactor-binary-installation
...
refactor: Move binary installation to it's own crate
6 years ago
28f67e7a6e
Merge branch 'master' into refactor-binary-installation
6 years ago
9c01c389a7
Merge pull request #396 from huangjj27/fix-390
...
bugfix(command/build.rs): Cancel Escape
6 years ago
011cca9495
Merge pull request #444 from csmoe/prebuild
...
pre-build before wasm-pack publish
6 years ago
93384f572f
select build target
6 years ago
a2235e5af4
Merge branch 'master' into refactor-binary-installation
6 years ago
cab9e6a545
Merge pull request #454 from RReverser/add-rust-toolchain
...
Add rust-toolchain file set to nightly
6 years ago
99ccb75105
Delete rust-toolchain
6 years ago
0fdfacc2d8
Merge pull request #453 from RReverser/gitignore-pkg-by-default
...
Generate self-.gitignore as part of pkg folder
6 years ago
95268cdaf4
add target arg to publish
6 years ago
ddd93481c3
prebuild in interactive way
6 years ago
d5a7a7beb1
pre-build before wasm-pack publish
6 years ago
8ed6e3dfaf
Merge pull request #446 from drager/catch-types-in-cargo-toml
...
feat: Catch typos in Cargo.toml and warn about them
6 years ago
fa5e39b217
Merge pull request #411 from mstallmo/master
...
Copy license file(s) to out directory
6 years ago
aa4a22a90d
Merge pull request #467 from Siilwyn/patch-1
...
Fix link to manual setup instructions from getting started
6 years ago
2b30ca8e13
Fix link to manual setup instructions from getting started
6 years ago
b6eb9af729
Merge pull request #450 from srijs/update/zip-0.5
...
update zip to 0.5.0
7 years ago
87b4c5c7b1
Add rust-toolchain file set to nightly
...
This allows new contributors to avoid manually running `rustup override set nightly`.
7 years ago
d788b80583
Generate self-.gitignore as part of pkg folder
7 years ago
b92a3366eb
Rustfmt
7 years ago
30d9e2bd07
Fixing wasm-pack on non-rustup setups
7 years ago
b567fc0f88
update zip to 0.5.0
7 years ago
272ef97bef
Refactor: make `crate_license` a method of CrateData.
7 years ago
1c704b7b7c
Reword WTFPL and add punctuation to license not found message.
7 years ago
2d837f795c
Copy license file(s) to out directory
...
Check the Cagro.toml for a license and if one is found glob for LICENSE* files to copy to the out directory
7 years ago
c6894c46f7
bugfix(390): pass the ci
...
in the CI, there is no user. begining with "C:\" is just enough
7 years ago
9feb3a857c
check if the log missing things
7 years ago
06a949b9ed
Capital disk Url
7 years ago
837393b5fc
trim head
7 years ago
7fd731279b
print out wasm-log for check
7 years ago
06e38ec3e8
checkout if CI's log contain INFO messages
7 years ago
83de8d71d2
fix test for wasm-bindgen 0.2.21
7 years ago
2512199cb3
resolve conlicts and pass the test
7 years ago
6d3f1c2835
remove canonicalize and use display directly
7 years ago
b301015588
update: rebasing to master
...
fixes conflicts encountered when rebasing to master
fixes # 390
7 years ago
cf56fa10d6
bugfix(command/build): passing test case
...
this commit fixes #390 , #414 , and closes #408 for the test case
have to pass after a successful build.
7 years ago
054e1739ae
test(command/build): right test case
...
the test case would pass after solving #408
7 years ago
472890c063
test(command/build): add test for fix-390
7 years ago
6edb3732aa
update(command/build): lazily eval if canonicalizing failed
7 years ago
Nick Fitzgerald