Warning cleanup: if(rc = mdb_<func>()) & co

libraries/libmdb/mdb.c

@@ -1203,7 +1203,7 @@ mdb_search_page_root(MDB_db *bt, MDB_val *key,
 
 		if (modify) {
 			MDB_dhead *dh = ((MDB_dhead *)mp)-1;
-			if (rc = mdb_touch(bt->md_env->me_txn, mpp))
+			if ((rc = mdb_touch(bt->md_env->me_txn, mpp)) != 0)
 				return rc;
 			dh = ((MDB_dhead *)mpp->mp_page)-1;
 			dh->md_parent = mpp->mp_parent;

libraries/libmdb/mtest.c

@@ -47,7 +47,7 @@ int main(int argc,char * argv[])
 		rc = mdbenv_stat(env, &mst);
 
 		rc = mdb_cursor_open(db, NULL, &cursor);
-		while (rc = mdb_cursor_get(cursor, &key, &data, MDB_NEXT) == 0) {
+		while ((rc = mdb_cursor_get(cursor, &key, &data, MDB_NEXT)) == 0) {
 			printf("key: %p %.*s, data: %p %.*s\n",
 				key.mv_data,  (int) key.mv_size,  (char *) key.mv_data,
 				data.mv_data, (int) data.mv_size, (char *) data.mv_data);
@@ -74,7 +74,7 @@ int main(int argc,char * argv[])
 
 		rc = mdbenv_stat(env, &mst);
 		rc = mdb_cursor_open(db, NULL, &cursor);
-		while (rc = mdb_cursor_get(cursor, &key, &data, MDB_NEXT) == 0) {
+		while ((rc = mdb_cursor_get(cursor, &key, &data, MDB_NEXT)) == 0) {
 			printf("key: %.*s, data: %.*s\n",
 				(int) key.mv_size,  (char *) key.mv_data,
 				(int) data.mv_size, (char *) data.mv_data);