ITS#7992 Tighter utf8_to_utf16(), fix errcodes

The 0xFFFD check seems due to misleading MultiByteToWideChar() doc.
Bad UTF-8 gives 0xFFFD in the output string, not the return value.

libraries/liblmdb/mdb.c

@@ -10886,25 +10886,31 @@ mdb_mutex_failed(MDB_env *env, mdb_mutexref_t mutex, int rc)
 	return rc;
 }
 #endif	/* MDB_ROBUST_SUPPORTED */
-/** @} */
 
 #if defined(_WIN32)
-static int utf8_to_utf16(const char *src, int srcsize, wchar_t **dst, int *dstsize)
+static int ESECT
-{
+utf8_to_utf16(const char *src, int srcsize, wchar_t **dst, int *dstsize)
-	int need;
+{
-	wchar_t *result;
+	int rc, need = 0;
-	need = MultiByteToWideChar(CP_UTF8, 0, src, srcsize, NULL, 0);
+	wchar_t *result = NULL;
-	if (need == 0xFFFD)
+	for (;;) {					/* malloc result, then fill it in */
-		return EILSEQ;
+		need = MultiByteToWideChar(CP_UTF8, 0, src, srcsize, result, need);
-	if (need == 0)
+		if (!need) {
-		return EINVAL;
+			rc = ErrCode();
+			free(result);
+			return rc;
+		}
+		if (!result) {
 			result = malloc(sizeof(wchar_t) * need);
 			if (!result)
 				return ENOMEM;
-	MultiByteToWideChar(CP_UTF8, 0, src, srcsize, result, need);
+			continue;
+		}
 		if (dstsize)
 			*dstsize = need;
 		*dst = result;
-	return 0;
+		return MDB_SUCCESS;
+	}
 }
 #endif /* defined(_WIN32) */
+/** @} */