fix: return W3C standard JSON format for SPARQL ASK queries

ASK queries were returning raw JavaScript booleans (true/false) instead of
the W3C SPARQL 1.1 standard JSON format {"head": {}, "boolean": true/false}.

This fix uses QueryResultsSerializer to properly format ASK query results,
ensuring compatibility with standards-compliant SPARQL applications and
consistency with SELECT/CONSTRUCT query behavior.

The issue was in ng-verifier/src/request_processor.rs where
AppResponseV0::True/False were returned instead of a properly
serialized QueryResult.

Fixes: Non-standard ASK query responses
Reference: https://www.w3.org/TR/sparql11-results-json/

Cargo.toml

@@ -24,7 +24,7 @@ default-members = [ "nextgraph", "ngcli",  "ngd" ]
 [workspace.package]
 version = "0.1.1-alpha.2"
 edition = "2021"
-rust-version = "1.81.0"
+rust-version = "1.74.0"
 license = "MIT/Apache-2.0"
 authors = ["Niko PLP <niko@nextgraph.org>"]
 repository = "https://git.nextgraph.org/NextGraph/nextgraph-rs"

DEV.md

@@ -1,6 +1,6 @@
 # Contributors or compilation guide
 
--   [Install Rust](https://www.rust-lang.org/tools/install) minimum required MSRV 1.81.0
+-   [Install Rust](https://www.rust-lang.org/tools/install) minimum required MSRV 1.74.0
 -   [Install Nodejs](https://nodejs.org/en/download/)
 -   [Install LLVM](https://rust-lang.github.io/rust-bindgen/requirements.html)
 

README.md

@@ -64,7 +64,7 @@ Licensed under either of
 
 NextGraph received funding through the [NGI Assure Fund](https://nlnet.nl/assure) and the [NGI Zero Commons Fund](https://nlnet.nl/commonsfund/), both funds established by [NLnet](https://nlnet.nl/) Foundation with financial support from the European Commission's [Next Generation Internet](https://ngi.eu/) programme, under the aegis of DG Communications Networks, Content and Technology under grant agreements No 957073 and No 101092990, respectively.
 
-[rustc-image]: https://img.shields.io/badge/rustc-1.81+-blue.svg
+[rustc-image]: https://img.shields.io/badge/rustc-1.74+-blue.svg
 [license-image]: https://img.shields.io/badge/license-Apache2.0-blue.svg
 [license-link]: https://git.nextgraph.org/NextGraph/nextgraph-rs/raw/branch/master/LICENSE-APACHE2
 [license-image2]: https://img.shields.io/badge/license-MIT-blue.svg

nextgraph/README.md

@@ -76,7 +76,7 @@ additional terms or conditions.
 NextGraph received funding through the [NGI Assure Fund](https://nlnet.nl/assure) and the [NGI Zero Commons Fund](https://nlnet.nl/commonsfund/), both funds established by [NLnet](https://nlnet.nl/) Foundation with financial support from the European Commission's [Next Generation Internet](https://ngi.eu/) programme, under the aegis of DG Communications Networks, Content and Technology under grant agreements No 957073 and No 101092990, respectively.
 
 
-[rustc-image]: https://img.shields.io/badge/rustc-1.81+-blue.svg
+[rustc-image]: https://img.shields.io/badge/rustc-1.74+-blue.svg
 [license-image]: https://img.shields.io/badge/license-Apache2.0-blue.svg
 [license-link]: https://git.nextgraph.org/NextGraph/nextgraph-rs/raw/branch/master/LICENSE-APACHE2
 [license-image2]: https://img.shields.io/badge/license-MIT-blue.svg

nextgraph/src/local_broker.rs

@@ -13,7 +13,6 @@ use std::fs::{read, remove_file, write};
 use std::path::PathBuf;
 
 use async_once_cell::OnceCell;
-use async_std::prelude::FutureExt;
 use async_std::sync::{Arc, Condvar, Mutex, RwLock};
 use futures::channel::mpsc;
 use futures::{SinkExt, StreamExt};
@@ -572,6 +571,7 @@ impl fmt::Debug for LocalBroker {
 #[cfg_attr(not(target_arch = "wasm32"), async_trait::async_trait)]
 pub trait ILocalBroker: Send + Sync + EActor {
     async fn deliver(&mut self, event: Event, overlay: OverlayId, user: UserId);
+    async fn inbox(&mut self, user_id: UserId, msg: InboxMsg, from_queue: bool);
     async fn user_disconnected(&mut self, user_id: UserId);
 }
 
@@ -584,6 +584,11 @@ impl ILocalBroker for LocalBroker {
             session.verifier.deliver(event, overlay).await;
         }
     }
+    async fn inbox(&mut self, user_id: UserId, msg: InboxMsg, from_queue: bool) {
+        if let Some(session) = self.get_mut_session_for_user(&user_id) {
+            session.verifier.inbox(msg, from_queue).await;
+        }
+    }
     async fn user_disconnected(&mut self, user_id: UserId) {
         if let Some(session) = self.get_mut_session_for_user(&user_id) {
             session.verifier.connection_lost();
@@ -621,38 +626,20 @@ async fn pump(
             running = cvar.wait(running).await;
         }
 
+        let mut broker = match LOCAL_BROKER.get() {
+            None | Some(Err(_)) => return Err(Box::new(NgError::LocalBrokerNotInitialized)),
+            Some(Ok(broker)) => broker.write().await,
+        };
         match message {
             LocalBrokerMessage::Deliver {
                 event,
                 overlay,
                 user,
-            } => { 
-                let mut broker = match LOCAL_BROKER.get() {
-                    None | Some(Err(_)) => return Err(Box::new(NgError::LocalBrokerNotInitialized)),
-                    Some(Ok(broker)) => broker.write().await,
-                };
-                broker.deliver(event, overlay, user).await
-            },
+            } => broker.deliver(event, overlay, user).await,
             LocalBrokerMessage::Inbox {msg, user_id, from_queue} => {
-                async_std::task::spawn_local(async move {
-                    let mut broker = match LOCAL_BROKER.get() {
-                        None | Some(Err(_)) => return Err(Box::new(NgError::LocalBrokerNotInitialized)),
-                        Some(Ok(broker)) => broker.write().await,
-                    };
-                    if let Some(session) = broker.get_mut_session_for_user(&user_id) {
-                        session.verifier.inbox(&msg, from_queue).await;
-                    }
-                    Ok(())
-                }).await?;
-                
-            },
-            LocalBrokerMessage::Disconnected { user_id } => { 
-                let mut broker = match LOCAL_BROKER.get() {
-                    None | Some(Err(_)) => return Err(Box::new(NgError::LocalBrokerNotInitialized)),
-                    Some(Ok(broker)) => broker.write().await,
-                };
-                broker.user_disconnected(user_id).await
+                broker.inbox(user_id, msg, from_queue).await
             },
+            LocalBrokerMessage::Disconnected { user_id } => broker.user_disconnected(user_id).await,
         }
     }
 

ng-broker/README.md

@@ -49,7 +49,7 @@ additional terms or conditions.
 NextGraph received funding through the [NGI Assure Fund](https://nlnet.nl/assure) and the [NGI Zero Commons Fund](https://nlnet.nl/commonsfund/), both funds established by [NLnet](https://nlnet.nl/) Foundation with financial support from the European Commission's [Next Generation Internet](https://ngi.eu/) programme, under the aegis of DG Communications Networks, Content and Technology under grant agreements No 957073 and No 101092990, respectively.
 
 
-[rustc-image]: https://img.shields.io/badge/rustc-1.81+-blue.svg
+[rustc-image]: https://img.shields.io/badge/rustc71.74+-blue.svg
 [license-image]: https://img.shields.io/badge/license-Apache2.0-blue.svg
 [license-link]: https://git.nextgraph.org/NextGraph/nextgraph-rs/raw/branch/master/LICENSE-APACHE2
 [license-image2]: https://img.shields.io/badge/license-MIT-blue.svg

ng-client-ws/README.md

@@ -49,7 +49,7 @@ additional terms or conditions.
 NextGraph received funding through the [NGI Assure Fund](https://nlnet.nl/assure) and the [NGI Zero Commons Fund](https://nlnet.nl/commonsfund/), both funds established by [NLnet](https://nlnet.nl/) Foundation with financial support from the European Commission's [Next Generation Internet](https://ngi.eu/) programme, under the aegis of DG Communications Networks, Content and Technology under grant agreements No 957073 and No 101092990, respectively.
 
 
-[rustc-image]: https://img.shields.io/badge/rustc-1.81+-blue.svg
+[rustc-image]: https://img.shields.io/badge/rustc-1.74+-blue.svg
 [license-image]: https://img.shields.io/badge/license-Apache2.0-blue.svg
 [license-link]: https://git.nextgraph.org/NextGraph/nextgraph-rs/raw/branch/master/LICENSE-APACHE2
 [license-image2]: https://img.shields.io/badge/license-MIT-blue.svg

ng-net/README.md

@@ -49,7 +49,7 @@ additional terms or conditions.
 NextGraph received funding through the [NGI Assure Fund](https://nlnet.nl/assure) and the [NGI Zero Commons Fund](https://nlnet.nl/commonsfund/), both funds established by [NLnet](https://nlnet.nl/) Foundation with financial support from the European Commission's [Next Generation Internet](https://ngi.eu/) programme, under the aegis of DG Communications Networks, Content and Technology under grant agreements No 957073 and No 101092990, respectively.
 
 
-[rustc-image]: https://img.shields.io/badge/rustc-1.81+-blue.svg
+[rustc-image]: https://img.shields.io/badge/rustc-1.74+-blue.svg
 [license-image]: https://img.shields.io/badge/license-Apache2.0-blue.svg
 [license-link]: https://git.nextgraph.org/NextGraph/nextgraph-rs/raw/branch/master/LICENSE-APACHE2
 [license-image2]: https://img.shields.io/badge/license-MIT-blue.svg

ng-repo/README.md

@@ -49,7 +49,7 @@ additional terms or conditions.
 NextGraph received funding through the [NGI Assure Fund](https://nlnet.nl/assure) and the [NGI Zero Commons Fund](https://nlnet.nl/commonsfund/), both funds established by [NLnet](https://nlnet.nl/) Foundation with financial support from the European Commission's [Next Generation Internet](https://ngi.eu/) programme, under the aegis of DG Communications Networks, Content and Technology under grant agreements No 957073 and No 101092990, respectively.
 
 
-[rustc-image]: https://img.shields.io/badge/rustc-1.81+-blue.svg
+[rustc-image]: https://img.shields.io/badge/rustc-1.74+-blue.svg
 [license-image]: https://img.shields.io/badge/license-Apache2.0-blue.svg
 [license-link]: https://git.nextgraph.org/NextGraph/nextgraph-rs/raw/branch/master/LICENSE-APACHE2
 [license-image2]: https://img.shields.io/badge/license-MIT-blue.svg

ng-sdk-python/README.md

@@ -56,7 +56,7 @@ Licensed under either of
 
 NextGraph received funding through the [NGI Assure Fund](https://nlnet.nl/assure) and the [NGI Zero Commons Fund](https://nlnet.nl/commonsfund/), both funds established by [NLnet](https://nlnet.nl/) Foundation with financial support from the European Commission's [Next Generation Internet](https://ngi.eu/) programme, under the aegis of DG Communications Networks, Content and Technology under grant agreements No 957073 and No 101092990, respectively.
 
-[rustc-image]: https://img.shields.io/badge/rustc-1.81+-blue.svg
+[rustc-image]: https://img.shields.io/badge/rustc-1.74+-blue.svg
 [license-image]: https://img.shields.io/badge/license-Apache2.0-blue.svg
 [license-link]: https://git.nextgraph.org/NextGraph/nextgraph-rs/raw/branch/master/LICENSE-APACHE2
 [license-image2]: https://img.shields.io/badge/license-MIT-blue.svg

ng-storage-rocksdb/README.md

@@ -49,7 +49,7 @@ additional terms or conditions.
 NextGraph received funding through the [NGI Assure Fund](https://nlnet.nl/assure) and the [NGI Zero Commons Fund](https://nlnet.nl/commonsfund/), both funds established by [NLnet](https://nlnet.nl/) Foundation with financial support from the European Commission's [Next Generation Internet](https://ngi.eu/) programme, under the aegis of DG Communications Networks, Content and Technology under grant agreements No 957073 and No 101092990, respectively.
 
 
-[rustc-image]: https://img.shields.io/badge/rustc-1.81+-blue.svg
+[rustc-image]: https://img.shields.io/badge/rustc-1.74+-blue.svg
 [license-image]: https://img.shields.io/badge/license-Apache2.0-blue.svg
 [license-link]: https://git.nextgraph.org/NextGraph/nextgraph-rs/raw/branch/master/LICENSE-APACHE2
 [license-image2]: https://img.shields.io/badge/license-MIT-blue.svg

ng-verifier/README.md

@@ -51,7 +51,7 @@ additional terms or conditions.
 NextGraph received funding through the [NGI Assure Fund](https://nlnet.nl/assure) and the [NGI Zero Commons Fund](https://nlnet.nl/commonsfund/), both funds established by [NLnet](https://nlnet.nl/) Foundation with financial support from the European Commission's [Next Generation Internet](https://ngi.eu/) programme, under the aegis of DG Communications Networks, Content and Technology under grant agreements No 957073 and No 101092990, respectively.
 
 
-[rustc-image]: https://img.shields.io/badge/rustc-1.81+-blue.svg
+[rustc-image]: https://img.shields.io/badge/rustc-1.74+-blue.svg
 [license-image]: https://img.shields.io/badge/license-Apache2.0-blue.svg
 [license-link]: https://git.nextgraph.org/NextGraph/nextgraph-rs/raw/branch/master/LICENSE-APACHE2
 [license-image2]: https://img.shields.io/badge/license-MIT-blue.svg

ng-verifier/src/inbox_processor.rs

@@ -184,7 +184,7 @@ impl Verifier {
 
     pub(crate) async fn process_inbox(
         &mut self,
-        msg: &InboxMsg,
+        msg: InboxMsg,
         content: InboxMsgContent,
     ) -> Result<(), VerifierError> {
 

ng-verifier/src/request_processor.rs

@@ -294,11 +294,12 @@ impl Verifier {
                 ))
             }
             QueryResults::Boolean(b) => {
-                if b {
-                    AppResponse::V0(AppResponseV0::True)
-                } else {
-                    AppResponse::V0(AppResponseV0::False)
-                }
+                // serialize boolean results as standard SPARQL JSON format
+                let serializer = QueryResultsSerializer::from_format(QueryResultsFormat::Json);
+                let result = serializer
+                    .serialize_boolean_to_write(Vec::new(), b)
+                    .map_err(|_| "QueryResult serializer error")?;
+                AppResponse::V0(AppResponseV0::QueryResult(result))
             }
             QueryResults::Graph(quads) => {
                 let mut results = vec![];

ng-verifier/src/verifier.rs

@@ -1642,7 +1642,7 @@ impl Verifier {
         }
     }
 
-    pub async fn inbox(&mut self, msg: &InboxMsg, from_queue: bool) {
+    pub async fn inbox(&mut self, msg: InboxMsg, from_queue: bool) {
         
         //log_info!("RECEIVED INBOX MSG {:?}", msg);
 

ng-wallet/README.md

@@ -49,7 +49,7 @@ additional terms or conditions.
 NextGraph received funding through the [NGI Assure Fund](https://nlnet.nl/assure) and the [NGI Zero Commons Fund](https://nlnet.nl/commonsfund/), both funds established by [NLnet](https://nlnet.nl/) Foundation with financial support from the European Commission's [Next Generation Internet](https://ngi.eu/) programme, under the aegis of DG Communications Networks, Content and Technology under grant agreements No 957073 and No 101092990, respectively.
 
 
-[rustc-image]: https://img.shields.io/badge/rustc-1.81+-blue.svg
+[rustc-image]: https://img.shields.io/badge/rustc-1.74+-blue.svg
 [license-image]: https://img.shields.io/badge/license-Apache2.0-blue.svg
 [license-link]: https://git.nextgraph.org/NextGraph/nextgraph-rs/raw/branch/master/LICENSE-APACHE2
 [license-image2]: https://img.shields.io/badge/license-MIT-blue.svg

ngcli/README.md

@@ -51,7 +51,7 @@ additional terms or conditions.
 NextGraph received funding through the [NGI Assure Fund](https://nlnet.nl/assure) and the [NGI Zero Commons Fund](https://nlnet.nl/commonsfund/), both funds established by [NLnet](https://nlnet.nl/) Foundation with financial support from the European Commission's [Next Generation Internet](https://ngi.eu/) programme, under the aegis of DG Communications Networks, Content and Technology under grant agreements No 957073 and No 101092990, respectively.
 
 
-[rustc-image]: https://img.shields.io/badge/rustc-1.81+-blue.svg
+[rustc-image]: https://img.shields.io/badge/rustc-1.74+-blue.svg
 [license-image]: https://img.shields.io/badge/license-Apache2.0-blue.svg
 [license-link]: https://git.nextgraph.org/NextGraph/nextgraph-rs/raw/branch/master/LICENSE-APACHE2
 [license-image2]: https://img.shields.io/badge/license-MIT-blue.svg

ngd/README.md

@@ -89,7 +89,7 @@ additional terms or conditions.
 
 NextGraph received funding through the [NGI Assure Fund](https://nlnet.nl/assure) and the [NGI Zero Commons Fund](https://nlnet.nl/commonsfund/), both funds established by [NLnet](https://nlnet.nl/) Foundation with financial support from the European Commission's [Next Generation Internet](https://ngi.eu/) programme, under the aegis of DG Communications Networks, Content and Technology under grant agreements No 957073 and No 101092990, respectively.
 
-[rustc-image]: https://img.shields.io/badge/rustc-1.81+-blue.svg
+[rustc-image]: https://img.shields.io/badge/rustc-1.74+-blue.svg
 [license-image]: https://img.shields.io/badge/license-Apache2.0-blue.svg
 [license-link]: https://git.nextgraph.org/NextGraph/nextgraph-rs/raw/branch/master/LICENSE-APACHE2
 [license-image2]: https://img.shields.io/badge/license-MIT-blue.svg