|
|
|
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
|
|
//
|
|
|
|
// Copyright (c) 2011 The LevelDB Authors. All rights reserved.
|
|
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
|
|
// found in the LICENSE file. See the AUTHORS file for names of contributors.
|
|
|
|
|
|
|
|
#include "memory/arena.h"
|
|
|
|
|
|
|
|
#include <algorithm>
|
|
|
|
|
|
|
|
#include "logging/logging.h"
|
|
|
|
#include "port/malloc.h"
|
|
|
|
#include "port/port.h"
|
|
|
|
#include "rocksdb/env.h"
|
|
|
|
#include "test_util/sync_point.h"
|
|
|
|
#include "util/string_util.h"
|
|
|
|
|
|
|
|
namespace ROCKSDB_NAMESPACE {
|
|
|
|
|
|
|
|
size_t Arena::OptimizeBlockSize(size_t block_size) {
|
|
|
|
// Make sure block_size is in optimal range
|
|
|
|
block_size = std::max(Arena::kMinBlockSize, block_size);
|
|
|
|
block_size = std::min(Arena::kMaxBlockSize, block_size);
|
|
|
|
|
|
|
|
// make sure block_size is the multiple of kAlignUnit
|
|
|
|
if (block_size % kAlignUnit != 0) {
|
|
|
|
block_size = (1 + block_size / kAlignUnit) * kAlignUnit;
|
Make arena block size configurable
Summary:
Add an option for arena block size, default value 4096 bytes. Arena will allocate blocks with such size.
I am not sure about passing parameter to skiplist in the new virtualized framework, though I talked to Jim a bit. So add Jim as reviewer.
Test Plan:
new unit test, I am running db_test.
For passing paramter from configured option to Arena, I tried tests like:
TEST(DBTest, Arena_Option) {
std::string dbname = test::TmpDir() + "/db_arena_option_test";
DestroyDB(dbname, Options());
DB* db = nullptr;
Options opts;
opts.create_if_missing = true;
opts.arena_block_size = 1000000; // tested 99, 999999
Status s = DB::Open(opts, dbname, &db);
db->Put(WriteOptions(), "a", "123");
}
and printed some debug info. The results look good. Any suggestion for such a unit-test?
Reviewers: haobo, dhruba, emayanke, jpaton
Reviewed By: dhruba
CC: leveldb, zshao
Differential Revision: https://reviews.facebook.net/D11799
12 years ago
|
|
|
}
|
|
|
|
|
|
|
|
return block_size;
|
|
|
|
}
|
|
|
|
|
|
|
|
Arena::Arena(size_t block_size, AllocTracker* tracker, size_t huge_page_size)
|
|
|
|
: kBlockSize(OptimizeBlockSize(block_size)), tracker_(tracker) {
|
|
|
|
assert(kBlockSize >= kMinBlockSize && kBlockSize <= kMaxBlockSize &&
|
|
|
|
kBlockSize % kAlignUnit == 0);
|
|
|
|
TEST_SYNC_POINT_CALLBACK("Arena::Arena:0", const_cast<size_t*>(&kBlockSize));
|
|
|
|
alloc_bytes_remaining_ = sizeof(inline_block_);
|
|
|
|
blocks_memory_ += alloc_bytes_remaining_;
|
|
|
|
aligned_alloc_ptr_ = inline_block_;
|
|
|
|
unaligned_alloc_ptr_ = inline_block_ + alloc_bytes_remaining_;
|
|
|
|
if (MemMapping::kHugePageSupported) {
|
|
|
|
hugetlb_size_ = huge_page_size;
|
|
|
|
if (hugetlb_size_ && kBlockSize > hugetlb_size_) {
|
|
|
|
hugetlb_size_ = ((kBlockSize - 1U) / hugetlb_size_ + 1U) * hugetlb_size_;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if (tracker_ != nullptr) {
|
|
|
|
tracker_->Allocate(kInlineSize);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
Arena::~Arena() {
|
|
|
|
if (tracker_ != nullptr) {
|
|
|
|
assert(tracker_->is_freed());
|
|
|
|
tracker_->FreeMem();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
char* Arena::AllocateFallback(size_t bytes, bool aligned) {
|
|
|
|
if (bytes > kBlockSize / 4) {
|
|
|
|
++irregular_block_num;
|
|
|
|
// Object is more than a quarter of our block size. Allocate it separately
|
|
|
|
// to avoid wasting too much space in leftover bytes.
|
|
|
|
return AllocateNewBlock(bytes);
|
|
|
|
}
|
|
|
|
|
|
|
|
// We waste the remaining space in the current block.
|
|
|
|
size_t size = 0;
|
|
|
|
char* block_head = nullptr;
|
|
|
|
if (MemMapping::kHugePageSupported && hugetlb_size_ > 0) {
|
|
|
|
size = hugetlb_size_;
|
|
|
|
block_head = AllocateFromHugePage(size);
|
|
|
|
}
|
|
|
|
if (!block_head) {
|
|
|
|
size = kBlockSize;
|
|
|
|
block_head = AllocateNewBlock(size);
|
|
|
|
}
|
|
|
|
alloc_bytes_remaining_ = size - bytes;
|
|
|
|
|
|
|
|
if (aligned) {
|
|
|
|
aligned_alloc_ptr_ = block_head + bytes;
|
|
|
|
unaligned_alloc_ptr_ = block_head + size;
|
|
|
|
return block_head;
|
|
|
|
} else {
|
|
|
|
aligned_alloc_ptr_ = block_head;
|
|
|
|
unaligned_alloc_ptr_ = block_head + size - bytes;
|
|
|
|
return unaligned_alloc_ptr_;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
char* Arena::AllocateFromHugePage(size_t bytes) {
|
|
|
|
MemMapping mm = MemMapping::AllocateHuge(bytes);
|
|
|
|
auto addr = static_cast<char*>(mm.Get());
|
|
|
|
if (addr) {
|
|
|
|
huge_blocks_.push_back(std::move(mm));
|
|
|
|
blocks_memory_ += bytes;
|
|
|
|
if (tracker_ != nullptr) {
|
|
|
|
tracker_->Allocate(bytes);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return addr;
|
|
|
|
}
|
|
|
|
|
|
|
|
char* Arena::AllocateAligned(size_t bytes, size_t huge_page_size,
|
|
|
|
Logger* logger) {
|
|
|
|
if (MemMapping::kHugePageSupported && hugetlb_size_ > 0 &&
|
|
|
|
huge_page_size > 0 && bytes > 0) {
|
|
|
|
// Allocate from a huge page TLB table.
|
|
|
|
size_t reserved_size =
|
|
|
|
((bytes - 1U) / huge_page_size + 1U) * huge_page_size;
|
|
|
|
assert(reserved_size >= bytes);
|
|
|
|
|
|
|
|
char* addr = AllocateFromHugePage(reserved_size);
|
|
|
|
if (addr == nullptr) {
|
|
|
|
ROCKS_LOG_WARN(logger,
|
|
|
|
"AllocateAligned fail to allocate huge TLB pages: %s",
|
|
|
|
errnoStr(errno).c_str());
|
|
|
|
// fail back to malloc
|
|
|
|
} else {
|
|
|
|
return addr;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
size_t current_mod =
|
|
|
|
reinterpret_cast<uintptr_t>(aligned_alloc_ptr_) & (kAlignUnit - 1);
|
|
|
|
size_t slop = (current_mod == 0 ? 0 : kAlignUnit - current_mod);
|
|
|
|
size_t needed = bytes + slop;
|
|
|
|
char* result;
|
|
|
|
if (needed <= alloc_bytes_remaining_) {
|
|
|
|
result = aligned_alloc_ptr_ + slop;
|
|
|
|
aligned_alloc_ptr_ += needed;
|
|
|
|
alloc_bytes_remaining_ -= needed;
|
|
|
|
} else {
|
support for concurrent adds to memtable
Summary:
This diff adds support for concurrent adds to the skiplist memtable
implementations. Memory allocation is made thread-safe by the addition of
a spinlock, with small per-core buffers to avoid contention. Concurrent
memtable writes are made via an additional method and don't impose a
performance overhead on the non-concurrent case, so parallelism can be
selected on a per-batch basis.
Write thread synchronization is an increasing bottleneck for higher levels
of concurrency, so this diff adds --enable_write_thread_adaptive_yield
(default off). This feature causes threads joining a write batch
group to spin for a short time (default 100 usec) using sched_yield,
rather than going to sleep on a mutex. If the timing of the yield calls
indicates that another thread has actually run during the yield then
spinning is avoided. This option improves performance for concurrent
situations even without parallel adds, although it has the potential to
increase CPU usage (and the heuristic adaptation is not yet mature).
Parallel writes are not currently compatible with
inplace updates, update callbacks, or delete filtering.
Enable it with --allow_concurrent_memtable_write (and
--enable_write_thread_adaptive_yield). Parallel memtable writes
are performance neutral when there is no actual parallelism, and in
my experiments (SSD server-class Linux and varying contention and key
sizes for fillrandom) they are always a performance win when there is
more than one thread.
Statistics are updated earlier in the write path, dropping the number
of DB mutex acquisitions from 2 to 1 for almost all cases.
This diff was motivated and inspired by Yahoo's cLSM work. It is more
conservative than cLSM: RocksDB's write batch group leader role is
preserved (along with all of the existing flush and write throttling
logic) and concurrent writers are blocked until all memtable insertions
have completed and the sequence number has been advanced, to preserve
linearizability.
My test config is "db_bench -benchmarks=fillrandom -threads=$T
-batch_size=1 -memtablerep=skip_list -value_size=100 --num=1000000/$T
-level0_slowdown_writes_trigger=9999 -level0_stop_writes_trigger=9999
-disable_auto_compactions --max_write_buffer_number=8
-max_background_flushes=8 --disable_wal --write_buffer_size=160000000
--block_size=16384 --allow_concurrent_memtable_write" on a two-socket
Xeon E5-2660 @ 2.2Ghz with lots of memory and an SSD hard drive. With 1
thread I get ~440Kops/sec. Peak performance for 1 socket (numactl
-N1) is slightly more than 1Mops/sec, at 16 threads. Peak performance
across both sockets happens at 30 threads, and is ~900Kops/sec, although
with fewer threads there is less performance loss when the system has
background work.
Test Plan:
1. concurrent stress tests for InlineSkipList and DynamicBloom
2. make clean; make check
3. make clean; DISABLE_JEMALLOC=1 make valgrind_check; valgrind db_bench
4. make clean; COMPILE_WITH_TSAN=1 make all check; db_bench
5. make clean; COMPILE_WITH_ASAN=1 make all check; db_bench
6. make clean; OPT=-DROCKSDB_LITE make check
7. verify no perf regressions when disabled
Reviewers: igor, sdong
Reviewed By: sdong
Subscribers: MarkCallaghan, IslamAbdelRahman, anthony, yhchiang, rven, sdong, guyg8, kradhakrishnan, dhruba
Differential Revision: https://reviews.facebook.net/D50589
9 years ago
|
|
|
// AllocateFallback always returns aligned memory
|
|
|
|
result = AllocateFallback(bytes, true /* aligned */);
|
|
|
|
}
|
|
|
|
assert((reinterpret_cast<uintptr_t>(result) & (kAlignUnit - 1)) == 0);
|
|
|
|
return result;
|
|
|
|
}
|
|
|
|
|
|
|
|
char* Arena::AllocateNewBlock(size_t block_bytes) {
|
|
|
|
// NOTE: std::make_unique zero-initializes the block so is not appropriate
|
|
|
|
// here
|
|
|
|
char* block = new char[block_bytes];
|
|
|
|
blocks_.push_back(std::unique_ptr<char[]>(block));
|
|
|
|
|
|
|
|
size_t allocated_size;
|
|
|
|
#ifdef ROCKSDB_MALLOC_USABLE_SIZE
|
|
|
|
allocated_size = malloc_usable_size(block);
|
|
|
|
#ifndef NDEBUG
|
|
|
|
// It's hard to predict what malloc_usable_size() returns.
|
|
|
|
// A callback can allow users to change the costed size.
|
|
|
|
std::pair<size_t*, size_t*> pair(&allocated_size, &block_bytes);
|
|
|
|
TEST_SYNC_POINT_CALLBACK("Arena::AllocateNewBlock:0", &pair);
|
|
|
|
#endif // NDEBUG
|
|
|
|
#else
|
|
|
|
allocated_size = block_bytes;
|
|
|
|
#endif // ROCKSDB_MALLOC_USABLE_SIZE
|
|
|
|
blocks_memory_ += allocated_size;
|
|
|
|
if (tracker_ != nullptr) {
|
|
|
|
tracker_->Allocate(allocated_size);
|
|
|
|
}
|
|
|
|
return block;
|
|
|
|
}
|
|
|
|
|
|
|
|
} // namespace ROCKSDB_NAMESPACE
|