|
|
|
// Copyright (c) 2013, Facebook, Inc. All rights reserved.
|
|
|
|
// This source code is licensed under the BSD-style license found in the
|
|
|
|
// LICENSE file in the root directory of this source tree. An additional grant
|
|
|
|
// of patent rights can be found in the PATENTS file in the same directory.
|
|
|
|
//
|
|
|
|
// Copyright (c) 2011 The LevelDB Authors. All rights reserved.
|
|
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
|
|
// found in the LICENSE file. See the AUTHORS file for names of contributors.
|
|
|
|
|
|
|
|
// Arena is an implementation of Arena class. For a request of small size,
|
Make arena block size configurable
Summary:
Add an option for arena block size, default value 4096 bytes. Arena will allocate blocks with such size.
I am not sure about passing parameter to skiplist in the new virtualized framework, though I talked to Jim a bit. So add Jim as reviewer.
Test Plan:
new unit test, I am running db_test.
For passing paramter from configured option to Arena, I tried tests like:
TEST(DBTest, Arena_Option) {
std::string dbname = test::TmpDir() + "/db_arena_option_test";
DestroyDB(dbname, Options());
DB* db = nullptr;
Options opts;
opts.create_if_missing = true;
opts.arena_block_size = 1000000; // tested 99, 999999
Status s = DB::Open(opts, dbname, &db);
db->Put(WriteOptions(), "a", "123");
}
and printed some debug info. The results look good. Any suggestion for such a unit-test?
Reviewers: haobo, dhruba, emayanke, jpaton
Reviewed By: dhruba
CC: leveldb, zshao
Differential Revision: https://reviews.facebook.net/D11799
11 years ago
|
|
|
// it allocates a block with pre-defined block size. For a request of big
|
|
|
|
// size, it uses malloc to directly get the requested size.
|
|
|
|
|
|
|
|
#pragma once
|
|
|
|
#include <cstddef>
|
|
|
|
#include <cerrno>
|
|
|
|
#include <vector>
|
|
|
|
#include <assert.h>
|
|
|
|
#include <stdint.h>
|
|
|
|
#include "util/arena.h"
|
|
|
|
|
|
|
|
namespace rocksdb {
|
|
|
|
|
|
|
|
class Logger;
|
|
|
|
|
In DB::NewIterator(), try to allocate the whole iterator tree in an arena
Summary:
In this patch, try to allocate the whole iterator tree starting from DBIter from an arena
1. ArenaWrappedDBIter is created when serves as the entry point of an iterator tree, with an arena in it.
2. Add an option to create iterator from arena for following iterators: DBIter, MergingIterator, MemtableIterator, all mem table's iterators, all table reader's iterators and two level iterator.
3. MergeIteratorBuilder is created to incrementally build the tree of internal iterators. It is passed to mem table list and version set and add iterators to it.
Limitations:
(1) Only DB::NewIterator() without tailing uses the arena. Other cases, including readonly DB and compactions are still from malloc
(2) Two level iterator itself is allocated in arena, but not iterators inside it.
Test Plan: make all check
Reviewers: ljin, haobo
Reviewed By: haobo
Subscribers: leveldb, dhruba, yhchiang, igor
Differential Revision: https://reviews.facebook.net/D18513
11 years ago
|
|
|
const size_t kInlineSize = 2048;
|
|
|
|
|
|
|
|
class Arena {
|
|
|
|
public:
|
|
|
|
// No copying allowed
|
|
|
|
Arena(const Arena&) = delete;
|
|
|
|
void operator=(const Arena&) = delete;
|
|
|
|
|
|
|
|
static const size_t kInlineSize = 2048;
|
|
|
|
static const size_t kMinBlockSize;
|
|
|
|
static const size_t kMaxBlockSize;
|
|
|
|
|
|
|
|
explicit Arena(size_t block_size = kMinBlockSize);
|
|
|
|
~Arena();
|
|
|
|
|
|
|
|
char* Allocate(size_t bytes);
|
|
|
|
|
|
|
|
// huge_page_size: if >0, will try to allocate from huage page TLB.
|
|
|
|
// The argument will be the size of the page size for huge page TLB. Bytes
|
|
|
|
// will be rounded up to multiple of the page size to allocate through mmap
|
|
|
|
// anonymous option with huge page on. The extra space allocated will be
|
|
|
|
// wasted. If allocation fails, will fall back to normal case. To enable it,
|
|
|
|
// need to reserve huge pages for it to be allocated, like:
|
|
|
|
// sysctl -w vm.nr_hugepages=20
|
|
|
|
// See linux doc Documentation/vm/hugetlbpage.txt for details.
|
|
|
|
// huge page allocation can fail. In this case it will fail back to
|
|
|
|
// normal cases. The messages will be logged to logger. So when calling with
|
|
|
|
// huge_page_tlb_size > 0, we highly recommend a logger is passed in.
|
|
|
|
// Otherwise, the error message will be printed out to stderr directly.
|
|
|
|
char* AllocateAligned(size_t bytes, size_t huge_page_size = 0,
|
|
|
|
Logger* logger = nullptr);
|
|
|
|
|
|
|
|
// Returns an estimate of the total memory usage of data allocated
|
|
|
|
// by the arena (exclude the space allocated but not yet used for future
|
|
|
|
// allocations).
|
|
|
|
size_t ApproximateMemoryUsage() const {
|
|
|
|
return blocks_memory_ + blocks_.capacity() * sizeof(char*) -
|
|
|
|
alloc_bytes_remaining_;
|
|
|
|
}
|
|
|
|
|
|
|
|
size_t MemoryAllocatedBytes() const { return blocks_memory_; }
|
Make arena block size configurable
Summary:
Add an option for arena block size, default value 4096 bytes. Arena will allocate blocks with such size.
I am not sure about passing parameter to skiplist in the new virtualized framework, though I talked to Jim a bit. So add Jim as reviewer.
Test Plan:
new unit test, I am running db_test.
For passing paramter from configured option to Arena, I tried tests like:
TEST(DBTest, Arena_Option) {
std::string dbname = test::TmpDir() + "/db_arena_option_test";
DestroyDB(dbname, Options());
DB* db = nullptr;
Options opts;
opts.create_if_missing = true;
opts.arena_block_size = 1000000; // tested 99, 999999
Status s = DB::Open(opts, dbname, &db);
db->Put(WriteOptions(), "a", "123");
}
and printed some debug info. The results look good. Any suggestion for such a unit-test?
Reviewers: haobo, dhruba, emayanke, jpaton
Reviewed By: dhruba
CC: leveldb, zshao
Differential Revision: https://reviews.facebook.net/D11799
11 years ago
|
|
|
|
|
|
|
size_t AllocatedAndUnused() const { return alloc_bytes_remaining_; }
|
|
|
|
|
|
|
|
// If an allocation is too big, we'll allocate an irregular block with the
|
|
|
|
// same size of that allocation.
|
|
|
|
size_t IrregularBlockNum() const { return irregular_block_num; }
|
|
|
|
|
|
|
|
size_t BlockSize() const { return kBlockSize; }
|
|
|
|
|
|
|
|
private:
|
|
|
|
char inline_block_[kInlineSize];
|
Make arena block size configurable
Summary:
Add an option for arena block size, default value 4096 bytes. Arena will allocate blocks with such size.
I am not sure about passing parameter to skiplist in the new virtualized framework, though I talked to Jim a bit. So add Jim as reviewer.
Test Plan:
new unit test, I am running db_test.
For passing paramter from configured option to Arena, I tried tests like:
TEST(DBTest, Arena_Option) {
std::string dbname = test::TmpDir() + "/db_arena_option_test";
DestroyDB(dbname, Options());
DB* db = nullptr;
Options opts;
opts.create_if_missing = true;
opts.arena_block_size = 1000000; // tested 99, 999999
Status s = DB::Open(opts, dbname, &db);
db->Put(WriteOptions(), "a", "123");
}
and printed some debug info. The results look good. Any suggestion for such a unit-test?
Reviewers: haobo, dhruba, emayanke, jpaton
Reviewed By: dhruba
CC: leveldb, zshao
Differential Revision: https://reviews.facebook.net/D11799
11 years ago
|
|
|
// Number of bytes allocated in one block
|
|
|
|
const size_t kBlockSize;
|
|
|
|
// Array of new[] allocated memory blocks
|
|
|
|
typedef std::vector<char*> Blocks;
|
|
|
|
Blocks blocks_;
|
|
|
|
|
|
|
|
struct MmapInfo {
|
|
|
|
void* addr_;
|
|
|
|
size_t length_;
|
|
|
|
|
|
|
|
MmapInfo(void* addr, size_t length) : addr_(addr), length_(length) {}
|
|
|
|
};
|
|
|
|
std::vector<MmapInfo> huge_blocks_;
|
|
|
|
size_t irregular_block_num = 0;
|
|
|
|
|
|
|
|
// Stats for current active block.
|
|
|
|
// For each block, we allocate aligned memory chucks from one end and
|
|
|
|
// allocate unaligned memory chucks from the other end. Otherwise the
|
|
|
|
// memory waste for alignment will be higher if we allocate both types of
|
|
|
|
// memory from one direction.
|
|
|
|
char* unaligned_alloc_ptr_ = nullptr;
|
|
|
|
char* aligned_alloc_ptr_ = nullptr;
|
|
|
|
// How many bytes left in currently active block?
|
|
|
|
size_t alloc_bytes_remaining_ = 0;
|
|
|
|
|
|
|
|
char* AllocateFallback(size_t bytes, bool aligned);
|
|
|
|
char* AllocateNewBlock(size_t block_bytes);
|
|
|
|
|
|
|
|
// Bytes of memory in blocks allocated so far
|
|
|
|
size_t blocks_memory_ = 0;
|
|
|
|
};
|
|
|
|
|
|
|
|
inline char* Arena::Allocate(size_t bytes) {
|
|
|
|
// The semantics of what to return are a bit messy if we allow
|
|
|
|
// 0-byte allocations, so we disallow them here (we don't need
|
|
|
|
// them for our internal use).
|
|
|
|
assert(bytes > 0);
|
|
|
|
if (bytes <= alloc_bytes_remaining_) {
|
|
|
|
unaligned_alloc_ptr_ -= bytes;
|
|
|
|
alloc_bytes_remaining_ -= bytes;
|
|
|
|
return unaligned_alloc_ptr_;
|
|
|
|
}
|
|
|
|
return AllocateFallback(bytes, false /* unaligned */);
|
|
|
|
}
|
|
|
|
|
|
|
|
// check and adjust the block_size so that the return value is
|
|
|
|
// 1. in the range of [kMinBlockSize, kMaxBlockSize].
|
|
|
|
// 2. the multiple of align unit.
|
|
|
|
extern size_t OptimizeBlockSize(size_t block_size);
|
|
|
|
|
|
|
|
} // namespace rocksdb
|