NextGraph
/
rocksdb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove port::MemoryBarrier() from table_reader_bench

Browse Source 
Summary: port::MemoryBarrier() is not recommended to use outside of port. Remove it.

Test Plan: run table_reader_bench

Reviewers: ljin, yhchiang, igor

Reviewed By: igor

Subscribers: leveldb

Differential Revision: https://reviews.facebook.net/D21075
main
sdong 11 years ago
parent 1129921e9b
commit 02c4023666
1 changed files with 0 additions and 5 deletions
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Show Stats Download Patch File Download Diff File
  1. 5
      table/table_reader_bench.cc

5
table/table_reader_bench.cc
Unescape View File

@ -144,14 +144,12 @@ void TableReaderBenchmark(Options& opts, EnvOptions& env_options,
// Query one existing key; // Query one existing key;
std::string key = MakeKey(r1, r2, through_db); std::string key = MakeKey(r1, r2, through_db);
uint64_t start_time = Now(env, measured_by_nanosecond); uint64_t start_time = Now(env, measured_by_nanosecond);
port::MemoryBarrier();
if (!through_db) { if (!through_db) {
s = table_reader->Get(read_options, key, arg, DummySaveValue, s = table_reader->Get(read_options, key, arg, DummySaveValue,
nullptr); nullptr);
} else { } else {
s = db->Get(read_options, key, &result); s = db->Get(read_options, key, &result);
} }
port::MemoryBarrier();
hist.Add(Now(env, measured_by_nanosecond) - start_time); hist.Add(Now(env, measured_by_nanosecond) - start_time);
} else { } else {
int r2_len; int r2_len;
@ -167,7 +165,6 @@ void TableReaderBenchmark(Options& opts, EnvOptions& env_options,
std::string end_key = MakeKey(r1, r2 + r2_len, through_db); std::string end_key = MakeKey(r1, r2 + r2_len, through_db);
uint64_t total_time = 0; uint64_t total_time = 0;
uint64_t start_time = Now(env, measured_by_nanosecond); uint64_t start_time = Now(env, measured_by_nanosecond);
port::MemoryBarrier();
Iterator* iter; Iterator* iter;
if (!through_db) { if (!through_db) {
iter = table_reader->NewIterator(read_options); iter = table_reader->NewIterator(read_options);
@ -180,7 +177,6 @@ void TableReaderBenchmark(Options& opts, EnvOptions& env_options,
break; break;
} }
// verify key; // verify key;
port::MemoryBarrier();
total_time += Now(env, measured_by_nanosecond) - start_time; total_time += Now(env, measured_by_nanosecond) - start_time;
assert(Slice(MakeKey(r1, r2 + count, through_db)) == iter->key()); assert(Slice(MakeKey(r1, r2 + count, through_db)) == iter->key());
start_time = Now(env, measured_by_nanosecond); start_time = Now(env, measured_by_nanosecond);
@ -195,7 +191,6 @@ void TableReaderBenchmark(Options& opts, EnvOptions& env_options,
assert(false); assert(false);
} }
delete iter; delete iter;
port::MemoryBarrier();
total_time += Now(env, measured_by_nanosecond) - start_time; total_time += Now(env, measured_by_nanosecond) - start_time;
hist.Add(total_time); hist.Add(total_time);
} }

Write Preview
Loading…
Cancel
Save