NextGraph
/
rocksdb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bypass tests instead of skipping (#10076)

Browse Source 
Summary:
Make fb test infra happy, more details: https://github.com/facebook/rocksdb/issues/8048

Pull Request resolved: https://github.com/facebook/rocksdb/pull/10076

Test Plan: CI

Reviewed By: ajkr

Differential Revision: D36768766

Pulled By: jay-zhuang

fbshipit-source-id: 4f039a5c623abb6d4a7d09bbf97077618e7ec2c8
main
Jay Zhuang 3 years ago committed by Facebook GitHub Bot
parent 5ab5537d79
commit 151dc0038a
1 changed files with 7 additions and 7 deletions
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Show Stats Download Patch File Download Diff File
  1. 14
      db/db_basic_test.cc

14
db/db_basic_test.cc
Unescape View File

@ -1467,7 +1467,7 @@ TEST_P(DBMultiGetTestWithParam, MultiGetBatchedSimpleUnsorted) {
#endif // USE_COROUTINES #endif // USE_COROUTINES
// Skip for unbatched MultiGet // Skip for unbatched MultiGet
if (!std::get<0>(GetParam())) { if (!std::get<0>(GetParam())) {
ROCKSDB_GTEST_SKIP("This test is only for batched MultiGet"); ROCKSDB_GTEST_BYPASS("This test is only for batched MultiGet");
return; return;
} }
do { do {
@ -1521,7 +1521,7 @@ TEST_P(DBMultiGetTestWithParam, MultiGetBatchedSortedMultiFile) {
#endif // USE_COROUTINES #endif // USE_COROUTINES
// Skip for unbatched MultiGet // Skip for unbatched MultiGet
if (!std::get<0>(GetParam())) { if (!std::get<0>(GetParam())) {
ROCKSDB_GTEST_SKIP("This test is only for batched MultiGet"); ROCKSDB_GTEST_BYPASS("This test is only for batched MultiGet");
return; return;
} }
do { do {
@ -1579,7 +1579,7 @@ TEST_P(DBMultiGetTestWithParam, MultiGetBatchedDuplicateKeys) {
#endif // USE_COROUTINES #endif // USE_COROUTINES
// Skip for unbatched MultiGet // Skip for unbatched MultiGet
if (!std::get<0>(GetParam())) { if (!std::get<0>(GetParam())) {
ROCKSDB_GTEST_SKIP("This test is only for batched MultiGet"); ROCKSDB_GTEST_BYPASS("This test is only for batched MultiGet");
return; return;
} }
Options opts = CurrentOptions(); Options opts = CurrentOptions();
@ -1643,7 +1643,7 @@ TEST_P(DBMultiGetTestWithParam, MultiGetBatchedMultiLevel) {
#endif // USE_COROUTINES #endif // USE_COROUTINES
// Skip for unbatched MultiGet // Skip for unbatched MultiGet
if (!std::get<0>(GetParam())) { if (!std::get<0>(GetParam())) {
ROCKSDB_GTEST_SKIP("This test is only for batched MultiGet"); ROCKSDB_GTEST_BYPASS("This test is only for batched MultiGet");
return; return;
} }
Options options = CurrentOptions(); Options options = CurrentOptions();
@ -1729,7 +1729,7 @@ TEST_P(DBMultiGetTestWithParam, MultiGetBatchedMultiLevelMerge) {
#endif // USE_COROUTINES #endif // USE_COROUTINES
// Skip for unbatched MultiGet // Skip for unbatched MultiGet
if (!std::get<0>(GetParam())) { if (!std::get<0>(GetParam())) {
ROCKSDB_GTEST_SKIP("This test is only for batched MultiGet"); ROCKSDB_GTEST_BYPASS("This test is only for batched MultiGet");
return; return;
} }
Options options = CurrentOptions(); Options options = CurrentOptions();
@ -1826,7 +1826,7 @@ TEST_P(DBMultiGetTestWithParam, MultiGetBatchedValueSizeInMemory) {
#endif // USE_COROUTINES #endif // USE_COROUTINES
// Skip for unbatched MultiGet // Skip for unbatched MultiGet
if (!std::get<0>(GetParam())) { if (!std::get<0>(GetParam())) {
ROCKSDB_GTEST_SKIP("This test is only for batched MultiGet"); ROCKSDB_GTEST_BYPASS("This test is only for batched MultiGet");
return; return;
} }
CreateAndReopenWithCF({"pikachu"}, CurrentOptions()); CreateAndReopenWithCF({"pikachu"}, CurrentOptions());
@ -1958,7 +1958,7 @@ TEST_P(DBMultiGetTestWithParam, MultiGetBatchedValueSizeMultiLevelMerge) {
#endif // USE_COROUTINES #endif // USE_COROUTINES
// Skip for unbatched MultiGet // Skip for unbatched MultiGet
if (!std::get<0>(GetParam())) { if (!std::get<0>(GetParam())) {
ROCKSDB_GTEST_SKIP("This test is only for batched MultiGet"); ROCKSDB_GTEST_BYPASS("This test is only for batched MultiGet");
return; return;
} }
Options options = CurrentOptions(); Options options = CurrentOptions();

Write Preview
Loading…
Cancel
Save