Update rocksdb.read.block.get.micros when block cache disabled

Summary:
Previously `ReadBlockFromFile` for data blocks was only measured when reading a block to populate block cache. This PR adds the corresponding measurements for users who disabled block cache.
Closes https://github.com/facebook/rocksdb/pull/3442

Differential Revision: D6848671

Pulled By: ajkr

fbshipit-source-id: bb4bbe1797fa2cc1d9a5bad44891af2b55384b41
main
Andrew Kryczka 7 years ago committed by Facebook Github Bot
parent 5eccf0b9d5
commit 1edac32b77
  1. 12
      table/block_based_table_reader.cc

@ -1499,11 +1499,15 @@ BlockIter* BlockBasedTable::NewDataBlockIterator(
return iter; return iter;
} }
std::unique_ptr<Block> block_value; std::unique_ptr<Block> block_value;
s = ReadBlockFromFile(rep->file.get(), nullptr /* prefetch_buffer */, {
rep->footer, ro, handle, &block_value, rep->ioptions, StopWatch sw(rep->ioptions.env, rep->ioptions.statistics,
true /* compress */, compression_dict, READ_BLOCK_GET_MICROS);
rep->persistent_cache_options, rep->global_seqno, s = ReadBlockFromFile(
rep->file.get(), nullptr /* prefetch_buffer */, rep->footer, ro,
handle, &block_value, rep->ioptions, true /* compress */,
compression_dict, rep->persistent_cache_options, rep->global_seqno,
rep->table_options.read_amp_bytes_per_bit); rep->table_options.read_amp_bytes_per_bit);
}
if (s.ok()) { if (s.ok()) {
block.value = block_value.release(); block.value = block_value.release();
} }

Loading…
Cancel
Save