NextGraph
/
rocksdb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Disable fsync in some ExternalSSTFileTest tests (#7303)

Browse Source 
Summary:
Some ExternalSSTFileTest runs very long on some places. Disable fsync in some tests to speed them up.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/7303

Test Plan: Run these tests.

Reviewed By: riversand963

Differential Revision: D23280261

fbshipit-source-id: 0dca862e462f9e6d807f393320a1f82aa5b87e59
main
sdong 4 years ago committed by Facebook GitHub Bot
parent ed7ea43dd9
commit 21ce018a32
1 changed files with 6 additions and 0 deletions
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Show Stats Download Patch File Download Diff File
  1. 6
      db/external_sst_file_test.cc

6
db/external_sst_file_test.cc
Unescape View File

@ -990,6 +990,7 @@ TEST_F(ExternalSSTFileTest, SkipSnapshot) {
} }
TEST_F(ExternalSSTFileTest, MultiThreaded) { TEST_F(ExternalSSTFileTest, MultiThreaded) {
env_->skip_fsync_ = true;
// Bulk load 10 files every file contain 1000 keys // Bulk load 10 files every file contain 1000 keys
int num_files = 10; int num_files = 10;
int keys_per_file = 1000; int keys_per_file = 1000;
@ -1102,6 +1103,7 @@ TEST_F(ExternalSSTFileTest, MultiThreaded) {
} }
TEST_F(ExternalSSTFileTest, OverlappingRanges) { TEST_F(ExternalSSTFileTest, OverlappingRanges) {
env_->skip_fsync_ = true;
Random rnd(301); Random rnd(301);
SequenceNumber assigned_seqno = 0; SequenceNumber assigned_seqno = 0;
ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack( ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
@ -1234,6 +1236,7 @@ TEST_F(ExternalSSTFileTest, OverlappingRanges) {
} }
TEST_P(ExternalSSTFileTest, PickedLevel) { TEST_P(ExternalSSTFileTest, PickedLevel) {
env_->skip_fsync_ = true;
Options options = CurrentOptions(); Options options = CurrentOptions();
options.disable_auto_compactions = false; options.disable_auto_compactions = false;
options.level0_file_num_compaction_trigger = 4; options.level0_file_num_compaction_trigger = 4;
@ -1300,6 +1303,7 @@ TEST_P(ExternalSSTFileTest, PickedLevel) {
} }
TEST_F(ExternalSSTFileTest, PickedLevelBug) { TEST_F(ExternalSSTFileTest, PickedLevelBug) {
env_->skip_fsync_ = true;
Options options = CurrentOptions(); Options options = CurrentOptions();
options.disable_auto_compactions = false; options.disable_auto_compactions = false;
options.level0_file_num_compaction_trigger = 3; options.level0_file_num_compaction_trigger = 3;
@ -1420,6 +1424,7 @@ TEST_F(ExternalSSTFileTest, IngestNonExistingFile) {
} }
TEST_F(ExternalSSTFileTest, CompactDuringAddFileRandom) { TEST_F(ExternalSSTFileTest, CompactDuringAddFileRandom) {
env_->skip_fsync_ = true;
Options options = CurrentOptions(); Options options = CurrentOptions();
options.disable_auto_compactions = false; options.disable_auto_compactions = false;
options.level0_file_num_compaction_trigger = 2; options.level0_file_num_compaction_trigger = 2;
@ -1477,6 +1482,7 @@ TEST_F(ExternalSSTFileTest, CompactDuringAddFileRandom) {
} }
TEST_F(ExternalSSTFileTest, PickedLevelDynamic) { TEST_F(ExternalSSTFileTest, PickedLevelDynamic) {
env_->skip_fsync_ = true;
Options options = CurrentOptions(); Options options = CurrentOptions();
options.disable_auto_compactions = false; options.disable_auto_compactions = false;
options.level0_file_num_compaction_trigger = 4; options.level0_file_num_compaction_trigger = 4;

Write Preview
Loading…
Cancel
Save