Remove invalid comparison of va_list and nullptr (#5836)

Summary:
The comparison of va_list and nullptr is always False under any arch, and will raise invalid operands of types error in aarch64 env (`error: invalid operands of types ‘va_list {aka __va_list}’ and ‘std::nullptr_t’ to binary ‘operator!=’`).

This patch removes this invalid assert.

Closes: https://github.com/facebook/rocksdb/issues/4277
Pull Request resolved: https://github.com/facebook/rocksdb/pull/5836

Differential Revision: D17532470

fbshipit-source-id: ca98078ecbc6a9416c69de3bd6ffcfa33a0f0185
main
Yikun Jiang 5 years ago committed by Facebook Github Bot
parent 42f898bf83
commit 2367656b6c
  1. 1
      java/rocksjni/loggerjnicallback.cc

@ -131,7 +131,6 @@ void LoggerJniCallback::Logv(const InfoLogLevel log_level, const char* format,
} }
assert(format != nullptr); assert(format != nullptr);
assert(ap != nullptr);
const std::unique_ptr<char[]> msg = format_str(format, ap); const std::unique_ptr<char[]> msg = format_str(format, ap);
// pass msg to java callback handler // pass msg to java callback handler

Loading…
Cancel
Save