Revert "Don't compile ldb tool into static library"

This reverts commit e296577ef6.

Makefile

@@ -106,17 +106,13 @@ TESTS = \
         geodb_test
 
 TOOLS = \
-	sst_dump \
+        sst_dump \
 	db_sanity_test \
-	db_stress \
+        db_stress \
-	ldb \
+        ldb \
 	db_repl_stress \
 	blob_store_bench
 
-LDB_OBJECTS = \
-		tools/ldb_cmd.o \
-		tools/ldb_tool.o
-
 
 PROGRAMS = db_bench signal_test table_reader_bench $(TESTS) $(TOOLS)
 BENCHMARKS = db_bench_sqlite3 db_bench_tree_db table_reader_bench
@@ -414,8 +410,8 @@ auto_roll_logger_test: util/auto_roll_logger_test.o $(LIBOBJECTS) $(TESTHARNESS)
 sst_dump: tools/sst_dump.o $(LIBOBJECTS)
 	$(CXX) tools/sst_dump.o $(LIBOBJECTS) $(EXEC_LDFLAGS) -o $@ $(LDFLAGS) $(COVERAGEFLAGS)
 
-ldb: tools/ldb.o $(LDB_OBJECTS) $(LIBOBJECTS)
+ldb: tools/ldb.o $(LIBOBJECTS)
-	$(CXX) tools/ldb.o $(LDB_OBJECTS) $(LIBOBJECTS) $(EXEC_LDFLAGS) -o $@ $(LDFLAGS) $(COVERAGEFLAGS)
+	$(CXX) tools/ldb.o $(LIBOBJECTS) $(EXEC_LDFLAGS) -o $@ $(LDFLAGS) $(COVERAGEFLAGS)
 
 # ---------------------------------------------------------------------------
 # Jni stuff

include/rocksdb/ldb_tool.h

@@ -2,8 +2,8 @@
 // This source code is licensed under the BSD-style license found in the
 // LICENSE file in the root directory of this source tree. An additional grant
 // of patent rights can be found in the PATENTS file in the same directory.
-#pragma once
+#ifndef STORAGE_ROCKSDB_INCLUDE_LDB_TOOL_H
-
+#define STORAGE_ROCKSDB_INCLUDE_LDB_TOOL_H
 #include "rocksdb/options.h"
 
 namespace rocksdb {
@@ -14,3 +14,5 @@ class LDBTool {
 };
 
 } // namespace rocksdb
+
+#endif // STORAGE_ROCKSDB_INCLUDE_LDB_TOOL_H

tools/ldb.cc

@@ -4,7 +4,7 @@
 //  of patent rights can be found in the PATENTS file in the same directory.
 //
 
-#include "tools/ldb_tool.h"
+#include "rocksdb/ldb_tool.h"
 
 int main(int argc, char** argv) {
   rocksdb::LDBTool tool;

util/ldb_cmd.cc

@@ -3,7 +3,7 @@
 //  LICENSE file in the root directory of this source tree. An additional grant
 //  of patent rights can be found in the PATENTS file in the same directory.
 //
-#include "tools/ldb_cmd.h"
+#include "util/ldb_cmd.h"
 
 #include "db/dbformat.h"
 #include "db/db_impl.h"

util/ldb_cmd.h

@@ -17,7 +17,7 @@
 #include "rocksdb/iterator.h"
 #include "rocksdb/slice.h"
 #include "util/logging.h"
-#include "tools/ldb_cmd_execute_result.h"
+#include "util/ldb_cmd_execute_result.h"
 #include "util/string_util.h"
 #include "utilities/utility_db.h"
 #include "utilities/ttl/db_ttl.h"

util/ldb_tool.cc

@@ -3,8 +3,8 @@
 //  LICENSE file in the root directory of this source tree. An additional grant
 //  of patent rights can be found in the PATENTS file in the same directory.
 //
-#include "tools/ldb_tool.h"
+#include "rocksdb/ldb_tool.h"
-#include "tools/ldb_cmd.h"
+#include "util/ldb_cmd.h"
 
 namespace rocksdb {