[RocksJava] Incorporated review comments D28947

main
fyrz 10 years ago
parent 07cd3c42a2
commit 4947a0674f
  1. 5
      java/org/rocksdb/InfoLogLevel.java
  2. 2
      java/org/rocksdb/Options.java

@ -32,6 +32,8 @@ public enum InfoLogLevel {
* @param value byte representation of InfoLogLevel. * @param value byte representation of InfoLogLevel.
* *
* @return {@link org.rocksdb.InfoLogLevel} instance or null. * @return {@link org.rocksdb.InfoLogLevel} instance or null.
* @throws java.lang.IllegalArgumentException if an invalid
* value is provided.
*/ */
public static InfoLogLevel getInfoLogLevel(byte value) { public static InfoLogLevel getInfoLogLevel(byte value) {
for (InfoLogLevel infoLogLevel : InfoLogLevel.values()) { for (InfoLogLevel infoLogLevel : InfoLogLevel.values()) {
@ -39,6 +41,7 @@ public enum InfoLogLevel {
return infoLogLevel; return infoLogLevel;
} }
} }
return null; throw new IllegalArgumentException(
"Illegal value provided for InfoLogLevel.");
} }
} }

@ -604,7 +604,6 @@ public class Options extends RocksObject
@Override @Override
public Options setMemTableConfig(MemTableConfig config) public Options setMemTableConfig(MemTableConfig config)
throws RocksDBException { throws RocksDBException {
assert(isInitialized());
memTableConfig_ = config; memTableConfig_ = config;
setMemTableFactory(nativeHandle_, config.newMemTableFactoryHandle()); setMemTableFactory(nativeHandle_, config.newMemTableFactoryHandle());
return this; return this;
@ -612,7 +611,6 @@ public class Options extends RocksObject
@Override @Override
public Options setRateLimiterConfig(RateLimiterConfig config) { public Options setRateLimiterConfig(RateLimiterConfig config) {
assert(isInitialized());
rateLimiterConfig_ = config; rateLimiterConfig_ = config;
setRateLimiter(nativeHandle_, config.newRateLimiterHandle()); setRateLimiter(nativeHandle_, config.newRateLimiterHandle());
return this; return this;

Loading…
Cancel
Save