Clarify API comments for blob_cache/prepopulate_blob_cache (#10723)

Summary: Pull Request resolved: https://github.com/facebook/rocksdb/pull/10723

Reviewed By: riversand963

Differential Revision: D39749277

Pulled By: ltamasi

fbshipit-source-id: 4bda94b4620a0db1fcd4309c7ad03fc23e8718cb

include/rocksdb/advanced_options.h

@@ -1003,21 +1003,21 @@ struct AdvancedColumnFamilyOptions {
   // Dynamically changeable through the SetOptions() API
   int blob_file_starting_level = 0;
 
-  // This feature is WORK IN PROGRESS
+  // The Cache object to use for blobs. Using a dedicated object for blobs and
-  // If non-NULL use the specified cache for blobs.
+  // using the same object for the block and blob caches are both supported. In
-  // If NULL, rocksdb will not use a blob cache.
+  // the latter case, note that blobs are less valuable from a caching
+  // perspective than SST blocks, and some cache implementations have
+  // configuration options that can be used to prioritize items accordingly (see
+  // Cache::Priority and LRUCacheOptions::{high,low}_pri_pool_ratio).
   //
   // Default: nullptr (disabled)
   std::shared_ptr<Cache> blob_cache = nullptr;
 
-  // If enabled, prepopulate warm/hot blobs which are already in memory into
+  // Enable/disable prepopulating the blob cache. When set to kFlushOnly, BlobDB
-  // blob cache at the time of flush. On a flush, the blob that is in memory (in
+  // will insert newly written blobs into the blob cache during flush. This can
-  // memtables) get flushed to the device. If using Direct IO, additional IO is
+  // improve performance when reading back these blobs would otherwise be
-  // incurred to read this blob back into memory again, which is avoided by
+  // expensive (e.g. when using direct I/O or remote storage), or when the
-  // enabling this option. This further helps if the workload exhibits high
+  // workload has a high temporal locality.
-  // temporal locality, where most of the reads go to recently written data.
-  // This also helps in case of the remote file system since it involves network
-  // traffic and higher latencies.
   //
   // Default: disabled
   //