Modify script which generates TARGETS (#8366)

Summary: Pull Request resolved: https://github.com/facebook/rocksdb/pull/8366

Test Plan: Run it, `TARGETS` now unchanged.

Reviewed By: jay-zhuang

Differential Revision: D28914138

Pulled By: stepancheg

fbshipit-source-id: 04d24cdf1439edf4204a3ba1f646e9e75a00d92b
main
Stepan Koltsov 4 years ago committed by Facebook GitHub Bot
parent 4d5b575563
commit 707f8d168a
  1. 12
      buckifier/targets_cfg.py

@ -17,7 +17,7 @@ load(":defs.bzl", "test_binary")
REPO_PATH = package_name() + "/" REPO_PATH = package_name() + "/"
ROCKSDB_COMPILER_FLAGS = [ ROCKSDB_COMPILER_FLAGS_0 = [
"-fno-builtin-memcmp", "-fno-builtin-memcmp",
# Needed to compile in fbcode # Needed to compile in fbcode
"-Wno-expansion-to-defined", "-Wno-expansion-to-defined",
@ -35,7 +35,7 @@ ROCKSDB_EXTERNAL_DEPS = [
("zstd", None, "zstd"), ("zstd", None, "zstd"),
] ]
ROCKSDB_OS_DEPS = [ ROCKSDB_OS_DEPS_0 = [
( (
"linux", "linux",
["third-party//numa:numa", "third-party//liburing:uring", "third-party//tbb:tbb"], ["third-party//numa:numa", "third-party//liburing:uring", "third-party//tbb:tbb"],
@ -46,7 +46,7 @@ ROCKSDB_OS_DEPS = [
), ),
] ]
ROCKSDB_OS_PREPROCESSOR_FLAGS = [ ROCKSDB_OS_PREPROCESSOR_FLAGS_0 = [
( (
"linux", "linux",
[ [
@ -114,18 +114,18 @@ is_opt_mode = build_mode.startswith("opt")
# -DNDEBUG is added by default in opt mode in fbcode. But adding it twice # -DNDEBUG is added by default in opt mode in fbcode. But adding it twice
# doesn't harm and avoid forgetting to add it. # doesn't harm and avoid forgetting to add it.
ROCKSDB_COMPILER_FLAGS += (["-DNDEBUG"] if is_opt_mode else []) ROCKSDB_COMPILER_FLAGS = ROCKSDB_COMPILER_FLAGS_0 + (["-DNDEBUG"] if is_opt_mode else [])
sanitizer = read_config("fbcode", "sanitizer") sanitizer = read_config("fbcode", "sanitizer")
# Do not enable jemalloc if sanitizer presents. RocksDB will further detect # Do not enable jemalloc if sanitizer presents. RocksDB will further detect
# whether the binary is linked with jemalloc at runtime. # whether the binary is linked with jemalloc at runtime.
ROCKSDB_OS_PREPROCESSOR_FLAGS += ([( ROCKSDB_OS_PREPROCESSOR_FLAGS = ROCKSDB_OS_PREPROCESSOR_FLAGS_0 + ([(
"linux", "linux",
["-DROCKSDB_JEMALLOC"], ["-DROCKSDB_JEMALLOC"],
)] if sanitizer == "" else []) )] if sanitizer == "" else [])
ROCKSDB_OS_DEPS += ([( ROCKSDB_OS_DEPS = ROCKSDB_OS_DEPS_0 + ([(
"linux", "linux",
["third-party//jemalloc:headers"], ["third-party//jemalloc:headers"],
)] if sanitizer == "" else []) )] if sanitizer == "" else [])

Loading…
Cancel
Save