@ -1934,24 +1934,21 @@ Status DBImpl::SetOptions(ColumnFamilyHandle* column_family,
MutableCFOptions new_options ;
MutableCFOptions new_options ;
Status s ;
Status s ;
Status persist_options_status ;
{
{
InstrumentedMutexLock l ( & mutex_ ) ;
InstrumentedMutexLock l ( & mutex_ ) ;
s = cfd - > SetOptions ( options_map ) ;
s = cfd - > SetOptions ( options_map ) ;
if ( s . ok ( ) ) {
if ( s . ok ( ) ) {
new_options = * cfd - > GetLatestMutableCFOptions ( ) ;
new_options = * cfd - > GetLatestMutableCFOptions ( ) ;
}
}
}
if ( s . ok ( ) ) {
if ( s . ok ( ) ) {
Status persist_options_status = WriteOptionsFile ( ) ;
// Persist RocksDB options under the single write thread
if ( ! persist_options_status . ok ( ) ) {
WriteThread : : Writer w ;
if ( db_options_ . fail_if_options_file_error ) {
write_thread_ . EnterUnbatched ( & w , & mutex_ ) ;
s = Status : : IOError (
" SetOptions succeeded, but unable to persist options " ,
persist_options_status = WriteOptionsFile ( ) ;
persist_options_status . ToString ( ) ) ;
}
write_thread_ . ExitUnbatched ( & w ) ;
Warn ( db_options_ . info_log ,
" Unable to persist options in SetOptions() -- %s " ,
persist_options_status . ToString ( ) . c_str ( ) ) ;
}
}
}
}
@ -1967,6 +1964,16 @@ Status DBImpl::SetOptions(ColumnFamilyHandle* column_family,
db_options_ . info_log , " [%s] SetOptions succeeded " ,
db_options_ . info_log , " [%s] SetOptions succeeded " ,
cfd - > GetName ( ) . c_str ( ) ) ;
cfd - > GetName ( ) . c_str ( ) ) ;
new_options . Dump ( db_options_ . info_log . get ( ) ) ;
new_options . Dump ( db_options_ . info_log . get ( ) ) ;
if ( ! persist_options_status . ok ( ) ) {
if ( db_options_ . fail_if_options_file_error ) {
s = Status : : IOError (
" SetOptions succeeded, but unable to persist options " ,
persist_options_status . ToString ( ) ) ;
}
Warn ( db_options_ . info_log ,
" Unable to persist options in SetOptions() -- %s " ,
persist_options_status . ToString ( ) . c_str ( ) ) ;
}
} else {
} else {
Log ( InfoLogLevel : : WARN_LEVEL , db_options_ . info_log ,
Log ( InfoLogLevel : : WARN_LEVEL , db_options_ . info_log ,
" [%s] SetOptions failed " , cfd - > GetName ( ) . c_str ( ) ) ;
" [%s] SetOptions failed " , cfd - > GetName ( ) . c_str ( ) ) ;
@ -3455,6 +3462,7 @@ Status DBImpl::CreateColumnFamily(const ColumnFamilyOptions& cf_options,
const std : : string & column_family_name ,
const std : : string & column_family_name ,
ColumnFamilyHandle * * handle ) {
ColumnFamilyHandle * * handle ) {
Status s ;
Status s ;
Status persist_options_status ;
* handle = nullptr ;
* handle = nullptr ;
s = CheckCompressionSupported ( cf_options ) ;
s = CheckCompressionSupported ( cf_options ) ;
@ -3487,6 +3495,12 @@ Status DBImpl::CreateColumnFamily(const ColumnFamilyOptions& cf_options,
s = versions_ - > LogAndApply (
s = versions_ - > LogAndApply (
nullptr , MutableCFOptions ( opt , ImmutableCFOptions ( opt ) ) , & edit ,
nullptr , MutableCFOptions ( opt , ImmutableCFOptions ( opt ) ) , & edit ,
& mutex_ , directories_ . GetDbDir ( ) , false , & cf_options ) ;
& mutex_ , directories_ . GetDbDir ( ) , false , & cf_options ) ;
if ( s . ok ( ) ) {
// If the column family was created successfully, we then persist
// the updated RocksDB options under the same single write thread
persist_options_status = WriteOptionsFile ( ) ;
}
write_thread_ . ExitUnbatched ( & w ) ;
write_thread_ . ExitUnbatched ( & w ) ;
}
}
if ( s . ok ( ) ) {
if ( s . ok ( ) ) {
@ -3514,7 +3528,8 @@ Status DBImpl::CreateColumnFamily(const ColumnFamilyOptions& cf_options,
// this is outside the mutex
// this is outside the mutex
if ( s . ok ( ) ) {
if ( s . ok ( ) ) {
Status persist_options_status = WriteOptionsFile ( ) ;
NewThreadStatusCfInfo (
reinterpret_cast < ColumnFamilyHandleImpl * > ( * handle ) - > cfd ( ) ) ;
if ( ! persist_options_status . ok ( ) ) {
if ( ! persist_options_status . ok ( ) ) {
if ( db_options_ . fail_if_options_file_error ) {
if ( db_options_ . fail_if_options_file_error ) {
s = Status : : IOError (
s = Status : : IOError (
@ -3526,8 +3541,6 @@ Status DBImpl::CreateColumnFamily(const ColumnFamilyOptions& cf_options,
" Unable to persist options in CreateColumnFamily() -- %s " ,
" Unable to persist options in CreateColumnFamily() -- %s " ,
persist_options_status . ToString ( ) . c_str ( ) ) ;
persist_options_status . ToString ( ) . c_str ( ) ) ;
}
}
NewThreadStatusCfInfo (
reinterpret_cast < ColumnFamilyHandleImpl * > ( * handle ) - > cfd ( ) ) ;
}
}
return s ;
return s ;
}
}
@ -3546,6 +3559,7 @@ Status DBImpl::DropColumnFamily(ColumnFamilyHandle* column_family) {
edit . SetColumnFamily ( cfd - > GetID ( ) ) ;
edit . SetColumnFamily ( cfd - > GetID ( ) ) ;
Status s ;
Status s ;
Status options_persist_status ;
{
{
InstrumentedMutexLock l ( & mutex_ ) ;
InstrumentedMutexLock l ( & mutex_ ) ;
if ( cfd - > IsDropped ( ) ) {
if ( cfd - > IsDropped ( ) ) {
@ -3557,6 +3571,11 @@ Status DBImpl::DropColumnFamily(ColumnFamilyHandle* column_family) {
write_thread_ . EnterUnbatched ( & w , & mutex_ ) ;
write_thread_ . EnterUnbatched ( & w , & mutex_ ) ;
s = versions_ - > LogAndApply ( cfd , * cfd - > GetLatestMutableCFOptions ( ) ,
s = versions_ - > LogAndApply ( cfd , * cfd - > GetLatestMutableCFOptions ( ) ,
& edit , & mutex_ ) ;
& edit , & mutex_ ) ;
if ( s . ok ( ) ) {
// If the column family was dropped successfully, we then persist
// the updated RocksDB options under the same single write thread
options_persist_status = WriteOptionsFile ( ) ;
}
write_thread_ . ExitUnbatched ( & w ) ;
write_thread_ . ExitUnbatched ( & w ) ;
}
}
@ -3583,7 +3602,9 @@ Status DBImpl::DropColumnFamily(ColumnFamilyHandle* column_family) {
auto * mutable_cf_options = cfd - > GetLatestMutableCFOptions ( ) ;
auto * mutable_cf_options = cfd - > GetLatestMutableCFOptions ( ) ;
max_total_in_memory_state_ - = mutable_cf_options - > write_buffer_size *
max_total_in_memory_state_ - = mutable_cf_options - > write_buffer_size *
mutable_cf_options - > max_write_buffer_number ;
mutable_cf_options - > max_write_buffer_number ;
auto options_persist_status = WriteOptionsFile ( ) ;
Log ( InfoLogLevel : : INFO_LEVEL , db_options_ . info_log ,
" Dropped column family with id %u \n " , cfd - > GetID ( ) ) ;
if ( ! options_persist_status . ok ( ) ) {
if ( ! options_persist_status . ok ( ) ) {
if ( db_options_ . fail_if_options_file_error ) {
if ( db_options_ . fail_if_options_file_error ) {
s = Status : : IOError (
s = Status : : IOError (
@ -3595,9 +3616,6 @@ Status DBImpl::DropColumnFamily(ColumnFamilyHandle* column_family) {
" Unable to persist options in DropColumnFamily() -- %s " ,
" Unable to persist options in DropColumnFamily() -- %s " ,
options_persist_status . ToString ( ) . c_str ( ) ) ;
options_persist_status . ToString ( ) . c_str ( ) ) ;
}
}
Log ( InfoLogLevel : : INFO_LEVEL , db_options_ . info_log ,
" Dropped column family with id %u \n " ,
cfd - > GetID ( ) ) ;
} else {
} else {
Log ( InfoLogLevel : : ERROR_LEVEL , db_options_ . info_log ,
Log ( InfoLogLevel : : ERROR_LEVEL , db_options_ . info_log ,
" Dropping column family with id %u FAILED -- %s \n " ,
" Dropping column family with id %u FAILED -- %s \n " ,
@ -5040,7 +5058,12 @@ Status DB::Open(const DBOptions& db_options, const std::string& dbname,
}
}
}
}
TEST_SYNC_POINT ( " DBImpl::Open:Opened " ) ;
TEST_SYNC_POINT ( " DBImpl::Open:Opened " ) ;
Status persist_options_status ;
if ( s . ok ( ) ) {
if ( s . ok ( ) ) {
// Persist RocksDB Options before scheduling the compaction.
// The WriteOptionsFile() will release and lock the mutex internally.
persist_options_status = impl - > WriteOptionsFile ( ) ;
* dbptr = impl ;
* dbptr = impl ;
impl - > opened_successfully_ = true ;
impl - > opened_successfully_ = true ;
impl - > MaybeScheduleFlushOrCompaction ( ) ;
impl - > MaybeScheduleFlushOrCompaction ( ) ;
@ -5051,8 +5074,6 @@ Status DB::Open(const DBOptions& db_options, const std::string& dbname,
Log ( InfoLogLevel : : INFO_LEVEL , impl - > db_options_ . info_log , " DB pointer %p " ,
Log ( InfoLogLevel : : INFO_LEVEL , impl - > db_options_ . info_log , " DB pointer %p " ,
impl ) ;
impl ) ;
LogFlush ( impl - > db_options_ . info_log ) ;
LogFlush ( impl - > db_options_ . info_log ) ;
auto persist_options_status = impl - > WriteOptionsFile ( ) ;
if ( ! persist_options_status . ok ( ) ) {
if ( ! persist_options_status . ok ( ) ) {
if ( db_options . fail_if_options_file_error ) {
if ( db_options . fail_if_options_file_error ) {
s = Status : : IOError (
s = Status : : IOError (
@ -5181,24 +5202,11 @@ Status DestroyDB(const std::string& dbname, const Options& options) {
Status DBImpl : : WriteOptionsFile ( ) {
Status DBImpl : : WriteOptionsFile ( ) {
# ifndef ROCKSDB_LITE
# ifndef ROCKSDB_LITE
std : : string file_name ;
mutex_ . AssertHeld ( ) ;
Status s = WriteOptionsToTempFile ( & file_name ) ;
if ( ! s . ok ( ) ) {
return s ;
}
s = RenameTempFileToOptionsFile ( file_name ) ;
return s ;
# else
return Status : : OK ( ) ;
# endif // !ROCKSDB_LITE
}
Status DBImpl : : WriteOptionsToTempFile ( std : : string * file_name ) {
# ifndef ROCKSDB_LITE
std : : vector < std : : string > cf_names ;
std : : vector < std : : string > cf_names ;
std : : vector < ColumnFamilyOptions > cf_opts ;
std : : vector < ColumnFamilyOptions > cf_opts ;
{
InstrumentedMutexLock l ( & mutex_ ) ;
// This part requires mutex to protect the column family options
// This part requires mutex to protect the column family options
for ( auto cfd : * versions_ - > GetColumnFamilySet ( ) ) {
for ( auto cfd : * versions_ - > GetColumnFamilySet ( ) ) {
if ( cfd - > IsDropped ( ) ) {
if ( cfd - > IsDropped ( ) ) {
@ -5208,11 +5216,20 @@ Status DBImpl::WriteOptionsToTempFile(std::string* file_name) {
cf_opts . push_back ( BuildColumnFamilyOptions (
cf_opts . push_back ( BuildColumnFamilyOptions (
* cfd - > options ( ) , * cfd - > GetLatestMutableCFOptions ( ) ) ) ;
* cfd - > options ( ) , * cfd - > GetLatestMutableCFOptions ( ) ) ) ;
}
}
}
* file_name = TempOptionsFileName ( GetName ( ) , versions_ - > NewFileNumber ( ) ) ;
Status s = PersistRocksDBOptions ( GetDBOptions ( ) , cf_names , cf_opts ,
// Unlock during expensive operations. New writes cannot get here
* file_name , GetEnv ( ) ) ;
// because the single write thread ensures all new writes get queued.
mutex_ . Unlock ( ) ;
std : : string file_name =
TempOptionsFileName ( GetName ( ) , versions_ - > NewFileNumber ( ) ) ;
Status s = PersistRocksDBOptions ( GetDBOptions ( ) , cf_names , cf_opts , file_name ,
GetEnv ( ) ) ;
if ( s . ok ( ) ) {
s = RenameTempFileToOptionsFile ( file_name ) ;
}
mutex_ . Lock ( ) ;
return s ;
return s ;
# else
# else
return Status : : OK ( ) ;
return Status : : OK ( ) ;
@ -5240,8 +5257,6 @@ void DeleteOptionsFilesHelper(const std::map<uint64_t, std::string>& filenames,
Status DBImpl : : DeleteObsoleteOptionsFiles ( ) {
Status DBImpl : : DeleteObsoleteOptionsFiles ( ) {
# ifndef ROCKSDB_LITE
# ifndef ROCKSDB_LITE
options_files_mutex_ . AssertHeld ( ) ;
std : : vector < std : : string > filenames ;
std : : vector < std : : string > filenames ;
// use ordered map to store keep the filenames sorted from the newest
// use ordered map to store keep the filenames sorted from the newest
// to the oldest.
// to the oldest.
@ -5273,7 +5288,6 @@ Status DBImpl::DeleteObsoleteOptionsFiles() {
Status DBImpl : : RenameTempFileToOptionsFile ( const std : : string & file_name ) {
Status DBImpl : : RenameTempFileToOptionsFile ( const std : : string & file_name ) {
# ifndef ROCKSDB_LITE
# ifndef ROCKSDB_LITE
InstrumentedMutexLock l ( & options_files_mutex_ ) ;
Status s ;
Status s ;
std : : string options_file_name =
std : : string options_file_name =
OptionsFileName ( GetName ( ) , versions_ - > NewFileNumber ( ) ) ;
OptionsFileName ( GetName ( ) , versions_ - > NewFileNumber ( ) ) ;