Remove unused Blob WAL filter (#4896)

Summary:
Remove unused blob WAL filter so that users are not confused.
I was initially under the impression that we have WAL Filter support in BlobDB.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/4896

Differential Revision: D13725709

Pulled By: sagar0

fbshipit-source-id: f997d7546e138a474036e88b957907cc714327f1
main
Sagar Vemuri 6 years ago committed by Facebook Github Bot
parent ce8e88d2d7
commit 8189c184ec
  1. 7
      utilities/blob_db/blob_db_impl.cc
  2. 15
      utilities/blob_db/blob_db_impl.h

@ -45,13 +45,6 @@ int kBlockBasedTableVersionFormat = 2;
namespace rocksdb { namespace rocksdb {
namespace blob_db { namespace blob_db {
WalFilter::WalProcessingOption BlobReconcileWalFilter::LogRecordFound(
unsigned long long /*log_number*/, const std::string& /*log_file_name*/,
const WriteBatch& /*batch*/, WriteBatch* /*new_batch*/,
bool* /*batch_changed*/) {
return WalFilter::WalProcessingOption::kContinueProcessing;
}
bool BlobFileComparator::operator()( bool BlobFileComparator::operator()(
const std::shared_ptr<BlobFile>& lhs, const std::shared_ptr<BlobFile>& lhs,
const std::shared_ptr<BlobFile>& rhs) const { const std::shared_ptr<BlobFile>& rhs) const {

@ -47,21 +47,6 @@ struct BlobCompactionContext;
class BlobDBImpl; class BlobDBImpl;
class BlobFile; class BlobFile;
// this implements the callback from the WAL which ensures that the
// blob record is present in the blob log. If fsync/fdatasync in not
// happening on every write, there is the probability that keys in the
// blob log can lag the keys in blobs
// TODO(yiwu): implement the WAL filter.
class BlobReconcileWalFilter : public WalFilter {
public:
virtual WalFilter::WalProcessingOption LogRecordFound(
unsigned long long log_number, const std::string& log_file_name,
const WriteBatch& batch, WriteBatch* new_batch,
bool* batch_changed) override;
virtual const char* Name() const override { return "BlobDBWalReconciler"; }
};
// Comparator to sort "TTL" aware Blob files based on the lower value of // Comparator to sort "TTL" aware Blob files based on the lower value of
// TTL range. // TTL range.
struct BlobFileComparatorTTL { struct BlobFileComparatorTTL {

Loading…
Cancel
Save