NextGraph
/
rocksdb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make DBTest.ReadLatencyHistogramByLevel more robust

Browse Source 
Summary: DBTest.ReadLatencyHistogramByLevel was not written as expected. After writes, reads aren't guaranteed to hit data written. It was not expected. Fix it.

Test Plan: Run the test multiple times

Reviewers: IslamAbdelRahman, rven, anthony, kradhakrishnan, yhchiang, igor

Reviewed By: igor

Subscribers: leveldb, dhruba

Differential Revision: https://reviews.facebook.net/D46587
main
sdong 9 years ago
parent ac9bcb55ce
commit abc7f5fdb2
1 changed files with 5 additions and 4 deletions
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Show Stats Download Patch File Download Diff File
  1. 9
      db/db_test.cc

9
db/db_test.cc
Unescape View File

@ -614,17 +614,18 @@ TEST_F(DBTest, ReadLatencyHistogramByLevel) {
table_options.no_block_cache = true; table_options.no_block_cache = true;
DestroyAndReopen(options); DestroyAndReopen(options);
int key_index = 0;
Random rnd(301); Random rnd(301);
for (int num = 0; num < 5; num++) { for (int num = 0; num < 5; num++) {
Put("foo", "bar"); Put("foo", "bar");
GenerateNewRandomFile(&rnd); GenerateNewFile(&rnd, &key_index);
} }
std::string prop; std::string prop;
ASSERT_TRUE(dbfull()->GetProperty("rocksdb.dbstats", &prop)); ASSERT_TRUE(dbfull()->GetProperty("rocksdb.dbstats", &prop));
// Get() after flushes, See latency histogram tracked. // Get() after flushes, See latency histogram tracked.
for (int key = 0; key < 50; key++) { for (int key = 0; key < 500; key++) {
Get(Key(key)); Get(Key(key));
} }
ASSERT_TRUE(dbfull()->GetProperty("rocksdb.dbstats", &prop)); ASSERT_TRUE(dbfull()->GetProperty("rocksdb.dbstats", &prop));
@ -634,7 +635,7 @@ TEST_F(DBTest, ReadLatencyHistogramByLevel) {
// Reopen and issue Get(). See thee latency tracked // Reopen and issue Get(). See thee latency tracked
Reopen(options); Reopen(options);
for (int key = 0; key < 50; key++) { for (int key = 0; key < 500; key++) {
Get(Key(key)); Get(Key(key));
} }
ASSERT_TRUE(dbfull()->GetProperty("rocksdb.dbstats", &prop)); ASSERT_TRUE(dbfull()->GetProperty("rocksdb.dbstats", &prop));
@ -665,7 +666,7 @@ TEST_F(DBTest, ReadLatencyHistogramByLevel) {
ASSERT_NE(std::string::npos, prop.find("** Level 0 read latency histogram")); ASSERT_NE(std::string::npos, prop.find("** Level 0 read latency histogram"));
ASSERT_NE(std::string::npos, prop.find("** Level 1 read latency histogram")); ASSERT_NE(std::string::npos, prop.find("** Level 1 read latency histogram"));
ASSERT_EQ(std::string::npos, prop.find("** Level 2 read latency histogram")); ASSERT_EQ(std::string::npos, prop.find("** Level 2 read latency histogram"));
for (int key = 0; key < 50; key++) { for (int key = 0; key < 500; key++) {
Get(Key(key)); Get(Key(key));
} }
ASSERT_TRUE(dbfull()->GetProperty("rocksdb.dbstats", &prop)); ASSERT_TRUE(dbfull()->GetProperty("rocksdb.dbstats", &prop));

Write Preview
Loading…
Cancel
Save