Work around snappy linker issue with newer compilers (#9517)

Summary:
After https://github.com/facebook/rocksdb/issues/9481, we are using newer default compiler for
build-format-compatible CircleCI nightly job, which fails on building
2.2.fb.branch branch because it tries to use a pre-compiled libsnappy.a
that is checked into the repo (!). This works around that by setting
SNAPPY_LDFLAGS=-lsnappy, which is only understood by such old versions.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/9517

Test Plan:
Run check_format_compatible.sh on Ubuntu 20 AWS machine,
watch nightly run

Reviewed By: hx235

Differential Revision: D34055561

Pulled By: pdillinger

fbshipit-source-id: 45f9d428dd082f026773bfa8d9dd4dad66fc9378
main
Peter Dillinger 3 years ago committed by Facebook GitHub Bot
parent 5cb137a860
commit d7c868b062
  1. 4
      tools/check_format_compatible.sh

@ -45,6 +45,10 @@ else
fi fi
git fetch $tmp_origin git fetch $tmp_origin
# Used in building some ancient RocksDB versions where by default it tries to
# use a precompiled libsnappy.a checked in to the repo.
export SNAPPY_LDFLAGS=-lsnappy
cleanup() { cleanup() {
echo "== Cleaning up" echo "== Cleaning up"
git reset --hard || true git reset --hard || true

Loading…
Cancel
Save