NextGraph
/
rocksdb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove flaky servicelab metrics DBPut P95/P99 (#9844)

Browse Source 
Summary:
The P95 and P99 metrics are flaky, similar to DBGet ones which removed
in https://github.com/facebook/rocksdb/issues/9742 .

Pull Request resolved: https://github.com/facebook/rocksdb/pull/9844

Test Plan: `$ ./buckifier/buckify_rocksdb.py`

Reviewed By: ajkr

Differential Revision: D35655531

Pulled By: jay-zhuang

fbshipit-source-id: c1409f0fba4e23d461a65f988c27ac5e2ae85d13
main
Jay Zhuang 2 years ago committed by Facebook GitHub Bot
parent 082eb04200
commit e91ec64cac
4 changed files with 7726 additions and 7851 deletions
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Show Stats Download Patch File Download Diff File
  1. 54
      TARGETS
  2. 48
      buckifier/bench-slow.json
  3. 24
      buckifier/bench.json
  4. 1
      buckifier/buckify_rocksdb.py

54
TARGETS
Unescape View File

@ -713,9 +713,7 @@ fancy_bench_wrapper(suite_name="rocksdb_microbench_suite_0", binary_to_bench_to_
'DBPut/comp_style:1/max_data:107374182400/per_key_size:256/enable_statistics:1/wal:1/iterations:51200/threads:8': ['real_time',
'put_mean',
'cpu_time',
'put_p99',
'db_size',
'put_p95',
'threads'],
'DBPut/comp_style:2/max_data:107374182400/per_key_size:256/enable_statistics:0/wal:0/iterations:51200/threads:8': ['real_time',
'cpu_time',
@ -771,16 +769,12 @@ fancy_bench_wrapper(suite_name="rocksdb_microbench_suite_1", binary_to_bench_to_
'DBPut/comp_style:2/max_data:107374182400/per_key_size:256/enable_statistics:1/wal:0/iterations:409600/threads:1': ['real_time',
'put_mean',
'cpu_time',
'put_p99',
'db_size',
'put_p95',
'threads'],
'DBPut/comp_style:2/max_data:107374182400/per_key_size:256/enable_statistics:1/wal:1/iterations:51200/threads:8': ['real_time',
'put_mean',
'cpu_time',
'put_p99',
'db_size',
'put_p95',
'threads']},
'ribbon_bench': {'FilterBuild/filter_impl:2/bits_per_key:20/key_len_avg:100/entry_num:1024': ['real_time',
'cpu_time',
@ -1020,9 +1014,7 @@ fancy_bench_wrapper(suite_name="rocksdb_microbench_suite_6", binary_to_bench_to_
'DBPut/comp_style:2/max_data:107374182400/per_key_size:256/enable_statistics:1/wal:0/iterations:51200/threads:8': ['real_time',
'put_mean',
'cpu_time',
'put_p99',
'db_size',
'put_p95',
'threads']},
'ribbon_bench': {'FilterBuild/filter_impl:2/bits_per_key:10/key_len_avg:100/entry_num:1024': ['real_time',
'cpu_time',
@ -1061,16 +1053,12 @@ fancy_bench_wrapper(suite_name="rocksdb_microbench_suite_7", binary_to_bench_to_
'DBPut/comp_style:0/max_data:107374182400/per_key_size:256/enable_statistics:1/wal:0/iterations:51200/threads:8': ['real_time',
'put_mean',
'cpu_time',
'put_p99',
'db_size',
'put_p95',
'threads'],
'DBPut/comp_style:1/max_data:107374182400/per_key_size:256/enable_statistics:1/wal:1/iterations:409600/threads:1': ['real_time',
'put_mean',
'cpu_time',
'put_p99',
'db_size',
'put_p95',
'threads'],
'RandomAccessFileReaderRead/enable_statistics:0/iterations:1000000': ['real_time',
'cpu_time',
@ -1115,9 +1103,7 @@ fancy_bench_wrapper(suite_name="rocksdb_microbench_suite_8", binary_to_bench_to_
'DBPut/comp_style:2/max_data:107374182400/per_key_size:256/enable_statistics:1/wal:1/iterations:409600/threads:1': ['real_time',
'put_mean',
'cpu_time',
'put_p99',
'db_size',
'put_p95',
'threads']},
'ribbon_bench': {'FilterBuild/filter_impl:0/bits_per_key:20/key_len_avg:10/entry_num:1048576': ['real_time',
'cpu_time',
@ -1211,9 +1197,7 @@ fancy_bench_wrapper(suite_name="rocksdb_microbench_suite_10", binary_to_bench_to
'DBPut/comp_style:0/max_data:107374182400/per_key_size:256/enable_statistics:1/wal:1/iterations:409600/threads:1': ['real_time',
'put_mean',
'cpu_time',
'put_p99',
'db_size',
'put_p95',
'threads']},
'ribbon_bench': {'FilterBuild/filter_impl:3/bits_per_key:10/key_len_avg:10/entry_num:1024': ['real_time',
'cpu_time',
@ -1245,16 +1229,12 @@ fancy_bench_wrapper(suite_name="rocksdb_microbench_suite_11", binary_to_bench_to
'DBPut/comp_style:1/max_data:107374182400/per_key_size:256/enable_statistics:1/wal:0/iterations:409600/threads:1': ['real_time',
'put_mean',
'cpu_time',
'put_p99',
'db_size',
'put_p95',
'threads'],
'DBPut/comp_style:1/max_data:107374182400/per_key_size:256/enable_statistics:1/wal:0/iterations:51200/threads:8': ['real_time',
'put_mean',
'cpu_time',
'put_p99',
'db_size',
'put_p95',
'threads']}}, slow=False, expected_runtime=2446, sl_iterations=3, regression_threshold=10)
@ -1339,9 +1319,7 @@ fancy_bench_wrapper(suite_name="rocksdb_microbench_suite_13", binary_to_bench_to
'DBPut/comp_style:0/max_data:107374182400/per_key_size:256/enable_statistics:1/wal:0/iterations:409600/threads:1': ['real_time',
'put_mean',
'cpu_time',
'put_p99',
'db_size',
'put_p95',
'threads']},
'ribbon_bench': {'FilterBuild/filter_impl:2/bits_per_key:20/key_len_avg:100/entry_num:1048576': ['real_time',
'cpu_time',
@ -1382,9 +1360,7 @@ fancy_bench_wrapper(suite_name="rocksdb_microbench_suite_14", binary_to_bench_to
'DBPut/comp_style:0/max_data:107374182400/per_key_size:256/enable_statistics:1/wal:1/iterations:51200/threads:8': ['real_time',
'put_mean',
'cpu_time',
'put_p99',
'db_size',
'put_p95',
'threads']},
'ribbon_bench': {'FilterBuild/filter_impl:0/bits_per_key:10/key_len_avg:10/entry_num:1024': ['real_time',
'cpu_time',
@ -1483,9 +1459,7 @@ fancy_bench_wrapper(suite_name="rocksdb_microbench_suite_0_slow", binary_to_benc
'DBPut/comp_style:1/max_data:107374182400/per_key_size:256/enable_statistics:1/wal:0/iterations:409600/threads:1': ['real_time',
'put_mean',
'cpu_time',
'put_p99',
'db_size',
'put_p95',
'threads'],
'IteratorPrev/comp_style:1/max_data:536870912/per_key_size:256/iterations:10240': ['real_time',
'cpu_time',
@ -1706,9 +1680,7 @@ fancy_bench_wrapper(suite_name="rocksdb_microbench_suite_1_slow", binary_to_benc
'DBPut/comp_style:1/max_data:107374182400/per_key_size:256/enable_statistics:1/wal:0/iterations:409600/threads:1': ['real_time',
'put_mean',
'cpu_time',
'put_p99',
'db_size',
'put_p95',
'threads'],
'IteratorPrev/comp_style:1/max_data:536870912/per_key_size:256/iterations:10240': ['real_time',
'cpu_time',
@ -1929,9 +1901,7 @@ fancy_bench_wrapper(suite_name="rocksdb_microbench_suite_2_slow", binary_to_benc
'DBPut/comp_style:1/max_data:107374182400/per_key_size:256/enable_statistics:1/wal:0/iterations:409600/threads:1': ['real_time',
'put_mean',
'cpu_time',
'put_p99',
'db_size',
'put_p95',
'threads'],
'IteratorPrev/comp_style:1/max_data:536870912/per_key_size:256/iterations:10240': ['real_time',
'cpu_time',
@ -2152,9 +2122,7 @@ fancy_bench_wrapper(suite_name="rocksdb_microbench_suite_3_slow", binary_to_benc
'DBPut/comp_style:1/max_data:107374182400/per_key_size:256/enable_statistics:1/wal:0/iterations:409600/threads:1': ['real_time',
'put_mean',
'cpu_time',
'put_p99',
'db_size',
'put_p95',
'threads'],
'IteratorPrev/comp_style:1/max_data:536870912/per_key_size:256/iterations:10240': ['real_time',
'cpu_time',
@ -2375,9 +2343,7 @@ fancy_bench_wrapper(suite_name="rocksdb_microbench_suite_4_slow", binary_to_benc
'DBPut/comp_style:1/max_data:107374182400/per_key_size:256/enable_statistics:1/wal:0/iterations:409600/threads:1': ['real_time',
'put_mean',
'cpu_time',
'put_p99',
'db_size',
'put_p95',
'threads'],
'IteratorPrev/comp_style:1/max_data:536870912/per_key_size:256/iterations:10240': ['real_time',
'cpu_time',
@ -2598,9 +2564,7 @@ fancy_bench_wrapper(suite_name="rocksdb_microbench_suite_5_slow", binary_to_benc
'DBPut/comp_style:1/max_data:107374182400/per_key_size:256/enable_statistics:1/wal:0/iterations:409600/threads:1': ['real_time',
'put_mean',
'cpu_time',
'put_p99',
'db_size',
'put_p95',
'threads'],
'IteratorPrev/comp_style:1/max_data:536870912/per_key_size:256/iterations:10240': ['real_time',
'cpu_time',
@ -2821,9 +2785,7 @@ fancy_bench_wrapper(suite_name="rocksdb_microbench_suite_6_slow", binary_to_benc
'DBPut/comp_style:1/max_data:107374182400/per_key_size:256/enable_statistics:1/wal:0/iterations:409600/threads:1': ['real_time',
'put_mean',
'cpu_time',
'put_p99',
'db_size',
'put_p95',
'threads'],
'IteratorPrev/comp_style:1/max_data:536870912/per_key_size:256/iterations:10240': ['real_time',
'cpu_time',
@ -3044,9 +3006,7 @@ fancy_bench_wrapper(suite_name="rocksdb_microbench_suite_7_slow", binary_to_benc
'DBPut/comp_style:1/max_data:107374182400/per_key_size:256/enable_statistics:1/wal:0/iterations:409600/threads:1': ['real_time',
'put_mean',
'cpu_time',
'put_p99',
'db_size',
'put_p95',
'threads'],
'IteratorPrev/comp_style:1/max_data:536870912/per_key_size:256/iterations:10240': ['real_time',
'cpu_time',
@ -3267,9 +3227,7 @@ fancy_bench_wrapper(suite_name="rocksdb_microbench_suite_8_slow", binary_to_benc
'DBPut/comp_style:1/max_data:107374182400/per_key_size:256/enable_statistics:1/wal:0/iterations:409600/threads:1': ['real_time',
'put_mean',
'cpu_time',
'put_p99',
'db_size',
'put_p95',
'threads'],
'IteratorPrev/comp_style:1/max_data:536870912/per_key_size:256/iterations:10240': ['real_time',
'cpu_time',
@ -3490,9 +3448,7 @@ fancy_bench_wrapper(suite_name="rocksdb_microbench_suite_9_slow", binary_to_benc
'DBPut/comp_style:1/max_data:107374182400/per_key_size:256/enable_statistics:1/wal:0/iterations:409600/threads:1': ['real_time',
'put_mean',
'cpu_time',
'put_p99',
'db_size',
'put_p95',
'threads'],
'IteratorPrev/comp_style:1/max_data:536870912/per_key_size:256/iterations:10240': ['real_time',
'cpu_time',
@ -3713,9 +3669,7 @@ fancy_bench_wrapper(suite_name="rocksdb_microbench_suite_10_slow", binary_to_ben
'DBPut/comp_style:1/max_data:107374182400/per_key_size:256/enable_statistics:1/wal:0/iterations:409600/threads:1': ['real_time',
'put_mean',
'cpu_time',
'put_p99',
'db_size',
'put_p95',
'threads'],
'IteratorPrev/comp_style:1/max_data:536870912/per_key_size:256/iterations:10240': ['real_time',
'cpu_time',
@ -3936,9 +3890,7 @@ fancy_bench_wrapper(suite_name="rocksdb_microbench_suite_11_slow", binary_to_ben
'DBPut/comp_style:1/max_data:107374182400/per_key_size:256/enable_statistics:1/wal:0/iterations:409600/threads:1': ['real_time',
'put_mean',
'cpu_time',
'put_p99',
'db_size',
'put_p95',
'threads'],
'IteratorPrev/comp_style:1/max_data:536870912/per_key_size:256/iterations:10240': ['real_time',
'cpu_time',
@ -4159,9 +4111,7 @@ fancy_bench_wrapper(suite_name="rocksdb_microbench_suite_12_slow", binary_to_ben
'DBPut/comp_style:1/max_data:107374182400/per_key_size:256/enable_statistics:1/wal:0/iterations:409600/threads:1': ['real_time',
'put_mean',
'cpu_time',
'put_p99',
'db_size',
'put_p95',
'threads'],
'IteratorPrev/comp_style:1/max_data:536870912/per_key_size:256/iterations:10240': ['real_time',
'cpu_time',
@ -4382,9 +4332,7 @@ fancy_bench_wrapper(suite_name="rocksdb_microbench_suite_13_slow", binary_to_ben
'DBPut/comp_style:1/max_data:107374182400/per_key_size:256/enable_statistics:1/wal:0/iterations:409600/threads:1': ['real_time',
'put_mean',
'cpu_time',
'put_p99',
'db_size',
'put_p95',
'threads'],
'IteratorPrev/comp_style:1/max_data:536870912/per_key_size:256/iterations:10240': ['real_time',
'cpu_time',
@ -4605,9 +4553,7 @@ fancy_bench_wrapper(suite_name="rocksdb_microbench_suite_14_slow", binary_to_ben
'DBPut/comp_style:1/max_data:107374182400/per_key_size:256/enable_statistics:1/wal:0/iterations:409600/threads:1': ['real_time',
'put_mean',
'cpu_time',
'put_p99',
'db_size',
'put_p95',
'threads'],
'IteratorPrev/comp_style:1/max_data:536870912/per_key_size:256/iterations:10240': ['real_time',
'cpu_time',

48
buckifier/bench-slow.json
Unescape View File

@ -133,9 +133,7 @@
"real_time",
"put_mean",
"cpu_time",
"put_p99",
"db_size",
"put_p95",
"threads",
{
"est_runtime": 360.304737
@ -154,9 +152,7 @@
"real_time",
"put_mean",
"cpu_time",
"put_p99",
"db_size",
"put_p95",
"threads",
{
"est_runtime": 379.059546
@ -492,9 +488,7 @@
"real_time",
"put_mean",
"cpu_time",
"put_p99",
"db_size",
"put_p95",
"threads",
{
"est_runtime": 378.530036
@ -504,9 +498,7 @@
"real_time",
"put_mean",
"cpu_time",
"put_p99",
"db_size",
"put_p95",
"threads",
{
"est_runtime": 2153.984468
@ -525,9 +517,7 @@
"real_time",
"put_mean",
"cpu_time",
"put_p99",
"db_size",
"put_p95",
"threads",
{
"est_runtime": 271.474125
@ -892,9 +882,7 @@
"real_time",
"put_mean",
"cpu_time",
"put_p99",
"db_size",
"put_p95",
"threads",
{
"est_runtime": 378.808772
@ -1260,9 +1248,7 @@
"real_time",
"put_mean",
"cpu_time",
"put_p99",
"db_size",
"put_p95",
"threads",
{
"est_runtime": 360.330841
@ -1272,9 +1258,7 @@
"real_time",
"put_mean",
"cpu_time",
"put_p99",
"db_size",
"put_p95",
"threads",
{
"est_runtime": 2423.955419
@ -1643,9 +1627,7 @@
"real_time",
"put_mean",
"cpu_time",
"put_p99",
"db_size",
"put_p95",
"threads",
{
"est_runtime": 271.438709
@ -1655,9 +1637,7 @@
"real_time",
"put_mean",
"cpu_time",
"put_p99",
"db_size",
"put_p95",
"threads",
{
"est_runtime": 2149.877539
@ -2005,9 +1985,7 @@
"real_time",
"put_mean",
"cpu_time",
"put_p99",
"db_size",
"put_p95",
"threads",
{
"est_runtime": 378.81272
@ -2017,9 +1995,7 @@
"real_time",
"put_mean",
"cpu_time",
"put_p99",
"db_size",
"put_p95",
"threads",
{
"est_runtime": 2157.656253
@ -2029,9 +2005,7 @@
"real_time",
"put_mean",
"cpu_time",
"put_p99",
"db_size",
"put_p95",
"threads",
{
"est_runtime": 271.523747
@ -2339,9 +2313,7 @@
"real_time",
"put_mean",
"cpu_time",
"put_p99",
"db_size",
"put_p95",
"threads",
{
"est_runtime": 2201.425905
@ -2351,9 +2323,7 @@
"real_time",
"put_mean",
"cpu_time",
"put_p99",
"db_size",
"put_p95",
"threads",
{
"est_runtime": 2153.250796
@ -3094,9 +3064,7 @@
"real_time",
"put_mean",
"cpu_time",
"put_p99",
"db_size",
"put_p95",
"threads",
{
"est_runtime": 2473.029062
@ -4065,9 +4033,7 @@
"real_time",
"put_mean",
"cpu_time",
"put_p99",
"db_size",
"put_p95",
"threads",
{
"est_runtime": 2473.313812
@ -4077,9 +4043,7 @@
"real_time",
"put_mean",
"cpu_time",
"put_p99",
"db_size",
"put_p95",
"threads",
{
"est_runtime": 2167.374891
@ -4089,9 +4053,7 @@
"real_time",
"put_mean",
"cpu_time",
"put_p99",
"db_size",
"put_p95",
"threads",
{
"est_runtime": 2350.198115
@ -4110,9 +4072,7 @@
"real_time",
"put_mean",
"cpu_time",
"put_p99",
"db_size",
"put_p95",
"threads",
{
"est_runtime": 378.072129
@ -4942,9 +4902,7 @@
"real_time",
"put_mean",
"cpu_time",
"put_p99",
"db_size",
"put_p95",
"threads",
{
"est_runtime": 2312.17547
@ -4954,9 +4912,7 @@
"real_time",
"put_mean",
"cpu_time",
"put_p99",
"db_size",
"put_p95",
"threads",
{
"est_runtime": 2199.255566
@ -5440,9 +5396,7 @@
"real_time",
"put_mean",
"cpu_time",
"put_p99",
"db_size",
"put_p95",
"threads",
{
"est_runtime": 360.424861
@ -5878,9 +5832,7 @@
"real_time",
"put_mean",
"cpu_time",
"put_p99",
"db_size",
"put_p95",
"threads",
{
"est_runtime": 377.714354

24
buckifier/bench.json
Unescape View File

@ -38,9 +38,7 @@
"real_time",
"put_mean",
"cpu_time",
"put_p99",
"db_size",
"put_p95",
"threads",
{
"est_runtime": 271.438709
@ -172,9 +170,7 @@
"real_time",
"put_mean",
"cpu_time",
"put_p99",
"db_size",
"put_p95",
"threads",
{
"est_runtime": 378.072129
@ -184,9 +180,7 @@
"real_time",
"put_mean",
"cpu_time",
"put_p99",
"db_size",
"put_p95",
"threads",
{
"est_runtime": 271.474125
@ -749,9 +743,7 @@
"real_time",
"put_mean",
"cpu_time",
"put_p99",
"db_size",
"put_p95",
"threads",
{
"est_runtime": 378.808772
@ -841,9 +833,7 @@
"real_time",
"put_mean",
"cpu_time",
"put_p99",
"db_size",
"put_p95",
"threads",
{
"est_runtime": 378.81272
@ -853,9 +843,7 @@
"real_time",
"put_mean",
"cpu_time",
"put_p99",
"db_size",
"put_p95",
"threads",
{
"est_runtime": 360.424861
@ -961,9 +949,7 @@
"real_time",
"put_mean",
"cpu_time",
"put_p99",
"db_size",
"put_p95",
"threads",
{
"est_runtime": 271.523747
@ -1179,9 +1165,7 @@
"real_time",
"put_mean",
"cpu_time",
"put_p99",
"db_size",
"put_p95",
"threads",
{
"est_runtime": 360.304737
@ -1254,9 +1238,7 @@
"real_time",
"put_mean",
"cpu_time",
"put_p99",
"db_size",
"put_p95",
"threads",
{
"est_runtime": 377.714354
@ -1266,9 +1248,7 @@
"real_time",
"put_mean",
"cpu_time",
"put_p99",
"db_size",
"put_p95",
"threads",
{
"est_runtime": 379.059546
@ -1463,9 +1443,7 @@
"real_time",
"put_mean",
"cpu_time",
"put_p99",
"db_size",
"put_p95",
"threads",
{
"est_runtime": 378.530036
@ -1562,9 +1540,7 @@
"real_time",
"put_mean",
"cpu_time",
"put_p99",
"db_size",
"put_p95",
"threads",
{
"est_runtime": 360.330841

1
buckifier/buckify_rocksdb.py
Unescape View File

@ -1,3 +1,4 @@
#!/usr/bin/env python3
# Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved.
from __future__ import absolute_import
from __future__ import division

Write Preview
Loading…
Cancel
Save