@ -264,6 +264,10 @@ class DBIter final: public Iterator {
Status status_ ;
Status status_ ;
IterKey saved_key_ ;
IterKey saved_key_ ;
// Reusable internal key data structure. This is only used inside one function
// and should not be used across functions. Reusing this object can reduce
// overhead of calling construction of the function if creating it each time.
ParsedInternalKey ikey_ ;
std : : string saved_value_ ;
std : : string saved_value_ ;
Slice pinned_value_ ;
Slice pinned_value_ ;
Direction direction_ ;
Direction direction_ ;
@ -377,22 +381,20 @@ void DBIter::FindNextUserEntryInternal(bool skipping, bool prefix_check) {
uint64_t num_skipped = 0 ;
uint64_t num_skipped = 0 ;
do {
do {
ParsedInternalKey ikey ;
if ( ! ParseKey ( & ikey_ ) ) {
if ( ! ParseKey ( & ikey ) ) {
// Skip corrupted keys.
// Skip corrupted keys.
iter_ - > Next ( ) ;
iter_ - > Next ( ) ;
continue ;
continue ;
}
}
if ( iterate_upper_bound_ ! = nullptr & &
if ( iterate_upper_bound_ ! = nullptr & &
user_comparator_ - > Compare ( ikey . user_key , * iterate_upper_bound_ ) > = 0 ) {
user_comparator_ - > Compare ( ikey_ . user_key , * iterate_upper_bound_ ) > = 0 ) {
break ;
break ;
}
}
if ( prefix_extractor_ & & prefix_check & &
if ( prefix_extractor_ & & prefix_check & &
prefix_extractor_ - > Transform ( ikey . user_key )
prefix_extractor_ - > Transform ( ikey_ . user_key )
. compare ( prefix_start_key_ ) ! = 0 ) {
. compare ( prefix_start_key_ ) ! = 0 ) {
break ;
break ;
}
}
@ -400,32 +402,31 @@ void DBIter::FindNextUserEntryInternal(bool skipping, bool prefix_check) {
return ;
return ;
}
}
if ( ikey . sequence < = sequence_ ) {
if ( ikey_ . sequence < = sequence_ ) {
if ( skipping & &
if ( skipping & & user_comparator_ - > Compare ( ikey_ . user_key ,
user_comparator_ - > Compare ( ikey . user_key , saved_key_ . GetUserKey ( ) ) < =
saved_key_ . GetUserKey ( ) ) < = 0 ) {
0 ) {
num_skipped + + ; // skip this entry
num_skipped + + ; // skip this entry
PERF_COUNTER_ADD ( internal_key_skipped_count , 1 ) ;
PERF_COUNTER_ADD ( internal_key_skipped_count , 1 ) ;
} else {
} else {
num_skipped = 0 ;
num_skipped = 0 ;
switch ( ikey . type ) {
switch ( ikey_ . type ) {
case kTypeDeletion :
case kTypeDeletion :
case kTypeSingleDeletion :
case kTypeSingleDeletion :
// Arrange to skip all upcoming entries for this key since
// Arrange to skip all upcoming entries for this key since
// they are hidden by this deletion.
// they are hidden by this deletion.
saved_key_ . SetUserKey (
saved_key_ . SetUserKey (
ikey . user_key ,
ikey_ . user_key ,
! iter_ - > IsKeyPinned ( ) | | ! pin_thru_lifetime_ /* copy */ ) ;
! pin_thru_lifetime_ | | ! iter_ - > IsKeyPinned ( ) /* copy */ ) ;
skipping = true ;
skipping = true ;
PERF_COUNTER_ADD ( internal_delete_skipped_count , 1 ) ;
PERF_COUNTER_ADD ( internal_delete_skipped_count , 1 ) ;
break ;
break ;
case kTypeValue :
case kTypeValue :
saved_key_ . SetUserKey (
saved_key_ . SetUserKey (
ikey . user_key ,
ikey_ . user_key ,
! iter_ - > IsKeyPinned ( ) | | ! pin_thru_lifetime_ /* copy */ ) ;
! pin_thru_lifetime_ | | ! iter_ - > IsKeyPinned ( ) /* copy */ ) ;
if ( range_del_agg_ . ShouldDelete (
if ( range_del_agg_ . ShouldDelete (
ikey , RangeDelAggregator : : RangePositioningMode : :
ikey_ , RangeDelAggregator : : RangePositioningMode : :
kForwardTraversal ) ) {
kForwardTraversal ) ) {
// Arrange to skip all upcoming entries for this key since
// Arrange to skip all upcoming entries for this key since
// they are hidden by this deletion.
// they are hidden by this deletion.
skipping = true ;
skipping = true ;
@ -438,11 +439,11 @@ void DBIter::FindNextUserEntryInternal(bool skipping, bool prefix_check) {
break ;
break ;
case kTypeMerge :
case kTypeMerge :
saved_key_ . SetUserKey (
saved_key_ . SetUserKey (
ikey . user_key ,
ikey_ . user_key ,
! iter_ - > IsKeyPinned ( ) | | ! pin_thru_lifetime_ /* copy */ ) ;
! pin_thru_lifetime_ | | ! iter_ - > IsKeyPinned ( ) /* copy */ ) ;
if ( range_del_agg_ . ShouldDelete (
if ( range_del_agg_ . ShouldDelete (
ikey , RangeDelAggregator : : RangePositioningMode : :
ikey_ , RangeDelAggregator : : RangePositioningMode : :
kForwardTraversal ) ) {
kForwardTraversal ) ) {
// Arrange to skip all upcoming entries for this key since
// Arrange to skip all upcoming entries for this key since
// they are hidden by this deletion.
// they are hidden by this deletion.
skipping = true ;
skipping = true ;
@ -468,12 +469,12 @@ void DBIter::FindNextUserEntryInternal(bool skipping, bool prefix_check) {
// Here saved_key_ may contain some old key, or the default empty key, or
// Here saved_key_ may contain some old key, or the default empty key, or
// key assigned by some random other method. We don't care.
// key assigned by some random other method. We don't care.
if ( user_comparator_ - > Compare ( ikey . user_key , saved_key_ . GetUserKey ( ) ) < =
if ( user_comparator_ - > Compare ( ikey_ . user_key , saved_key_ . GetUserKey ( ) ) < =
0 ) {
0 ) {
num_skipped + + ;
num_skipped + + ;
} else {
} else {
saved_key_ . SetUserKey (
saved_key_ . SetUserKey (
ikey . user_key ,
ikey_ . user_key ,
! iter_ - > IsKeyPinned ( ) | | ! pin_thru_lifetime_ /* copy */ ) ;
! iter_ - > IsKeyPinned ( ) | | ! pin_thru_lifetime_ /* copy */ ) ;
skipping = false ;
skipping = false ;
num_skipped = 0 ;
num_skipped = 0 ;