Added missing table properties in log (#5168)

Summary:
When a new SST file is created via flush or compaction, we dump out the table properties, however only a few table properties are logged. The change here is to log all the table properties
Pull Request resolved: https://github.com/facebook/rocksdb/pull/5168

Differential Revision: D14876928

Pulled By: vjnadimpalli

fbshipit-source-id: 1aca42ad00f9f650761d39e187f8beeb8700149b
main
vijaynadimpalli 6 years ago committed by Facebook Github Bot
parent fefd4b98c5
commit f49e12b892
  1. 26
      db/event_helpers.cc

@ -87,7 +87,13 @@ void EventHelpers::LogAndNotifyTableFileCreationFinished(
// basic properties: // basic properties:
jwriter << "data_size" << table_properties.data_size << "index_size" jwriter << "data_size" << table_properties.data_size << "index_size"
<< table_properties.index_size << "filter_size" << table_properties.index_size << "index_partitions"
<< table_properties.index_partitions << "top_level_index_size"
<< table_properties.top_level_index_size
<< "index_key_is_user_key"
<< table_properties.index_key_is_user_key
<< "index_value_is_delta_encoded"
<< table_properties.index_value_is_delta_encoded << "filter_size"
<< table_properties.filter_size << "raw_key_size" << table_properties.filter_size << "raw_key_size"
<< table_properties.raw_key_size << "raw_average_key_size" << table_properties.raw_key_size << "raw_average_key_size"
<< SafeDivide(table_properties.raw_key_size, << SafeDivide(table_properties.raw_key_size,
@ -98,7 +104,23 @@ void EventHelpers::LogAndNotifyTableFileCreationFinished(
table_properties.num_entries) table_properties.num_entries)
<< "num_data_blocks" << table_properties.num_data_blocks << "num_data_blocks" << table_properties.num_data_blocks
<< "num_entries" << table_properties.num_entries << "num_entries" << table_properties.num_entries
<< "filter_policy_name" << table_properties.filter_policy_name; << "num_deletions" << table_properties.num_deletions
<< "num_merge_operands" << table_properties.num_merge_operands
<< "num_range_deletions" << table_properties.num_merge_operands
<< "format_version" << table_properties.format_version
<< "fixed_key_len" << table_properties.fixed_key_len
<< "filter_policy" << table_properties.filter_policy_name
<< "column_family_name" << table_properties.column_family_name
<< "column_family_id" << table_properties.column_family_id
<< "comparator" << table_properties.comparator_name
<< "merge_operator" << table_properties.merge_operator_name
<< "prefix_extractor_name"
<< table_properties.prefix_extractor_name << "property_collectors"
<< table_properties.property_collectors_names << "compression"
<< table_properties.compression_name << "compression_options"
<< table_properties.compression_options << "creation_time"
<< table_properties.creation_time << "oldest_key_time"
<< table_properties.oldest_key_time;
// user collected properties // user collected properties
for (const auto& prop : table_properties.readable_properties) { for (const auto& prop : table_properties.readable_properties) {

Loading…
Cancel
Save