fork of https://github.com/oxigraph/rocksdb and https://github.com/facebook/rocksdb for nextgraph and oxigraph

You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Hui Xiao 3573558ec5 Rewrite memory-charging feature's option API (#9926) ... Summary: **Context:** Previous PR https://github.com/facebook/rocksdb/pull/9748, https://github.com/facebook/rocksdb/pull/9073, https://github.com/facebook/rocksdb/pull/8428 added separate flag for each charged memory area. Such API design is not scalable as we charge more and more memory areas. Also, we foresee an opportunity to consolidate this feature with other cache usage related features such as `cache_index_and_filter_blocks` using `CacheEntryRole`. Therefore we decided to consolidate all these flags with `CacheUsageOptions cache_usage_options` and this PR serves as the first step by consolidating memory-charging related flags. **Summary:** - Replaced old API reference with new ones, including making `kCompressionDictionaryBuildingBuffer` opt-out and added a unit test for that - Added missing db bench/stress test for some memory charging features - Renamed related test suite to indicate they are under the same theme of memory charging - Refactored a commonly used mocked cache component in memory charging related tests to reduce code duplication - Replaced the phrases "memory tracking" / "cache reservation" (other than CacheReservationManager-related ones) with "memory charging" for standard description of this feature. Pull Request resolved: https://github.com/facebook/rocksdb/pull/9926 Test Plan: - New unit test for opt-out `kCompressionDictionaryBuildingBuffer` `TEST_F(ChargeCompressionDictionaryBuildingBufferTest, Basic)` - New unit test for option validation/sanitization `TEST_F(CacheUsageOptionsOverridesTest, SanitizeAndValidateOptions)` - CI - db bench (in case querying new options introduces regression) **+0.5% micros/op**: `TEST_TMPDIR=/dev/shm/testdb ./db_bench -benchmarks=fillseq -db=$TEST_TMPDIR -charge_compression_dictionary_building_buffer=1(remove this for comparison) -compression_max_dict_bytes=10000 -disable_auto_compactions=1 -write_buffer_size=100000 -num=4000000 | egrep 'fillseq'` #-run | (pre-PR) avg micros/op | std micros/op | (post-PR) micros/op | std micros/op | change (%) -- | -- | -- | -- | -- | -- 10 | 3.9711 | 0.264408 | 3.9914 | 0.254563 | 0.5111933721 20 | 3.83905 | 0.0664488 | 3.8251 | 0.0695456 | **-0.3633711465** 40 | 3.86625 | 0.136669 | 3.8867 | 0.143765 | **0.5289363078** - db_stress: `python3 tools/db_crashtest.py blackbox -charge_compression_dictionary_building_buffer=1 -charge_filter_construction=1 -charge_table_reader=1 -cache_size=1` killed as normal Reviewed By: ajkr Differential Revision: D36054712 Pulled By: hx235 fbshipit-source-id: d406e90f5e0c5ea4dbcb585a484ad9302d4302af		2 years ago
..
cf_options.cc	Added GetFactoryCount/Names/Types to ObjectRegistry (#9358)	2 years ago
cf_options.h	`compression_per_level` should be used for flush and changeable (#9658)	2 years ago
configurable.cc	Option type info functions (#9411)	2 years ago
configurable_helper.h	Fix some minor issues in the Customizable infrastructure (#8566)	3 years ago
configurable_test.cc	Remove own ToString() (#9955)	2 years ago
configurable_test.h	Move RegisterOptions into the Configurable API (#8223)	3 years ago
customizable.cc	Option type info functions (#9411)	2 years ago
customizable_test.cc	Added GetFactoryCount/Names/Types to ObjectRegistry (#9358)	2 years ago
db_options.cc	Add a temporary option for user to opt-out enforcement of SingleDelete contract (#9983)	2 years ago
db_options.h	Add a temporary option for user to opt-out enforcement of SingleDelete contract (#9983)	2 years ago
options.cc	Provide implementation to prefetch data asynchronously in FilePrefetchBuffer (#9674)	2 years ago
options_helper.cc	Option type info functions (#9411)	2 years ago
options_helper.h	New backup meta schema, with file temperatures (#9660)	2 years ago
options_parser.cc	Remove own ToString() (#9955)	2 years ago
options_parser.h	Bring the Configurable options together (#5753)	4 years ago
options_settable_test.cc	Rewrite memory-charging feature's option API (#9926)	2 years ago
options_test.cc	Rewrite memory-charging feature's option API (#9926)	2 years ago