rocksdb

fork of https://github.com/oxigraph/rocksdb and https://github.com/facebook/rocksdb for nextgraph and oxigraph

Peter Dillinger 27f3af5966 Fix serious FSDirectory use-after-Close bug (missing fsync) (#10460 ) Summary: TL;DR: due to a recent change, if you drop a column family, often that DB will no longer fsync after writing new SST files to remaining or new column families, which could lead to data loss on power loss. More bug detail: The intent of https://github.com/facebook/rocksdb/issues/10049 was to Close FSDirectory objects at DB::Close time rather than waiting for DB object destruction. Unfortunately, it also closes shared FSDirectory objects on DropColumnFamily (& destroy remaining handles), which can lead to use-after-Close on FSDirectory shared with remaining column families. Those "uses" are only Fsyncs (or redundant Closes). In the default Posix filesystem, an Fsync on a closed FSDirectory is a quiet no-op. Consequently (under most configurations), if you drop a column family, that DB will no longer fsync after writing new SST files to column families sharing the same directory (true under most configurations). More fix detail: Basically, this removes unnecessary Close ops on destroying ColumnFamilyData. We let `shared_ptr` take care of calling the destructor at the right time. If the intent was to require Close be called before destroying FSDirectory, that was not made clear by the author of FileSystem and was not at all enforced by https://github.com/facebook/rocksdb/issues/10049, which could have added `assert(fd_ == -1)` to `~PosixDirectory()` but did not. To keep this fix simple, we relax the unit test for https://github.com/facebook/rocksdb/issues/10049 to allow timely destruction of FSDirectory to suffice as Close (in CountedFileSystem). Added a TODO to revisit that. Also in this PR: * Added a TODO to share FSDirectory instances between DB and its column families. (Already shared among column families.) * Made DB::Close attempt to close all its open FSDirectory objects even if there is a failure in closing one. Also code clean-up around this logic. Pull Request resolved: https://github.com/facebook/rocksdb/pull/10460 Test Plan: add an assert to check for use-after-Close. With that existing tests can detect the misuse. With fix, tests pass (except noted relaxing of unit test for https://github.com/facebook/rocksdb/issues/10049) Reviewed By: ajkr Differential Revision: D38357922 Pulled By: pdillinger fbshipit-source-id: d42079cadbedf0a969f03389bf586b3b4e1f9137		2 years ago
.circleci	Run new benchmark script in branch. (#10303 )	2 years ago
.github/workflows	Use released clang-format instead of the one from dev branch (#9646 )	2 years ago
buckifier	Use optimized folly DistributedMutex in LRUCache when available (#10179 )	2 years ago
build_tools	Run new benchmark script in branch. (#10303 )	2 years ago
cache	Fix cache metrics update when secondary cache is used (#10440 )	2 years ago
cmake	gcc-11 and cmake related cleanup (#9286 )	3 years ago
coverage	Fix commit_prereq and other targets (#9797 )	2 years ago
db	Fix serious FSDirectory use-after-Close bug (missing fsync) (#10460 )	2 years ago
db_stress_tool	Stop operating on DB in a stress test background thread (#10373 )	2 years ago
docs	Bump tzinfo from 1.2.9 to 1.2.10 in /docs (#10400 )	2 years ago
env	Fix serious FSDirectory use-after-Close bug (missing fsync) (#10460 )	2 years ago
examples	Add a simple example of backup and restore (#10054 )	2 years ago
file	Provide support for direct_reads with async_io (#10197 )	2 years ago
fuzz	Fix compilation errors and add fuzzers to CircleCI (#9420 )	2 years ago
include/rocksdb	Use EnvLogger instead of PosixLogger (#10436 )	2 years ago
java	Revert "Add a blob-specific cache priority (#10309 )" (#10434 )	2 years ago
logging	Use EnvLogger instead of PosixLogger (#10436 )	2 years ago
memory	Revert "Add a blob-specific cache priority (#10309 )" (#10434 )	2 years ago
memtable	Fix a bug in hash linked list (#10401 )	2 years ago
microbench	Fix overflow in ribbon_bench after #10184 (#10195 )	2 years ago
monitoring	Use EnvLogger instead of PosixLogger (#10436 )	2 years ago
options	Fix race conditions in GenericRateLimiter (#10374 )	2 years ago
plugin	Add initial CMake support to plugin (#9214 )	3 years ago
port	Use EnvLogger instead of PosixLogger (#10436 )	2 years ago
table	Fix cache metrics update when secondary cache is used (#10440 )	2 years ago
test_util	Add seqno to time mapping (#10338 )	2 years ago
third-party	Meta-internal folly integration with F14FastMap (#9546 )	2 years ago
tools	regression_test.sh: kill very old db_bench (and more) (#10441 )	2 years ago
trace_replay	Use std::numeric_limits<> (#9954 )	2 years ago
util	db_bench -use_stderr_info_logger to print timestamp (#10435 )	2 years ago
utilities	Fix serious FSDirectory use-after-Close bug (missing fsync) (#10460 )	2 years ago
.clang-format	A script that automatically reformat affected lines	11 years ago
.gitignore	Snapshots with user-specified timestamps (#9879 )	2 years ago
.lgtm.yml	Create lgtm.yml for LGTM.com C/C++ analysis (#4058 )	6 years ago
.watchmanconfig	Added .watchmanconfig file to rocksdb repo (#5593 )	5 years ago
AUTHORS	Update RocksDB Authors File	7 years ago
CMakeLists.txt	add trace tools flags in CMakeLists (#10404 )	2 years ago
CODE_OF_CONDUCT.md	Adopt Contributor Covenant	5 years ago
CONTRIBUTING.md	Add Code of Conduct	7 years ago
COPYING	Add GPLv2 as an alternative license.	7 years ago
DEFAULT_OPTIONS_HISTORY.md	Add Options::DisableExtraChecks, clarify force_consistency_checks (#9363 )	2 years ago
DUMP_FORMAT.md	First version of rocksdb_dump and rocksdb_undump.	9 years ago
HISTORY.md	Fix serious FSDirectory use-after-Close bug (missing fsync) (#10460 )	2 years ago
INSTALL.md	Update supported VS versions in INSTALL.md (#9823 )	2 years ago
LANGUAGE-BINDINGS.md	Update branch name to "main" in README/LANGUAGE_BINDINGS (#8727 )	3 years ago
LICENSE.Apache	Change RocksDB License	7 years ago
LICENSE.leveldb	Add back the LevelDB license file	7 years ago
Makefile	Add seqno to time mapping (#10338 )	2 years ago
PLUGINS.md	Add pmem-rocksdb-plugin link in PLUGINs.md (#9934 )	2 years ago
README.md	Remove Travis CI (#10407 )	2 years ago
ROCKSDB_LITE.md	Fix remaining uses of "backupable" (#9792 )	2 years ago
TARGETS	Charge blob cache usage against the global memory limit (#10321 )	2 years ago
USERS.md	Add Solana's RocksDB use case in USERS.md (#9558 )	2 years ago
Vagrantfile	Adding CentOS 7 Vagrantfile & build script	6 years ago
WINDOWS_PORT.md	Update branch name in WINDOWS_PORT.md (#8745 )	3 years ago
common.mk	Clean up variables for temporary directory (#9961 )	2 years ago
crash_test.mk	Clean up variables for temporary directory (#9961 )	2 years ago
issue_template.md	Add Google Group to Issue Template	4 years ago
rocksdb.pc.in	build: fix pkg-config file generation (#9953 )	2 years ago
src.mk	Charge blob cache usage against the global memory limit (#10321 )	2 years ago
thirdparty.inc	Fix build jemalloc api (#5470 )	5 years ago

README.md

RocksDB: A Persistent Key-Value Store for Flash and RAM Storage

RocksDB is developed and maintained by Facebook Database Engineering Team. It is built on earlier work on LevelDB by Sanjay Ghemawat (sanjay@google.com) and Jeff Dean (jeff@google.com)

This code is a library that forms the core building block for a fast key-value server, especially suited for storing data on flash drives. It has a Log-Structured-Merge-Database (LSM) design with flexible tradeoffs between Write-Amplification-Factor (WAF), Read-Amplification-Factor (RAF) and Space-Amplification-Factor (SAF). It has multi-threaded compactions, making it especially suitable for storing multiple terabytes of data in a single database.

Start with example usage here: https://github.com/facebook/rocksdb/tree/main/examples

See the github wiki for more explanation.

The public interface is in include/. Callers should not include or rely on the details of any other header files in this package. Those internal APIs may be changed without warning.

Questions and discussions are welcome on the RocksDB Developers Public Facebook group and email list on Google Groups.

License

RocksDB is dual-licensed under both the GPLv2 (found in the COPYING file in the root directory) and Apache 2.0 License (found in the LICENSE.Apache file in the root directory). You may select, at your option, one of the above-listed licenses.