fork of https://github.com/oxigraph/rocksdb and https://github.com/facebook/rocksdb for nextgraph and oxigraph

You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

anand76 54aebb2cc5 Fix cache metrics update when secondary cache is used (#10440) ... Summary: If a secondary cache is configured, its possible that a cache lookup will get a hit in the secondary cache. In that case, the ```LRUCacheShard::Lookup``` doesn't immediately update the ```total_charge``` for the item handle if the ```wait``` parameter is false (i.e caller will call later to check the completeness). However, ```BlockBasedTable::GetEntryFromCache``` assumes the handle is complete and calls ```UpdateCacheHitMetrics```, which checks the usage of the cache item and fails the assert in https://github.com/facebook/rocksdb/blob/main/cache/lru_cache.h#L237 (```assert(total_charge >= meta_charge)```). To fix this, we call ```UpdateCacheHitMetrics``` later in ```MultiGet```, after waiting for all cache lookup completions. Test plan - Run crash test with changes from https://github.com/facebook/rocksdb/issues/10160 Pull Request resolved: https://github.com/facebook/rocksdb/pull/10440 Reviewed By: gitbw95 Differential Revision: D38283968 Pulled By: anand1976 fbshipit-source-id: 31c54ef43517726c6e5fdda81899b364241dd7e1		2 years ago
..
cache.cc	Revert "Add a blob-specific cache priority (#10309)" (#10434)	2 years ago
cache_bench.cc	Add (& fix) some simple source code checks (#8821)	3 years ago
cache_bench_tool.cc	Revert "Add a blob-specific cache priority (#10309)" (#10434)	2 years ago
cache_entry_roles.cc	Charge blob cache usage against the global memory limit (#10321)	2 years ago
cache_entry_roles.h	Expose `CacheEntryRole` and map keys for block cache stat collections (#9838)	2 years ago
cache_entry_stats.h	New stable, fixed-length cache keys (#9126)	3 years ago
cache_helpers.h	Eliminate the copying of blobs when serving reads from the cache (#10297)	2 years ago
cache_key.cc	Enhance new cache key testing & comments (#9329)	2 years ago
cache_key.h	Fix key size in cache_bench (#10234)	2 years ago
cache_reservation_manager.cc	Charge blob cache usage against the global memory limit (#10321)	2 years ago
cache_reservation_manager.h	Account memory of FileMetaData in global memory limit (#9924)	2 years ago
cache_reservation_manager_test.cc	Have Cache use Status::MemoryLimit (#10262)	2 years ago
cache_test.cc	Towards a production-quality ClockCache (#10418)	2 years ago
charged_cache.cc	Charge blob cache usage against the global memory limit (#10321)	2 years ago
charged_cache.h	Charge blob cache usage against the global memory limit (#10321)	2 years ago
clock_cache.cc	Revert "Add a blob-specific cache priority (#10309)" (#10434)	2 years ago
clock_cache.h	Fix assertion failure and memory leak in ClockCache. (#10430)	2 years ago
compressed_secondary_cache.cc	Revert "Add a blob-specific cache priority (#10309)" (#10434)	2 years ago
compressed_secondary_cache.h	Revert "Add a blob-specific cache priority (#10309)" (#10434)	2 years ago
compressed_secondary_cache_test.cc	Revert "Add a blob-specific cache priority (#10309)" (#10434)	2 years ago
fast_lru_cache.cc	Towards a production-quality ClockCache (#10418)	2 years ago
fast_lru_cache.h	Clock cache (#10273)	2 years ago
lru_cache.cc	Fix cache metrics update when secondary cache is used (#10440)	2 years ago
lru_cache.h	Revert "Add a blob-specific cache priority (#10309)" (#10434)	2 years ago
lru_cache_test.cc	Revert "Add a blob-specific cache priority (#10309)" (#10434)	2 years ago
sharded_cache.cc	Update Cache::Release param from force_erase to erase_if_last_ref (#9728)	2 years ago
sharded_cache.h	Charge blob cache usage against the global memory limit (#10321)	2 years ago