fork of https://github.com/oxigraph/rocksdb and https://github.com/facebook/rocksdb for nextgraph and oxigraph

You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Levi Tamasi 6d54eb3dc2 Do not create/install new SuperVersion if nothing was deleted during memtable trim (#6169) ... Summary: We have observed an increase in CPU load caused by frequent calls to `ColumnFamilyData::InstallSuperVersion` from `DBImpl::TrimMemtableHistory` when using `max_write_buffer_size_to_maintain` to limit the amount of memtable history maintained for transaction conflict checking. As it turns out, this is caused by the code creating and installing a new `SuperVersion` even if no memtables were actually trimmed. The patch adds a check to avoid this. Pull Request resolved: https://github.com/facebook/rocksdb/pull/6169 Test Plan: Compared `perf` output for ``` ./db_bench -benchmarks=randomtransaction -optimistic_transaction_db=1 -statistics -stats_interval_seconds=1 -duration=90 -num=500000 --max_write_buffer_size_to_maintain=16000000 --transaction_set_snapshot=1 --threads=32 ``` before and after the change. With the fix, the call chain `rocksdb::DBImpl::TrimMemtableHistory` -> `rocksdb::ColumnFamilyData::InstallSuperVersion` -> `rocksdb::ThreadLocalPtr::StaticMeta::Scrape` no longer registers in the `perf` report. Differential Revision: D19031509 Pulled By: ltamasi fbshipit-source-id: 02686fce594e5b50eba0710e4b28a9b808c8aa20		5 years ago
..
db_impl.cc	Support concurrent CF iteration and drop (#6147)	5 years ago
db_impl.h	wait pending memtable writes on file ingestion or compact range (#6113)	5 years ago
db_impl_compaction_flush.cc	Support concurrent CF iteration and drop (#6147)	5 years ago
db_impl_debug.cc	Fix IngestExternalFile's bug with two_write_queue (#5976)	5 years ago
db_impl_experimental.cc	Support options.max_open_files = -1 with periodic_compaction_seconds (#6090)	5 years ago
db_impl_files.cc	Let DBSecondary close files after catch up (#6114)	5 years ago
db_impl_open.cc	Support concurrent CF iteration and drop (#6147)	5 years ago
db_impl_readonly.cc	Apply formatter on recent 45 commits. (#5827)	5 years ago
db_impl_readonly.h	Use delete to disable automatic generated methods. (#5009)	5 years ago
db_impl_secondary.cc	Let DBSecondary close files after catch up (#6114)	5 years ago
db_impl_secondary.h	Let DBSecondary close files after catch up (#6114)	5 years ago
db_impl_write.cc	Do not create/install new SuperVersion if nothing was deleted during memtable trim (#6169)	5 years ago
db_secondary_test.cc	Break db_stress_tool.cc to a list of source files (#6134)	5 years ago