fork of https://github.com/oxigraph/rocksdb and https://github.com/facebook/rocksdb for nextgraph and oxigraph

You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Levi Tamasi d92a59b6f2 Fix regression affecting partitioned indexes/filters when cache_index_and_filter_blocks is false (#5705) ... Summary: PR https://github.com/facebook/rocksdb/issues/5298 (and subsequent related patches) unintentionally changed the semantics of cache_index_and_filter_blocks: historically, this option only affected the main index/filter block; with the changes, it affects index/filter partitions as well. This can cause performance issues when cache_index_and_filter_blocks is false since in this case, partitions are neither cached nor preloaded (i.e. they are loaded on demand upon each access). The patch reverts to the earlier behavior, that is, partitions are cached similarly to data blocks regardless of the value of the above option. Pull Request resolved: https://github.com/facebook/rocksdb/pull/5705 Test Plan: make check ./db_bench -benchmarks=fillrandom --statistics --stats_interval_seconds=1 --duration=30 --num=500000000 --bloom_bits=20 --partition_index_and_filters=true --cache_index_and_filter_blocks=false ./db_bench -benchmarks=readrandom --use_existing_db --statistics --stats_interval_seconds=1 --duration=10 --num=500000000 --bloom_bits=20 --partition_index_and_filters=true --cache_index_and_filter_blocks=false --cache_size=8000000000 Relevant statistics from the readrandom benchmark with the old code: rocksdb.block.cache.index.miss COUNT : 0 rocksdb.block.cache.index.hit COUNT : 0 rocksdb.block.cache.index.add COUNT : 0 rocksdb.block.cache.index.bytes.insert COUNT : 0 rocksdb.block.cache.index.bytes.evict COUNT : 0 rocksdb.block.cache.filter.miss COUNT : 0 rocksdb.block.cache.filter.hit COUNT : 0 rocksdb.block.cache.filter.add COUNT : 0 rocksdb.block.cache.filter.bytes.insert COUNT : 0 rocksdb.block.cache.filter.bytes.evict COUNT : 0 With the new code: rocksdb.block.cache.index.miss COUNT : 2500 rocksdb.block.cache.index.hit COUNT : 42696 rocksdb.block.cache.index.add COUNT : 2500 rocksdb.block.cache.index.bytes.insert COUNT : 4050048 rocksdb.block.cache.index.bytes.evict COUNT : 0 rocksdb.block.cache.filter.miss COUNT : 2500 rocksdb.block.cache.filter.hit COUNT : 4550493 rocksdb.block.cache.filter.add COUNT : 2500 rocksdb.block.cache.filter.bytes.insert COUNT : 10331040 rocksdb.block.cache.filter.bytes.evict COUNT : 0 Differential Revision: D16817382 Pulled By: ltamasi fbshipit-source-id: 28a516b0da1f041a03313e0b70b28cf5cf205d00		5 years ago
..
block.cc	Add an option to put first key of each sst block in the index (#5289)	5 years ago
block.h	Add an option to put first key of each sst block in the index (#5289)	5 years ago
block_based_filter_block.cc	Fix regression affecting partitioned indexes/filters when cache_index_and_filter_blocks is false (#5705)	5 years ago
block_based_filter_block.h	Move the filter readers out of the block cache (#5504)	5 years ago
block_based_filter_block_test.cc	Move the uncompression dictionary object out of the block cache (#5584)	5 years ago
block_based_table_builder.cc	Add support for timestamp in Get/Put (#5079)	6 years ago
block_based_table_builder.h	Move some memory related files from util/ to memory/ (#5382)	6 years ago
block_based_table_factory.cc	LRU Cache to enable mid-point insertion by default (#5508)	5 years ago
block_based_table_factory.h	Organizing rocksdb/table directory by format	6 years ago
block_based_table_reader.cc	Fix regression affecting partitioned indexes/filters when cache_index_and_filter_blocks is false (#5705)	5 years ago
block_based_table_reader.h	Fix regression affecting partitioned indexes/filters when cache_index_and_filter_blocks is false (#5705)	5 years ago
block_builder.cc	Organizing rocksdb/table directory by format	6 years ago
block_builder.h	Organizing rocksdb/table directory by format	6 years ago
block_prefix_index.cc	Move some memory related files from util/ to memory/ (#5382)	6 years ago
block_prefix_index.h	Organizing rocksdb/table directory by format	6 years ago
block_test.cc	Add an option to put first key of each sst block in the index (#5289)	5 years ago
block_type.h	Make the 'block read count' performance counters consistent (#5484)	5 years ago
cachable_entry.h	Move the filter readers out of the block cache (#5504)	5 years ago
data_block_footer.cc	Organizing rocksdb/table directory by format	6 years ago
data_block_footer.h	Organizing rocksdb/table directory by format	6 years ago
data_block_hash_index.cc	Organizing rocksdb/table directory by format	6 years ago
data_block_hash_index.h	Organizing rocksdb/table directory by format	6 years ago
data_block_hash_index_test.cc	New API to get all merge operands for a Key (#5604)	5 years ago
filter_block.h	Move the filter readers out of the block cache (#5504)	5 years ago
filter_block_reader_common.cc	Fix regression affecting partitioned indexes/filters when cache_index_and_filter_blocks is false (#5705)	5 years ago
filter_block_reader_common.h	Fix regression affecting partitioned indexes/filters when cache_index_and_filter_blocks is false (#5705)	5 years ago
flush_block_policy.cc	Organizing rocksdb/table directory by format	6 years ago
flush_block_policy.h	Organizing rocksdb/table directory by format	6 years ago
full_filter_block.cc	Fix regression affecting partitioned indexes/filters when cache_index_and_filter_blocks is false (#5705)	5 years ago
full_filter_block.h	Move the filter readers out of the block cache (#5504)	5 years ago
full_filter_block_test.cc	Move the uncompression dictionary object out of the block cache (#5584)	5 years ago
index_builder.cc	Add an option to put first key of each sst block in the index (#5289)	5 years ago
index_builder.h	Add an option to put first key of each sst block in the index (#5289)	5 years ago
partitioned_filter_block.cc	Fix regression affecting partitioned indexes/filters when cache_index_and_filter_blocks is false (#5705)	5 years ago
partitioned_filter_block.h	Move the filter readers out of the block cache (#5504)	5 years ago
partitioned_filter_block_test.cc	Move the uncompression dictionary object out of the block cache (#5584)	5 years ago
uncompression_dict_reader.cc	Fix regression affecting partitioned indexes/filters when cache_index_and_filter_blocks is false (#5705)	5 years ago
uncompression_dict_reader.h	Fix regression affecting partitioned indexes/filters when cache_index_and_filter_blocks is false (#5705)	5 years ago