fork of https://github.com/oxigraph/rocksdb and https://github.com/facebook/rocksdb for nextgraph and oxigraph

You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Levi Tamasi d92a59b6f2 Fix regression affecting partitioned indexes/filters when cache_index_and_filter_blocks is false (#5705) ... Summary: PR https://github.com/facebook/rocksdb/issues/5298 (and subsequent related patches) unintentionally changed the semantics of cache_index_and_filter_blocks: historically, this option only affected the main index/filter block; with the changes, it affects index/filter partitions as well. This can cause performance issues when cache_index_and_filter_blocks is false since in this case, partitions are neither cached nor preloaded (i.e. they are loaded on demand upon each access). The patch reverts to the earlier behavior, that is, partitions are cached similarly to data blocks regardless of the value of the above option. Pull Request resolved: https://github.com/facebook/rocksdb/pull/5705 Test Plan: make check ./db_bench -benchmarks=fillrandom --statistics --stats_interval_seconds=1 --duration=30 --num=500000000 --bloom_bits=20 --partition_index_and_filters=true --cache_index_and_filter_blocks=false ./db_bench -benchmarks=readrandom --use_existing_db --statistics --stats_interval_seconds=1 --duration=10 --num=500000000 --bloom_bits=20 --partition_index_and_filters=true --cache_index_and_filter_blocks=false --cache_size=8000000000 Relevant statistics from the readrandom benchmark with the old code: rocksdb.block.cache.index.miss COUNT : 0 rocksdb.block.cache.index.hit COUNT : 0 rocksdb.block.cache.index.add COUNT : 0 rocksdb.block.cache.index.bytes.insert COUNT : 0 rocksdb.block.cache.index.bytes.evict COUNT : 0 rocksdb.block.cache.filter.miss COUNT : 0 rocksdb.block.cache.filter.hit COUNT : 0 rocksdb.block.cache.filter.add COUNT : 0 rocksdb.block.cache.filter.bytes.insert COUNT : 0 rocksdb.block.cache.filter.bytes.evict COUNT : 0 With the new code: rocksdb.block.cache.index.miss COUNT : 2500 rocksdb.block.cache.index.hit COUNT : 42696 rocksdb.block.cache.index.add COUNT : 2500 rocksdb.block.cache.index.bytes.insert COUNT : 4050048 rocksdb.block.cache.index.bytes.evict COUNT : 0 rocksdb.block.cache.filter.miss COUNT : 2500 rocksdb.block.cache.filter.hit COUNT : 4550493 rocksdb.block.cache.filter.add COUNT : 2500 rocksdb.block.cache.filter.bytes.insert COUNT : 10331040 rocksdb.block.cache.filter.bytes.evict COUNT : 0 Differential Revision: D16817382 Pulled By: ltamasi fbshipit-source-id: 28a516b0da1f041a03313e0b70b28cf5cf205d00		5 years ago
..
adaptive	Organizing rocksdb/table directory by format	6 years ago
block_based	Fix regression affecting partitioned indexes/filters when cache_index_and_filter_blocks is false (#5705)	5 years ago
cuckoo	New API to get all merge operands for a Key (#5604)	5 years ago
plain	Add more callers for table reader. (#5454)	5 years ago
block_fetcher.cc	Add an option to put first key of each sst block in the index (#5289)	5 years ago
block_fetcher.h	Combine the read-ahead logic for user reads and compaction reads (#5431)	5 years ago
bloom_block.cc	Change RocksDB License	7 years ago
bloom_block.h	Disallow customized hash function in DynamicBloom (#4915)	6 years ago
cleanable_test.cc	Move test related files under util/ to test_util/ (#5377)	6 years ago
format.cc	Add an option to put first key of each sst block in the index (#5289)	5 years ago
format.h	MultiGet parallel IO (#5464)	5 years ago
full_filter_bits_builder.h	Skip duplicate bloom keys when whole_key and prefix are mixed	7 years ago
get_context.cc	New API to get all merge operands for a Key (#5604)	5 years ago
get_context.h	Fix compiler error by deleting GetContext default ctor (#5685)	5 years ago
internal_iterator.h	Reduce iterator key comparison for upper/lower bound check (2nd attempt) (#5468)	5 years ago
iter_heap.h	Make InternalKeyComparator final and directly use it in merging iterator	7 years ago
iterator.cc	Add an option to put first key of each sst block in the index (#5289)	5 years ago
iterator_wrapper.h	Reduce iterator key comparison for upper/lower bound check (2nd attempt) (#5468)	5 years ago
merger_test.cc	Move test related files under util/ to test_util/ (#5377)	6 years ago
merging_iterator.cc	Reduce iterator key comparison for upper/lower bound check (2nd attempt) (#5468)	5 years ago
merging_iterator.h	Index value delta encoding (#3983)	6 years ago
meta_blocks.cc	Add an option to put first key of each sst block in the index (#5289)	5 years ago
meta_blocks.h	Make the 'block read count' performance counters consistent (#5484)	5 years ago
mock_table.cc	Add more callers for table reader. (#5454)	5 years ago
mock_table.h	Add more callers for table reader. (#5454)	5 years ago
multiget_context.h	multiget: fix memory issues due to vector auto resizing (#5279)	6 years ago
persistent_cache_helper.cc	Organizing rocksdb/table directory by format	6 years ago
persistent_cache_helper.h	Change RocksDB License	7 years ago
persistent_cache_options.h	Change RocksDB License	7 years ago
scoped_arena_iterator.h	Change RocksDB License	7 years ago
sst_file_reader.cc	Add more callers for table reader. (#5454)	5 years ago
sst_file_reader_test.cc	simplify include directive involving inttypes (#5402)	6 years ago
sst_file_writer.cc	Move some memory related files from util/ to memory/ (#5382)	6 years ago
sst_file_writer_collectors.h	Fix SstFileReader not able to open ingested file (#5097)	6 years ago
table_builder.h	Integrate block cache tracer into db_impl (#5433)	6 years ago
table_properties.cc	Organizing rocksdb/table directory by format	6 years ago
table_properties_internal.h	Index value delta encoding (#3983)	6 years ago
table_reader.h	Move the uncompression dictionary object out of the block cache (#5584)	5 years ago
table_reader_bench.cc	New API to get all merge operands for a Key (#5604)	5 years ago
table_reader_caller.h	Add more callers for table reader. (#5454)	5 years ago
table_test.cc	New API to get all merge operands for a Key (#5604)	5 years ago
two_level_iterator.cc	Add an option to put first key of each sst block in the index (#5289)	5 years ago
two_level_iterator.h	Add an option to put first key of each sst block in the index (#5289)	5 years ago