fork of https://github.com/oxigraph/rocksdb and https://github.com/facebook/rocksdb for nextgraph and oxigraph

You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Igor Sugak 9fd6edf81c rocksdb: Replace ASSERT* with EXPECT* in functions that does not return void value ... Summary: gtest does not use exceptions to fail a unit test by design, and `ASSERT*`s are implemented using `return`. As a consequence we cannot use `ASSERT*` in a function that does not return `void` value ([[ https://code.google.com/p/googletest/wiki/AdvancedGuide#Assertion_Placement | 1]]), and have to fix our existing code. This diff does this in a generic way, with no manual changes. In order to detect all existing `ASSERT*` that are used in functions that doesn't return void value, I change the code to generate compile errors for such cases. In `util/testharness.h` I defined `EXPECT*` assertions, the same way as `ASSERT*`, and redefined `ASSERT*` to return `void`. Then executed: ```lang=bash % USE_CLANG=1 make all -j55 -k 2> build.log % perl -naF: -e 'print "-- -number=".$F[1]." ".$F[0]."\n" if /: error:/' \ build.log | xargs -L 1 perl -spi -e 's/ASSERT/EXPECT/g if $. == $number' % make format ``` After that I reverted back change to `ASSERT*` in `util/testharness.h`. But preserved introduced `EXPECT*`, which is the same as `ASSERT*`. This will be deleted once switched to gtest. This diff is independent and contains manual changes only in `util/testharness.h`. Test Plan: Make sure all tests are passing. ```lang=bash % USE_CLANG=1 make check ``` Reviewers: igor, lgalanis, sdong, yufei.zhu, rven, meyering Reviewed By: meyering Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D33333		10 years ago
..
allocator.h	Enforce write buffer memory limit across column families	10 years ago
arena.cc	Make arena use hugepage if possible	10 years ago
arena.h	Removing unnecessary kInlineSize	10 years ago
arena_test.cc	Make arena use hugepage if possible	10 years ago
auto_roll_logger.cc	Add Header to logging to capture application level information	10 years ago
auto_roll_logger.h	rocksdb: Add missing override	10 years ago
auto_roll_logger_test.cc	rocksdb: Replace ASSERT* with EXPECT* in functions that does not return void value	10 years ago
autovector.h	Replace exception by assertion in autovector	10 years ago
autovector_test.cc	Add rocksdb::ToString() to address cases where std::to_string is not available.	10 years ago
benchharness.cc	Add rocksdb::ToString() to address cases where std::to_string is not available.	10 years ago
benchharness.h	mark as unused some variables with cpp-derived names	10 years ago
benchharness_test.cc	Turn on -Wshorten-64-to-32 and fix all the errors	10 years ago
bloom.cc	Turn on -Wshorten-64-to-32 and fix all the errors	10 years ago
bloom_test.cc	Turn on -Wshorten-64-to-32 and fix all the errors	10 years ago
build_version.h	build: do not relink every single binary just for a timestamp	10 years ago
cache.cc	rocksdb: Add missing override	10 years ago
cache_bench.cc	Fix -Wshadow for tools	10 years ago
cache_test.cc	Fix Mac compile errors on util/cache_test.cc	10 years ago
coding.cc	Removing BitStream* functions	10 years ago
coding.h	Turn on -Wshorten-64-to-32 and fix all the errors	10 years ago
coding_test.cc	Remove BitStream* tests	10 years ago
comparator.cc	rocksdb: Add missing override	10 years ago
compression.h	New BlockBasedTable version -- better compressed block format	10 years ago
crc32c.cc	Turn on -Wshorten-64-to-32 and fix all the errors	10 years ago
crc32c.h	Add appropriate LICENSE and Copyright message.	11 years ago
crc32c_test.cc	Add appropriate LICENSE and Copyright message.	11 years ago
db_info_dumper.cc	Fix iOS compile with -Wshorten-64-to-32	10 years ago
db_info_dumper.h	Fix iOS compile with -Wshorten-64-to-32	10 years ago
dynamic_bloom.cc	Enforce write buffer memory limit across column families	10 years ago
dynamic_bloom.h	Enforce write buffer memory limit across column families	10 years ago
dynamic_bloom_test.cc	rocksdb: Fix 'Division by zero' scan-build warning	10 years ago
env.cc	Add Header to logging to capture application level information	10 years ago
env_hdfs.cc	Add rocksdb::ToString() to address cases where std::to_string is not available.	10 years ago
env_posix.cc	Speed up rocksDB close call.	10 years ago
env_test.cc	Speed up rocksDB close call.	10 years ago
event_logger.cc	Include chrono	10 years ago
event_logger.h	Include chrono	10 years ago
event_logger_test.cc	EventLogger	10 years ago
file_util.cc	Provide openable snapshots	10 years ago
file_util.h	Provide openable snapshots	10 years ago
filelock_test.cc	Add appropriate LICENSE and Copyright message.	11 years ago
filter_policy.cc	Add appropriate LICENSE and Copyright message.	11 years ago
hash.cc	Turn on -Wshorten-64-to-32 and fix all the errors	10 years ago
hash.h	Introduce GetThreadList API	10 years ago
hash_cuckoo_rep.cc	Enforce write buffer memory limit across column families	10 years ago
hash_cuckoo_rep.h	Enforce write buffer memory limit across column families	10 years ago
hash_linklist_rep.cc	rocksdb: Add missing override	10 years ago
hash_linklist_rep.h	Enforce write buffer memory limit across column families	10 years ago
hash_skiplist_rep.cc	rocksdb: Add missing override	10 years ago
hash_skiplist_rep.h	Enforce write buffer memory limit across column families	10 years ago
histogram.cc	Fix iOS compile with -Wshorten-64-to-32	10 years ago
histogram.h	Fix iOS compile with -Wshorten-64-to-32	10 years ago
histogram_test.cc	Add appropriate LICENSE and Copyright message.	11 years ago
instrumented_mutex.cc	Perf Context to report DB mutex waiting time	10 years ago
instrumented_mutex.h	Add a counter for collecting the wait time on db mutex.	10 years ago
iostats_context.cc	Fix ios compile	10 years ago
iostats_context_imp.h	Fix ios compile	10 years ago
ldb_cmd.cc	rocksdb: Replace ASSERT* with EXPECT* in functions that does not return void value	10 years ago
ldb_cmd.h	rocksdb: Small refactoring before migrating to gtest	10 years ago
ldb_cmd_execute_result.h	rocksdb: Small refactoring before migrating to gtest	10 years ago
ldb_tool.cc	Added 'dump_live_files' command to ldb tool.	10 years ago
log_buffer.cc	Enlarge log size cap when printing file summary	10 years ago
log_buffer.h	RocksDB on FreeBSD support	10 years ago
log_write_bench.cc	Fix more gflag namespace issues	10 years ago
logging.cc	Make RecordIn/RecordOut human readable	10 years ago
logging.h	Make RecordIn/RecordOut human readable	10 years ago
manual_compaction_test.cc	rocksdb: Add missing override	10 years ago
memenv.cc	rocksdb: Add missing override	10 years ago
memenv_test.cc	Compile MemEnv with standard RocksDB library	10 years ago
mock_env.cc	rocksdb: Add missing override	10 years ago
mock_env.h	rocksdb: Add missing override	10 years ago
mock_env_test.cc	Add fsync / corrupt simulation to env_mem	10 years ago
murmurhash.cc	Add appropriate LICENSE and Copyright message.	11 years ago
murmurhash.h	Turn on -Wshorten-64-to-32 and fix all the errors	10 years ago
mutable_cf_options.cc	options.level_compaction_dynamic_level_bytes to allow RocksDB to pick size bases of levels dynamically.	10 years ago
mutable_cf_options.h	options.level_compaction_dynamic_level_bytes to allow RocksDB to pick size bases of levels dynamically.	10 years ago
mutexlock.h	Add separate Read/WriteUnlock methods in MutexRW.	10 years ago
options.cc	options.level_compaction_dynamic_level_bytes to allow RocksDB to pick size bases of levels dynamically.	10 years ago
options_builder.cc	Remove the compability check on log2 OS_ANDROID as it's already blocked by ROCKSDB_LITE	10 years ago
options_helper.cc	Add rate_limiter to string options	10 years ago
options_helper.h	Missing header in build on CentOS	10 years ago
options_test.cc	Add rate_limiter to string options	10 years ago
perf_context.cc	Instrument memtable seeks	10 years ago
perf_context_imp.h	Refactor PerfStepTimer to stop on destruct	10 years ago
posix_logger.h	rocksdb: Add missing override	10 years ago
random.h	Add appropriate LICENSE and Copyright message.	11 years ago
rate_limiter.cc	Turn on -Wshorten-64-to-32 and fix all the errors	10 years ago
rate_limiter.h	expose RateLimiter definition	10 years ago
rate_limiter_test.cc	Turn on -Wshorten-64-to-32 and fix all the errors	10 years ago
scoped_arena_iterator.h	Remove path with arena==nullptr from NewInternalIterator	10 years ago
signal_test.cc	rocksdb: Fix scan-build 'Called C++ object pointer is null' and 'Dereference of null pointer' bugs	10 years ago
skiplistrep.cc	Enforce write buffer memory limit across column families	10 years ago
slice.cc	rocksdb: Add missing override	10 years ago
slice_transform_test.cc	rocksdb: Replace ASSERT* with EXPECT* in functions that does not return void value	10 years ago
sst_dump_test.cc	Disable pre-fetching of index and filter blocks for sst_dump_tool.	10 years ago
sst_dump_tool.cc	Disable pre-fetching of index and filter blocks for sst_dump_tool.	10 years ago
sst_dump_tool_imp.h	Disable pre-fetching of index and filter blocks for sst_dump_tool.	10 years ago
statistics.cc	Fix assert in histogramData	10 years ago
statistics.h	make statistics forward-able	10 years ago
status.cc	Turn on -Wshorten-64-to-32 and fix all the errors	10 years ago
stl_wrappers.h	Killing Transform Rep	11 years ago
stop_watch.h	Change StopWatch interface	10 years ago
string_util.cc	Clean up StringSplit	10 years ago
string_util.h	Add rocksdb::ToString() to address cases where std::to_string is not available.	10 years ago
sync_point.cc	options.level_compaction_dynamic_level_bytes to allow RocksDB to pick size bases of levels dynamically.	10 years ago
sync_point.h	options.level_compaction_dynamic_level_bytes to allow RocksDB to pick size bases of levels dynamically.	10 years ago
testharness.cc	rocksdb: Replace ASSERT* with EXPECT* in functions that does not return void value	10 years ago
testharness.h	rocksdb: Replace ASSERT* with EXPECT* in functions that does not return void value	10 years ago
testutil.cc	Merger test	10 years ago
testutil.h	rocksdb: Add missing override	10 years ago
thread_list_test.cc	Allow GetThreadList() to report operation stage.	10 years ago
thread_local.cc	Use ustricter consistency in thread local operations	10 years ago
thread_local.h	Improve the comment of util/thread_local.h	10 years ago
thread_local_test.cc	Turn on -Wshadow	10 years ago
thread_operation.h	Allow GetThreadList() to report operation stage.	10 years ago
thread_status_impl.cc	Allow GetThreadList() to report operation stage.	10 years ago
thread_status_updater.cc	Allow GetThreadList() to report operation stage.	10 years ago
thread_status_updater.h	Allow GetThreadList() to report operation stage.	10 years ago
thread_status_updater_debug.cc	Allow GetThreadList() to indicate a thread is doing Compaction.	10 years ago
thread_status_util.cc	Allow GetThreadList() to report operation stage.	10 years ago
thread_status_util.h	Fix compile warning in thread_status_util.h on Mac	10 years ago
thread_status_util_debug.cc	Add thread_status_util_debug.cc back	10 years ago
vectorrep.cc	Enforce write buffer memory limit across column families	10 years ago
xfunc.cc	Managed iterator	10 years ago
xfunc.h	RocksDB on FreeBSD support	10 years ago
xxhash.cc	Prevent xxhash symbols from polluting global namespace	10 years ago
xxhash.h	Prevent xxhash symbols from polluting global namespace	10 years ago