You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Hui Xiao
49623f9c8e
Account memory of big memory users in BlockBasedTable in global memory limit (#9748)
Summary:
**Context:**
Through heap profiling, we discovered that `BlockBasedTableReader` objects can accumulate and lead to high memory usage (e.g, `max_open_file = -1`). These memories are currently not saved, not tracked, not constrained and not cache evict-able. As a first step to improve this, similar to https://github.com/facebook/rocksdb/pull/8428, this PR is to track an estimate of `BlockBasedTableReader` object's memory in block cache and fail future creation if the memory usage exceeds the available space of cache at the time of creation.
**Summary:**
- Approximate big memory users (`BlockBasedTable::Rep` and `TableProperties` )' memory usage in addition to the existing estimated ones (filter block/index block/un-compression dictionary)
- Charge all of these memory usages to block cache on `BlockBasedTable::Open()` and release them on `~BlockBasedTable()` as there is no memory usage fluctuation of concern in between
- Refactor on CacheReservationManager (and its call-sites) to add concurrent support for BlockBasedTable used in this PR.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/9748
Test Plan:
- New unit tests
- db bench: `OpenDb` : **-0.52% in ms**
- Setup `./db_bench -benchmarks=fillseq -db=/dev/shm/testdb -disable_auto_compactions=1 -write_buffer_size=1048576`
- Repeated run with pre-change w/o feature and post-change with feature, benchmark `OpenDb`: `./db_bench -benchmarks=readrandom -use_existing_db=1 -db=/dev/shm/testdb -reserve_table_reader_memory=true (remove this when running w/o feature) -file_opening_threads=3 -open_files=-1 -report_open_timing=true| egrep 'OpenDb:'`
#-run | (feature-off) avg milliseconds | std milliseconds | (feature-on) avg milliseconds | std milliseconds | change (%)
-- | -- | -- | -- | -- | --
10 | 11.4018 | 5.95173 | 9.47788 | 1.57538 | -16.87382694
20 | 9.23746 | 0.841053 | 9.32377 | 1.14074 | 0.9343477536
40 | 9.0876 | 0.671129 | 9.35053 | 1.11713 | 2.893283155
80 | 9.72514 | 2.28459 | 9.52013 | 1.0894 | -2.108041632
160 | 9.74677 | 0.991234 | 9.84743 | 1.73396 | 1.032752389
320 | 10.7297 | 5.11555 | 10.547 | 1.97692 | **-1.70275031**
640 | 11.7092 | 2.36565 | 11.7869 | 2.69377 | **0.6635807741**
- db bench on write with cost to cache in WriteBufferManager (just in case this PR's CRM refactoring accidentally slows down anything in WBM) : `fillseq` : **+0.54% in micros/op**
`./db_bench -benchmarks=fillseq -db=/dev/shm/testdb -disable_auto_compactions=1 -cost_write_buffer_to_cache=true -write_buffer_size=10000000000 | egrep 'fillseq'`
#-run | (pre-PR) avg micros/op | std micros/op | (post-PR) avg micros/op | std micros/op | change (%)
-- | -- | -- | -- | -- | --
10 | 6.15 | 0.260187 | 6.289 | 0.371192 | 2.260162602
20 | 7.28025 | 0.465402 | 7.37255 | 0.451256 | 1.267813605
40 | 7.06312 | 0.490654 | 7.13803 | 0.478676 | **1.060579461**
80 | 7.14035 | 0.972831 | 7.14196 | 0.92971 | **0.02254791432**
- filter bench: `bloom filter`: **-0.78% in ms/key**
- ` ./filter_bench -impl=2 -quick -reserve_table_builder_memory=true | grep 'Build avg'`
#-run | (pre-PR) avg ns/key | std ns/key | (post-PR) ns/key | std ns/key | change (%)
-- | -- | -- | -- | -- | --
10 | 26.4369 | 0.442182 | 26.3273 | 0.422919 | **-0.4145720565**
20 | 26.4451 | 0.592787 | 26.1419 | 0.62451 | **-1.1465262**
- Crash test `python3 tools/db_crashtest.py blackbox --reserve_table_reader_memory=1 --cache_size=1` killed as normal
Reviewed By: ajkr
Differential Revision: D35136549
Pulled By: hx235
fbshipit-source-id: 146978858d0f900f43f4eb09bfd3e83195e3be28
|
3 years ago |
| .. |
|
advisor
|
Update branch as "main" in tools/advisor/README.md (#8744)
|
3 years ago |
|
block_cache_analyzer
|
Cleanup includes in dbformat.h (#8930)
|
3 years ago |
|
dump
|
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
|
5 years ago |
|
CMakeLists.txt
|
Mark dependencies as PRIVATE and fix missing dependencies in tools. (#6790)
|
5 years ago |
|
Dockerfile
|
adding docker build script and dockerfile
|
10 years ago |
|
analyze_txn_stress_test.sh
|
Add copyright headers per FB open-source checkup tool. (#5199)
|
6 years ago |
|
auto_sanity_test.sh
|
Add copyright headers per FB open-source checkup tool. (#5199)
|
6 years ago |
|
backup_db.sh
|
Revamp check_format_compatible.sh (#8012)
|
4 years ago |
|
benchmark.sh
|
Remove deprecated API AdvancedColumnFamilyOptions::rate_limit_delay_max_milliseconds (#9455)
|
3 years ago |
|
benchmark_leveldb.sh
|
Add copyright headers per FB open-source checkup tool. (#5199)
|
6 years ago |
|
blob_dump.cc
|
Remove using namespace (#9369)
|
3 years ago |
|
check_all_python.py
|
Allow missing "unversioned" python, as in CentOS 8 (#6883)
|
5 years ago |
|
check_format_compatible.sh
|
Add 7.0.fb/7.1.fb to check_format_compatible.sh (#9772)
|
3 years ago |
|
db_bench.cc
|
Add (& fix) some simple source code checks (#8821)
|
3 years ago |
|
db_bench_tool.cc
|
Account memory of big memory users in BlockBasedTable in global memory limit (#9748)
|
3 years ago |
|
db_bench_tool_test.cc
|
Remove BlockBasedTableOptions.hash_index_allow_collision (#9454)
|
3 years ago |
|
db_crashtest.py
|
Account memory of big memory users in BlockBasedTable in global memory limit (#9748)
|
3 years ago |
|
db_repl_stress.cc
|
Remove using namespace (#9369)
|
3 years ago |
|
db_sanity_test.cc
|
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
|
5 years ago |
|
dbench_monitor
|
Fix /bin/bash shebangs
|
7 years ago |
|
generate_random_db.sh
|
Add copyright headers per FB open-source checkup tool. (#5199)
|
6 years ago |
|
ingest_external_sst.sh
|
Add copyright headers per FB open-source checkup tool. (#5199)
|
6 years ago |
|
io_tracer_parser.cc
|
Add IO Tracer Parser (#7333)
|
4 years ago |
|
io_tracer_parser_test.cc
|
Cleanup includes in dbformat.h (#8930)
|
3 years ago |
|
io_tracer_parser_tool.cc
|
Add request_id in IODebugContext. (#8045)
|
4 years ago |
|
io_tracer_parser_tool.h
|
Add IO Tracer Parser (#7333)
|
4 years ago |
|
ldb.cc
|
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
|
5 years ago |
|
ldb_cmd.cc
|
Fix remaining uses of "backupable" (#9792)
|
3 years ago |
|
ldb_cmd_impl.h
|
Fix remaining uses of "backupable" (#9792)
|
3 years ago |
|
ldb_cmd_test.cc
|
Add manifest fix-up utility for file temperatures (#9683)
|
3 years ago |
|
ldb_test.py
|
Add support for BlobDB to ldb (#9630)
|
3 years ago |
|
ldb_tool.cc
|
Add manifest fix-up utility for file temperatures (#9683)
|
3 years ago |
|
pflag
|
Fix /bin/bash shebangs
|
7 years ago |
|
reduce_levels_test.cc
|
Remove some unneeded code (#8736)
|
3 years ago |
|
regression_test.sh
|
Fix COMMIT_ID in regression_test.sh (#9047)
|
3 years ago |
|
restore_db.sh
|
Revamp check_format_compatible.sh (#8012)
|
4 years ago |
|
rocksdb_dump_test.sh
|
Add copyright headers per FB open-source checkup tool. (#5199)
|
6 years ago |
|
run_blob_bench.sh
|
Add blob compaction readahead size to the BlobDB benchmark script (#9566)
|
3 years ago |
|
run_flash_bench.sh
|
Add copyright headers per FB open-source checkup tool. (#5199)
|
6 years ago |
|
run_leveldb.sh
|
Add copyright headers per FB open-source checkup tool. (#5199)
|
6 years ago |
|
sample-dump.dmp
|
First version of rocksdb_dump and rocksdb_undump.
|
10 years ago |
|
simulated_hybrid_file_system.cc
|
Improve SimulatedHybridFileSystem (#9301)
|
3 years ago |
|
simulated_hybrid_file_system.h
|
Improve SimulatedHybridFileSystem (#9301)
|
3 years ago |
|
sst_dump.cc
|
Implement a new subcommand "identify" for sst_dump (#6943)
|
5 years ago |
|
sst_dump_test.cc
|
Use the comparator from the sst file table properties in sst_dump_tool (#9491)
|
3 years ago |
|
sst_dump_tool.cc
|
New backup meta schema, with file temperatures (#9660)
|
3 years ago |
|
trace_analyzer.cc
|
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)
|
5 years ago |
|
trace_analyzer_test.cc
|
Disable the QPS verification in test temporally (#9190)
|
3 years ago |
|
trace_analyzer_tool.cc
|
Simplify `TraceAnalyzer` (#8697)
|
3 years ago |
|
trace_analyzer_tool.h
|
Add commit marker with timestamp (#9266)
|
3 years ago |
|
verify_random_db.sh
|
Add copyright headers per FB open-source checkup tool. (#5199)
|
6 years ago |
|
write_external_sst.sh
|
Revamp check_format_compatible.sh (#8012)
|
4 years ago |
|
write_stress.cc
|
Add a SystemClock class to capture the time functions of an Env (#7858)
|
4 years ago |
|
write_stress_runner.py
|
Allow missing "unversioned" python, as in CentOS 8 (#6883)
|
5 years ago |
