fork of https://github.com/oxigraph/rocksdb and https://github.com/facebook/rocksdb for nextgraph and oxigraph

You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Hui Xiao 49623f9c8e Account memory of big memory users in BlockBasedTable in global memory limit (#9748) ... Summary: **Context:** Through heap profiling, we discovered that `BlockBasedTableReader` objects can accumulate and lead to high memory usage (e.g, `max_open_file = -1`). These memories are currently not saved, not tracked, not constrained and not cache evict-able. As a first step to improve this, similar to https://github.com/facebook/rocksdb/pull/8428, this PR is to track an estimate of `BlockBasedTableReader` object's memory in block cache and fail future creation if the memory usage exceeds the available space of cache at the time of creation. **Summary:** - Approximate big memory users (`BlockBasedTable::Rep` and `TableProperties` )' memory usage in addition to the existing estimated ones (filter block/index block/un-compression dictionary) - Charge all of these memory usages to block cache on `BlockBasedTable::Open()` and release them on `~BlockBasedTable()` as there is no memory usage fluctuation of concern in between - Refactor on CacheReservationManager (and its call-sites) to add concurrent support for BlockBasedTable used in this PR. Pull Request resolved: https://github.com/facebook/rocksdb/pull/9748 Test Plan: - New unit tests - db bench: `OpenDb` : **-0.52% in ms** - Setup `./db_bench -benchmarks=fillseq -db=/dev/shm/testdb -disable_auto_compactions=1 -write_buffer_size=1048576` - Repeated run with pre-change w/o feature and post-change with feature, benchmark `OpenDb`: `./db_bench -benchmarks=readrandom -use_existing_db=1 -db=/dev/shm/testdb -reserve_table_reader_memory=true (remove this when running w/o feature) -file_opening_threads=3 -open_files=-1 -report_open_timing=true| egrep 'OpenDb:'` #-run | (feature-off) avg milliseconds | std milliseconds | (feature-on) avg milliseconds | std milliseconds | change (%) -- | -- | -- | -- | -- | -- 10 | 11.4018 | 5.95173 | 9.47788 | 1.57538 | -16.87382694 20 | 9.23746 | 0.841053 | 9.32377 | 1.14074 | 0.9343477536 40 | 9.0876 | 0.671129 | 9.35053 | 1.11713 | 2.893283155 80 | 9.72514 | 2.28459 | 9.52013 | 1.0894 | -2.108041632 160 | 9.74677 | 0.991234 | 9.84743 | 1.73396 | 1.032752389 320 | 10.7297 | 5.11555 | 10.547 | 1.97692 | **-1.70275031** 640 | 11.7092 | 2.36565 | 11.7869 | 2.69377 | **0.6635807741** - db bench on write with cost to cache in WriteBufferManager (just in case this PR's CRM refactoring accidentally slows down anything in WBM) : `fillseq` : **+0.54% in micros/op** `./db_bench -benchmarks=fillseq -db=/dev/shm/testdb -disable_auto_compactions=1 -cost_write_buffer_to_cache=true -write_buffer_size=10000000000 | egrep 'fillseq'` #-run | (pre-PR) avg micros/op | std micros/op | (post-PR) avg micros/op | std micros/op | change (%) -- | -- | -- | -- | -- | -- 10 | 6.15 | 0.260187 | 6.289 | 0.371192 | 2.260162602 20 | 7.28025 | 0.465402 | 7.37255 | 0.451256 | 1.267813605 40 | 7.06312 | 0.490654 | 7.13803 | 0.478676 | **1.060579461** 80 | 7.14035 | 0.972831 | 7.14196 | 0.92971 | **0.02254791432** - filter bench: `bloom filter`: **-0.78% in ms/key** - ` ./filter_bench -impl=2 -quick -reserve_table_builder_memory=true | grep 'Build avg'` #-run | (pre-PR) avg ns/key | std ns/key | (post-PR) ns/key | std ns/key | change (%) -- | -- | -- | -- | -- | -- 10 | 26.4369 | 0.442182 | 26.3273 | 0.422919 | **-0.4145720565** 20 | 26.4451 | 0.592787 | 26.1419 | 0.62451 | **-1.1465262** - Crash test `python3 tools/db_crashtest.py blackbox --reserve_table_reader_memory=1 --cache_size=1` killed as normal Reviewed By: ajkr Differential Revision: D35136549 Pulled By: hx235 fbshipit-source-id: 146978858d0f900f43f4eb09bfd3e83195e3be28		3 years ago
..
binary_search_index_reader.cc	Separate internal and user key comparators in `BlockIter` (#6944)	5 years ago
binary_search_index_reader.h	Extend Get/MultiGet deadline support to table open (#6982)	5 years ago
block.cc	Add NewMetaDataIterator method (#8692)	3 years ago
block.h	Add NewMetaDataIterator method (#8692)	3 years ago
block_based_filter_block.cc	Refactor FilterPolicies toward Customizable (#9567)	3 years ago
block_based_filter_block.h	FilterPolicy API changes for 7.0 (#9501)	3 years ago
block_based_filter_block_test.cc	FilterPolicy API changes for 7.0 (#9501)	3 years ago
block_based_table_builder.cc	Account memory of big memory users in BlockBasedTable in global memory limit (#9748)	3 years ago
block_based_table_builder.h	Fix segmentation fault in table_options.prepopulate_block_cache when used with partition_filters (#9263)	3 years ago
block_based_table_factory.cc	Account memory of big memory users in BlockBasedTable in global memory limit (#9748)	3 years ago
block_based_table_factory.h	Account memory of big memory users in BlockBasedTable in global memory limit (#9748)	3 years ago
block_based_table_iterator.cc	Provide implementation to prefetch data asynchronously in FilePrefetchBuffer (#9674)	3 years ago
block_based_table_iterator.h	Fix bug in rocksdb internal automatic prefetching (#9234)	3 years ago
block_based_table_reader.cc	Account memory of big memory users in BlockBasedTable in global memory limit (#9748)	3 years ago
block_based_table_reader.h	Account memory of big memory users in BlockBasedTable in global memory limit (#9748)	3 years ago
block_based_table_reader_impl.h	Fb 9718 verify checksums is ignored (#9767)	3 years ago
block_based_table_reader_test.cc	Account memory of big memory users in BlockBasedTable in global memory limit (#9748)	3 years ago
block_builder.cc	Improve data block construction performance (#9040)	3 years ago
block_builder.h	Improve data block construction performance (#9040)	3 years ago
block_like_traits.h	Change type of cache buffer passed to `Cache::CreateCallback()` to `const void*` (#9595)	3 years ago
block_prefetcher.cc	Provide implementation to prefetch data asynchronously in FilePrefetchBuffer (#9674)	3 years ago
block_prefetcher.h	Provide implementation to prefetch data asynchronously in FilePrefetchBuffer (#9674)	3 years ago
block_prefix_index.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	5 years ago
block_prefix_index.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	5 years ago
block_test.cc	Improve / clean up meta block code & integrity (#9163)	3 years ago
block_type.h	Fix and detect headers with missing dependencies (#8893)	3 years ago
cachable_entry.h	Parallelize secondary cache lookup in MultiGet (#8405)	4 years ago
data_block_footer.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	5 years ago
data_block_footer.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	5 years ago
data_block_hash_index.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	5 years ago
data_block_hash_index.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	5 years ago
data_block_hash_index_test.cc	Fast path for detecting unchanged prefix_extractor (#9407)	3 years ago
filter_block.h	Detect (new) Bloom/Ribbon Filter construction corruption (#9342)	3 years ago
filter_block_reader_common.cc	Parallelize secondary cache lookup in MultiGet (#8405)	4 years ago
filter_block_reader_common.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	5 years ago
filter_policy.cc	Account memory of big memory users in BlockBasedTable in global memory limit (#9748)	3 years ago
filter_policy_internal.h	Fix a major performance bug in 7.0 re: filter compatibility (#9736)	3 years ago
flush_block_policy.cc	Restore Regex support for ObjectLibrary::Register, rename new APIs to allow old one to be deprecated in the future (#9362)	3 years ago
flush_block_policy.h	Make FlushBlockPolicyFactory into a Customizable class (#8432)	3 years ago
full_filter_block.cc	Detect (new) Bloom/Ribbon Filter construction corruption (#9342)	3 years ago
full_filter_block.h	Hide FilterBits{Builder,Reader} from public API (#9592)	3 years ago
full_filter_block_test.cc	Fix a major performance bug in 7.0 re: filter compatibility (#9736)	3 years ago
hash_index_reader.cc	Make ImmutableOptions struct that inherits from ImmutableCFOptions and ImmutableDBOptions (#8262)	4 years ago
hash_index_reader.h	Extend Get/MultiGet deadline support to table open (#6982)	5 years ago
index_builder.cc	Add (& fix) some simple source code checks (#8821)	3 years ago
index_builder.h	Make db_basic_test pass assert status checked (#7452)	4 years ago
index_reader_common.cc	Parallelize secondary cache lookup in MultiGet (#8405)	4 years ago
index_reader_common.h	Divide block_based_table_reader.cc (#6527)	5 years ago
mock_block_based_table.h	Refactor FilterPolicies toward Customizable (#9567)	3 years ago
parsed_full_filter_block.cc	Hide FilterBits{Builder,Reader} from public API (#9592)	3 years ago
parsed_full_filter_block.h	Use new Insert and Lookup APIs in table reader to support secondary cache (#8315)	4 years ago
partitioned_filter_block.cc	Enable READ_BLOCK_COMPACTION_MICROS to track stats (#9722)	3 years ago
partitioned_filter_block.h	Detect (new) Bloom/Ribbon Filter construction corruption (#9342)	3 years ago
partitioned_filter_block_test.cc	More refactoring ahead of footer & meta changes (#9240)	3 years ago
partitioned_index_iterator.cc	Provide implementation to prefetch data asynchronously in FilePrefetchBuffer (#9674)	3 years ago
partitioned_index_iterator.h	Fix bug in rocksdb internal automatic prefetching (#9234)	3 years ago
partitioned_index_reader.cc	Enable READ_BLOCK_COMPACTION_MICROS to track stats (#9722)	3 years ago
partitioned_index_reader.h	Clarify caching behavior for index and filter partitions (#9068)	3 years ago
reader_common.cc	Update Cache::Release param from force_erase to erase_if_last_ref (#9728)	3 years ago
reader_common.h	Bring the Configurable options together (#5753)	4 years ago
uncompression_dict_reader.cc	Fb 9718 verify checksums is ignored (#9767)	3 years ago
uncompression_dict_reader.h	Fb 9718 verify checksums is ignored (#9767)	3 years ago