fix(manifest:esm): snakecase to remove warning, test for sideeffects field

src/manifest/mod.rs

@@ -193,7 +193,7 @@ impl CargoManifest {
             files: files,
             module: js_file,
             types: dts_file,
-            sideEffects: "false".to_string(),
+            side_effects: "false".to_string(),
         })
     }
 }

src/manifest/npm/esmodules.rs

@@ -17,5 +17,6 @@ pub struct ESModulesPackage {
     pub module: String,
     #[serde(skip_serializing_if = "Option::is_none")]
     pub types: Option<String>,
-    pub sideEffects: String,
+    #[serde(rename = "sideEffects")]
+    pub side_effects: String,
 }

tests/all/manifest.rs

@@ -70,6 +70,7 @@ fn it_creates_a_package_json_default_path() {
     );
     assert_eq!(pkg.module, "wasm_pack.js");
     assert_eq!(pkg.types, "wasm_pack.d.ts");
+    assert_eq!(pkg.side_effects, "false");
 
     let actual_files: HashSet<String> = pkg.files.into_iter().collect();
     let expected_files: HashSet<String> = ["wasm_pack_bg.wasm", "wasm_pack.d.ts", "wasm_pack.js"]

tests/all/utils/manifest.rs

@@ -19,6 +19,8 @@ pub struct NpmPackage {
     pub module: String,
     #[serde(default = "default_none")]
     pub types: String,
+    #[serde(default = "default_none", rename = "sideEffects")]
+    pub side_effects: String,
 }
 
 fn default_none() -> String {